tests: migrate to getFixtures and use class names + fix missing parent::setUp()

Author: williamdes

tests/TestCase/Controller/DevelopersControllerTest.php

@@ -19,6 +19,8 @@
 namespace App\Test\TestCase\Controller;
 
 use App\Model\Table\DevelopersTable;
+use App\Test\Fixture\DevelopersFixture;
+use App\Test\Fixture\NotificationsFixture;
 use Cake\ORM\TableRegistry;
 use Cake\TestSuite\IntegrationTestTrait;
 use Cake\TestSuite\TestCase;
@@ -39,16 +41,17 @@ class DevelopersControllerTest extends TestCase
 
     protected DevelopersTable $Developers;
 
-    /**
-     * Fixtures.
-     */
-    public array $fixtures = [
-        'app.Developers',
-        'app.Notifications',
-    ];
+    public function getFixtures(): array
+    {
+        return [
+            NotificationsFixture::class,
+            DevelopersFixture::class,
+        ];
+    }
 
     public function setUp(): void
     {
+        parent::setUp();
         $this->Developers = TableRegistry::getTableLocator()->get('Developers');
     }
 

tests/TestCase/Controller/EventsControllerTest.php

@@ -3,6 +3,7 @@
 namespace App\Test\TestCase\Controller;
 
 use App\Model\Table\ReportsTable;
+use App\Test\Fixture\ReportsFixture;
 use Cake\ORM\TableRegistry;
 use Cake\TestSuite\IntegrationTestTrait;
 use Cake\TestSuite\TestCase;
@@ -15,13 +16,16 @@ class EventsControllerTest extends TestCase
 
     protected ReportsTable $Reports;
 
-    /**
-     * Fixtures.
-     */
-    public array $fixtures = ['app.Reports'];
+    public function getFixtures(): array
+    {
+        return [
+            ReportsFixture::class,
+        ];
+    }
 
     public function setUp(): void
     {
+        parent::setUp();
         $this->Reports = TableRegistry::getTableLocator()->get('Reports');
     }
 

tests/TestCase/Controller/GithubControllerTest.php

@@ -19,6 +19,10 @@
 namespace App\Test\TestCase\Controller;
 
 use App\Model\Table\ReportsTable;
+use App\Test\Fixture\DevelopersFixture;
+use App\Test\Fixture\IncidentsFixture;
+use App\Test\Fixture\NotificationsFixture;
+use App\Test\Fixture\ReportsFixture;
 use Cake\Core\Configure;
 use Cake\ORM\TableRegistry;
 use Cake\TestSuite\IntegrationTestTrait;
@@ -41,18 +45,19 @@ class GithubControllerTest extends TestCase
 
     protected ReportsTable $Reports;
 
-    /**
-     * Fixtures.
-     */
-    public array $fixtures = [
-        'app.Reports',
-        'app.Developers',
-        'app.Incidents',
-        'app.Notifications',
-    ];
+    public function getFixtures(): array
+    {
+        return [
+            NotificationsFixture::class,
+            DevelopersFixture::class,
+            ReportsFixture::class,
+            IncidentsFixture::class,
+        ];
+    }
 
     public function setUp(): void
     {
+        parent::setUp();
         $this->session(['Developer.id' => 1, 'access_token' => 'abc']);
         $this->Reports = TableRegistry::getTableLocator()->get('Reports');
     }

tests/TestCase/Controller/IncidentsControllerTest.php

@@ -4,6 +4,10 @@
 
 use App\Model\Table\IncidentsTable;
 use App\Model\Table\ReportsTable;
+use App\Test\Fixture\DevelopersFixture;
+use App\Test\Fixture\IncidentsFixture;
+use App\Test\Fixture\NotificationsFixture;
+use App\Test\Fixture\ReportsFixture;
 use Cake\Core\Configure;
 use Cake\ORM\TableRegistry;
 use Cake\TestSuite\EmailTrait;
@@ -24,18 +28,19 @@ class IncidentsControllerTest extends TestCase
     protected IncidentsTable $Incidents;
     protected ReportsTable $Reports;
 
-    /**
-     * Fixtures.
-     */
-    public array $fixtures = [
-        'app.Notifications',
-        'app.Developers',
-        'app.Reports',
-        'app.Incidents',
-    ];
+    public function getFixtures(): array
+    {
+        return [
+            NotificationsFixture::class,
+            DevelopersFixture::class,
+            ReportsFixture::class,
+            IncidentsFixture::class,
+        ];
+    }
 
     public function setUp(): void
     {
+        parent::setUp();
         $this->Incidents = TableRegistry::getTableLocator()->get('Incidents');
         //$Session = new SessionComponent(new ComponentRegistry());
         $this->session(['Developer.id' => 1]);

tests/TestCase/Controller/NotificationsControllerTest.php

@@ -3,6 +3,10 @@
 namespace App\Test\TestCase\Controller;
 
 use App\Model\Table\NotificationsTable;
+use App\Test\Fixture\DevelopersFixture;
+use App\Test\Fixture\IncidentsFixture;
+use App\Test\Fixture\NotificationsFixture;
+use App\Test\Fixture\ReportsFixture;
 use Cake\ORM\TableRegistry;
 use Cake\TestSuite\IntegrationTestTrait;
 use Cake\TestSuite\TestCase;
@@ -18,18 +22,19 @@ class NotificationsControllerTest extends TestCase
 
     protected NotificationsTable $Notifications;
 
-    /**
-     * Fixtures.
-     */
-    public array $fixtures = [
-        'app.Notifications',
-        'app.Developers',
-        'app.Reports',
-        'app.Incidents',
-    ];
+    public function getFixtures(): array
+    {
+        return [
+            NotificationsFixture::class,
+            DevelopersFixture::class,
+            ReportsFixture::class,
+            IncidentsFixture::class,
+        ];
+    }
 
     public function setUp(): void
     {
+        parent::setUp();
         $this->Notifications = TableRegistry::getTableLocator()->get('Notifications');
         $this->session(['Developer.id' => 1, 'read_only' => true]);
     }

tests/TestCase/Controller/ReportsControllerTest.php

@@ -3,6 +3,10 @@
 namespace App\Test\TestCase\Controller;
 
 use App\Model\Table\ReportsTable;
+use App\Test\Fixture\DevelopersFixture;
+use App\Test\Fixture\IncidentsFixture;
+use App\Test\Fixture\NotificationsFixture;
+use App\Test\Fixture\ReportsFixture;
 use Cake\ORM\TableRegistry;
 use Cake\TestSuite\IntegrationTestTrait;
 use Cake\TestSuite\TestCase;
@@ -16,18 +20,19 @@ class ReportsControllerTest extends TestCase
 
     protected ReportsTable $Reports;
 
-    /**
-     * Fixtures.
-     */
-    public array $fixtures = [
-        'app.Notifications',
-        'app.Developers',
-        'app.Reports',
-        'app.Incidents',
-    ];
+    public function getFixtures(): array
+    {
+        return [
+            NotificationsFixture::class,
+            DevelopersFixture::class,
+            ReportsFixture::class,
+            IncidentsFixture::class,
+        ];
+    }
 
     public function setUp(): void
     {
+        parent::setUp();
         $this->Reports = TableRegistry::getTableLocator()->get('Reports');
         $this->session(['Developer.id' => 1]);
     }

tests/TestCase/Model/Table/DevelopersTableTest.php

@@ -19,6 +19,7 @@
 namespace App\Test\TestCase\Model\Table;
 
 use App\Model\Table\DevelopersTable;
+use App\Test\Fixture\DevelopersFixture;
 use Cake\Datasource\Exception\RecordNotFoundException;
 use Cake\ORM\TableRegistry;
 use Cake\TestSuite\TestCase;
@@ -30,10 +31,12 @@ class DevelopersTableTest extends TestCase
 {
     protected DevelopersTable $Developers;
 
-    /**
-     * Fixtures.
-     */
-    public array $fixtures = ['app.Developers'];
+    public function getFixtures(): array
+    {
+        return [
+            DevelopersFixture::class,
+        ];
+    }
 
     /**
      * setUp method

tests/TestCase/Model/Table/IncidentsTableTest.php

@@ -3,6 +3,10 @@
 namespace App\Test\TestCase\Model\Table;
 
 use App\Model\Table\IncidentsTable;
+use App\Test\Fixture\DevelopersFixture;
+use App\Test\Fixture\IncidentsFixture;
+use App\Test\Fixture\NotificationsFixture;
+use App\Test\Fixture\ReportsFixture;
 use Cake\ORM\TableRegistry;
 use Cake\TestSuite\TestCase;
 use PHPUnit\Framework\Attributes\DataProvider;
@@ -19,15 +23,15 @@ class IncidentsTableTest extends TestCase
 {
     protected IncidentsTable $Incidents;
 
-    /**
-     * Fixtures.
-     */
-    public array $fixtures = [
-        'app.Notifications',
-        'app.Developers',
-        'app.Reports',
-        'app.Incidents',
-    ];
+    public function getFixtures(): array
+    {
+        return [
+            NotificationsFixture::class,
+            DevelopersFixture::class,
+            ReportsFixture::class,
+            IncidentsFixture::class,
+        ];
+    }
 
     public function setUp(): void
     {

tests/TestCase/Model/Table/NotificationsTableTest.php

@@ -3,6 +3,10 @@
 namespace App\Test\TestCase\Model\Table;
 
 use App\Model\Table\NotificationsTable;
+use App\Test\Fixture\DevelopersFixture;
+use App\Test\Fixture\IncidentsFixture;
+use App\Test\Fixture\NotificationsFixture;
+use App\Test\Fixture\ReportsFixture;
 use Cake\ORM\TableRegistry;
 use Cake\TestSuite\TestCase;
 
@@ -15,15 +19,15 @@ class NotificationsTableTest extends TestCase
 {
     protected NotificationsTable $Notifications;
 
-    /**
-     * Fixtures.
-     */
-    public array $fixtures = [
-        'app.Notifications',
-        'app.Developers',
-        'app.Reports',
-        'app.Incidents',
-    ];
+    public function getFixtures(): array
+    {
+        return [
+            NotificationsFixture::class,
+            DevelopersFixture::class,
+            ReportsFixture::class,
+            IncidentsFixture::class,
+        ];
+    }
 
     /**
      * setUp method.

tests/TestCase/Model/Table/ReportsTableTest.php

@@ -3,6 +3,10 @@
 namespace App\Test\TestCase\Model\Table;
 
 use App\Model\Table\ReportsTable;
+use App\Test\Fixture\DevelopersFixture;
+use App\Test\Fixture\IncidentsFixture;
+use App\Test\Fixture\NotificationsFixture;
+use App\Test\Fixture\ReportsFixture;
 use Cake\ORM\Query;
 use Cake\ORM\ResultSet;
 use Cake\ORM\TableRegistry;
@@ -14,15 +18,15 @@ class ReportsTableTest extends TestCase
 {
     protected ReportsTable $Reports;
 
-    /**
-     * Fixtures.
-     */
-    public array $fixtures = [
-        'app.Notifications',
-        'app.Developers',
-        'app.Reports',
-        'app.Incidents',
-    ];
+    public function getFixtures(): array
+    {
+        return [
+            NotificationsFixture::class,
+            DevelopersFixture::class,
+            ReportsFixture::class,
+            IncidentsFixture::class,
+        ];
+    }
 
     public function setUp(): void
     {