Developers login should return a Response

williamdes · williamdes · commit 064d35e639e7 · 2026-02-20T12:14:46.000+01:00
diff --git a/src/Controller/DevelopersController.php b/src/Controller/DevelopersController.php
@@ -46,10 +46,11 @@ public function initialize(): void
         ]);
     }
 
-    public function login(): void
+    public function login(): Response
     {
         $url = $this->GithubApi->getRedirectUrl('user:email,public_repo');
-        $this->redirect($url);
+
+        return $this->redirect($url);
     }
 
     public function callback(): ?Response

Original file line number	Diff line number	Diff line change
`@@ -46,10 +46,11 @@ public function initialize(): void`
`46`	`46`	`]);`
`47`	`47`	`}`
`48`	`48`
`49`		`- public function login(): void`
	`49`	`+ public function login(): Response`
`50`	`50`	`{`
`51`	`51`	`$url = $this->GithubApi->getRedirectUrl('user:email,public_repo');`
`52`		`- $this->redirect($url);`
	`52`	`+`
	`53`	`+ return $this->redirect($url);`
`53`	`54`	`}`
`54`	`55`
`55`	`56`	`public function callback(): ?Response`