Skip to content

Commit ad2661a

Browse files
committed
fix: bottom panel tab bar infinite switch flicker
1 parent 3a10ef5 commit ad2661a

1 file changed

Lines changed: 5 additions & 3 deletions

File tree

src/view/PanelView.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -853,9 +853,11 @@ define(function (require, exports, module) {
853853
_toggleMaximize();
854854
});
855855

856-
// Re-check tab overflow when the tab bar resizes (e.g. window resize)
857-
const tabBarResizeObserver = new ResizeObserver(_checkTabOverflow);
858-
tabBarResizeObserver.observe(_$tabsOverflow[0]);
856+
// Observe the outer tab bar container so that only external resizes
857+
// (e.g. window resize) trigger a re-check. Observing _$tabsOverflow
858+
// would cause an infinite loop in WebKit because _checkTabOverflow
859+
// toggles classes that change _$tabsOverflow's size.
860+
new ResizeObserver(_checkTabOverflow).observe(_$tabBar[0]);
859861

860862
// Restore maximize state from preferences (survives reload).
861863
_isMaximized = PreferencesManager.getViewState(PREF_BOTTOM_PANEL_MAXIMIZED) === true;

0 commit comments

Comments
 (0)