Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/hypercorn/asyncio/tcp_server.py
Original file line number Diff line number Diff line change
Expand Up @@ -119,9 +119,7 @@ async def _close(self) -> None:
self.writer.close()
await self.writer.wait_closed()
except (
BrokenPipeError,
ConnectionAbortedError,
ConnectionResetError,
OSError, # Includes Connection*Errors and e.g. EHOSTUNREACH for a vanished peer
RuntimeError,
asyncio.CancelledError,
):
Expand Down
25 changes: 25 additions & 0 deletions tests/asyncio/test_tcp_server.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
from __future__ import annotations

import asyncio
import errno

import pytest

Expand All @@ -12,6 +13,11 @@
from ..helpers import echo_framework


class UnreachableHostWriter(MemoryWriter):
async def wait_closed(self) -> None:
raise OSError(errno.EHOSTUNREACH, "No route to host")


@pytest.mark.asyncio
async def test_completes_on_closed() -> None:
event_loop: asyncio.AbstractEventLoop = asyncio.get_running_loop()
Expand All @@ -31,6 +37,25 @@ async def test_completes_on_closed() -> None:
# hanging.


@pytest.mark.asyncio
async def test_completes_on_unreachable_host_close() -> None:
event_loop: asyncio.AbstractEventLoop = asyncio.get_running_loop()

server = TCPServer(
ASGIWrapper(echo_framework),
event_loop,
Config(),
WorkerContext(None),
{},
MemoryReader(), # type: ignore
UnreachableHostWriter(), # type: ignore
)
server.reader.close() # type: ignore
await server.run()
# Key is that this line is reached, rather than the above line
# raising the OSError from the writer close.


@pytest.mark.asyncio
async def test_complets_on_half_close() -> None:
event_loop: asyncio.AbstractEventLoop = asyncio.get_running_loop()
Expand Down