Skip to content

Commit 281b284

Browse files
Saup21claude
authored andcommitted
fix(example): remove combustion dependency from examples
combustion was only needed to boot Rails/ActionController and pull in active_support. Now that pact ships its own core_ext polyfills, it is no longer required. Remove it from both Gemfiles and replace rails_helper.rb with a comment explaining the change. Also removes webmock from animal-service Gemfile (was only there as a workaround for the WebmockHelpers bug now fixed upstream). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent f08b8ce commit 281b284

5 files changed

Lines changed: 6 additions & 27 deletions

File tree

example/animal-service/Gemfile

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,6 @@ group :development, :test do
55
gem 'pact-ffi', '~> 0.4.28' # added for pact-ruby FFI support
66
gem 'pry'
77
gem 'rspec'
8-
# required for pact-ruby
9-
gem 'combustion'
10-
gem 'webmock'
118
end
129

1310
gem 'rack'

example/animal-service/spec/pact/consumers/http_spec.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
http_pact_provider 'Animal Service', opts: {
1313
pact_dir: File.expand_path('../../../../zoo-app/spec/pacts', __dir__),
1414
http_port: 9292,
15+
provider_setup_port: 9100,
1516
app: AnimalService::Api
1617
}
1718

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,4 @@
11
# frozen_string_literal: true
22

3-
require "combustion"
4-
begin
5-
Combustion.initialize! :action_controller do
6-
config.log_level = :fatal if ENV["LOG"].to_s.empty?
7-
end
8-
rescue => e
9-
# Fail fast if application couldn't be loaded
10-
warn "💥 Failed to load the app: #{e.message}\n#{e.backtrace.join("\n")}"
11-
exit(1)
12-
end
3+
# Previously bootstrapped a combustion/Rails app to pull in active_support.
4+
# No longer needed — pact now ships its own blank?/present?/deep_dup polyfills.

example/zoo-app/Gemfile

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@ group :development, :test do
66
gem 'pact-ffi', '~> 0.4.28' # added for pact-ruby FFI support
77
gem 'pry'
88
gem 'rspec'
9-
# required for pact-ruby
10-
gem 'combustion'
119
end
1210

1311
gem 'rake'
Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,4 @@
1-
require "combustion"
1+
# frozen_string_literal: true
22

3-
begin
4-
Combustion.initialize! :action_controller do
5-
config.log_level = :fatal if ENV["LOG"].to_s.empty?
6-
config.i18n.available_locales = %i[en]
7-
config.i18n.default_locale = :en
8-
end
9-
rescue => e
10-
# Fail fast if application couldn't be loaded
11-
warn "💥 Failed to load the app: #{e.message}\n#{e.backtrace.join("\n")}"
12-
exit(1)
13-
end
3+
# Previously bootstrapped a combustion/Rails app to pull in active_support.
4+
# No longer needed — pact now ships its own blank?/present?/deep_dup polyfills.

0 commit comments

Comments
 (0)