Migrate OCP-38271 from openshift-tests-private

Add test to verify init containers do not restart when removed from node.

- Add pod-initContainer.yaml template

- Add helper functions in node_utils.go

- Add OCP-38271 test in node_e2e/node.go

Author: minmli@redhat.com (original)

Migrated-by: bgudi@redhat.com

Move OCP-38271 test to separate Describe block

Author: BhargaviGudi

test/extended/node/node_e2e/node.go

@@ -6,10 +6,12 @@ import (
 
 	g "github.com/onsi/ginkgo/v2"
 	o "github.com/onsi/gomega"
-	nodeutils "github.com/openshift/origin/test/extended/node"
-	exutil "github.com/openshift/origin/test/extended/util"
 	"k8s.io/apimachinery/pkg/util/wait"
 	e2e "k8s.io/kubernetes/test/e2e/framework"
+
+	nodeutils "github.com/openshift/origin/test/extended/node"
+	exutil "github.com/openshift/origin/test/extended/util"
+	"github.com/openshift/origin/test/extended/util/compat_otp"
 )
 
 var _ = g.Describe("[sig-node] [Jira:Node/Kubelet] Kubelet, CRI-O, CPU manager", func() {
@@ -104,3 +106,52 @@ var _ = g.Describe("[sig-node] [Jira:Node/Kubelet] Kubelet, CRI-O, CPU manager",
 		o.Expect(output).To(o.ContainSubstring("spec.cgroupMode: Unsupported value: \"v1\": supported values: \"v2\", \"\""))
 	})
 })
+
+var _ = g.Describe("[sig-node] [Jira:Node/Kubelet] NODE initContainer policy,volume,readines,quota", func() {
+	defer g.GinkgoRecover()
+
+	var (
+		oc = exutil.NewCLI("node-initcontainer")
+	)
+
+	// Skip all tests on MicroShift clusters as MachineConfig resources are not available
+	g.BeforeEach(func() {
+		isMicroShift, err := exutil.IsMicroShiftCluster(oc.AdminKubeClient())
+		o.Expect(err).NotTo(o.HaveOccurred())
+		if isMicroShift {
+			g.Skip("Skipping test on MicroShift cluster - MachineConfig resources are not available")
+		}
+	})
+
+	//author: bgudi@redhat.com
+	g.It("[OTP] Init containers should not restart when the exited init container is removed from node [OCP-38271]", func() {
+		podInitCon38271 := nodeutils.PodInitConDescription{
+			Template: exutil.FixturePath("testdata", "node", "node_e2e", "pod-initContainer.yaml"),
+		}
+
+		g.By("Test for case OCP-38271")
+		oc.SetupProject()
+		podInitCon38271.Name = "initcon-pod"
+		podInitCon38271.Namespace = oc.Namespace()
+
+		g.By("Create a pod with init container")
+		podInitCon38271.Create(oc)
+		defer podInitCon38271.Delete(oc)
+
+		g.By("Check pod status")
+		err := nodeutils.PodStatus(oc, podInitCon38271.Namespace, podInitCon38271.Name)
+		compat_otp.AssertWaitPollNoErr(err, "pod is not running")
+
+		g.By("Check init container exit normally")
+		err = podInitCon38271.ContainerExit(oc)
+		compat_otp.AssertWaitPollNoErr(err, "container not exit normally")
+
+		g.By("Delete init container")
+		_, err = podInitCon38271.DeleteInitContainer(oc)
+		compat_otp.AssertWaitPollNoErr(err, "fail to delete container")
+
+		g.By("Check init container not restart again")
+		err = podInitCon38271.InitContainerNotRestart(oc)
+		compat_otp.AssertWaitPollNoErr(err, "init container restart")
+	})
+})

test/extended/node/node_utils.go

@@ -6,6 +6,7 @@ import (
 	"fmt"
 	"math/rand"
 	"os"
+	"regexp"
 	"strings"
 	"time"
 
@@ -22,6 +23,7 @@ import (
 
 	machineconfigclient "github.com/openshift/client-go/machineconfiguration/clientset/versioned"
 	exutil "github.com/openshift/origin/test/extended/util"
+	"github.com/openshift/origin/test/extended/util/compat_otp"
 )
 
 // getNodesByLabel returns nodes matching the specified label selector
@@ -671,3 +673,84 @@ func ensureDropInDirectoryExists(ctx context.Context, oc *exutil.CLI, dirPath st
 
 	return nil
 }
+
+// ============================================================================
+// Helper functions for testcases migrated from openshift-tests-private
+// ============================================================================
+
+// PodInitConDescription describes a pod with init container for testing
+type PodInitConDescription struct {
+	Name      string
+	Namespace string
+	Template  string
+}
+
+func (p *PodInitConDescription) Create(oc *exutil.CLI) {
+	configFile := compat_otp.ProcessTemplate(oc, "--ignore-unknown-parameters=true", "-f", p.Template, "-p", "NAME="+p.Name, "NAMESPACE="+p.Namespace)
+	err := oc.AsAdmin().Run("create").Args("-f", configFile).Execute()
+	o.Expect(err).NotTo(o.HaveOccurred())
+}
+
+func (p *PodInitConDescription) Delete(oc *exutil.CLI) {
+	err := oc.AsAdmin().Run("delete").Args("-n", p.Namespace, "pod", p.Name).Execute()
+	o.Expect(err).NotTo(o.HaveOccurred())
+}
+
+func (p *PodInitConDescription) ContainerExit(oc *exutil.CLI) error {
+	return wait.Poll(2*time.Second, 2*time.Minute, func() (bool, error) {
+		initConStatus, err := oc.AsAdmin().Run("get").Args("pod", "-o=jsonpath={.items[0].status.initContainerStatuses[0].state.terminated.reason}", "-n", p.Namespace).Output()
+		framework.Logf("The initContainer status is %v", initConStatus)
+		o.Expect(err).NotTo(o.HaveOccurred())
+		if strings.Contains(initConStatus, "Completed") {
+			framework.Logf("The initContainer exit normally")
+			return true, nil
+		}
+		framework.Logf("The initContainer not exit!")
+		return false, nil
+	})
+}
+
+func (p *PodInitConDescription) DeleteInitContainer(oc *exutil.CLI) (string, error) {
+	nodename, err := oc.AsAdmin().Run("get").Args("pod", "-o=jsonpath={.items[0].spec.nodeName}", "-n", p.Namespace).Output()
+	o.Expect(err).NotTo(o.HaveOccurred())
+	containerID, err := oc.AsAdmin().Run("get").Args("pod", "-o=jsonpath={.items[0].status.initContainerStatuses[0].containerID}", "-n", p.Namespace).Output()
+	o.Expect(err).NotTo(o.HaveOccurred())
+	framework.Logf("The containerID is %v", containerID)
+	initContainerID := string(containerID)[8:]
+	framework.Logf("The initContainerID is %s", initContainerID)
+	return compat_otp.DebugNodeWithChroot(oc, fmt.Sprintf("%s", nodename), "crictl", "rm", initContainerID)
+}
+
+func (p *PodInitConDescription) InitContainerNotRestart(oc *exutil.CLI) error {
+	return wait.Poll(3*time.Minute, 6*time.Minute, func() (bool, error) {
+		re := regexp.MustCompile("running")
+		podname, err := oc.AsAdmin().Run("get").Args("pod", "-o=jsonpath={.items[0].metadata.name}", "-n", p.Namespace).Output()
+		o.Expect(err).NotTo(o.HaveOccurred())
+		output, err := oc.AsAdmin().Run("exec").Args(string(podname), "-n", p.Namespace, "--", "cat", "/mnt/data/test").Output()
+		framework.Logf("The /mnt/data/test: %s", output)
+		o.Expect(err).NotTo(o.HaveOccurred())
+		found := re.FindAllString(output, -1)
+		if lenStr := len(found); lenStr > 1 {
+			framework.Logf("initContainer restart %d times.", (lenStr - 1))
+			return false, nil
+		} else if lenStr == 1 {
+			framework.Logf("initContainer not restart")
+			return true, nil
+		}
+		return false, nil
+	})
+}
+
+// PodStatus checks if pod is in Ready state
+func PodStatus(oc *exutil.CLI, namespace string, podName string) error {
+	framework.Logf("check if pod is available")
+	return wait.Poll(5*time.Second, 3*time.Minute, func() (bool, error) {
+		status, err := oc.AsAdmin().Run("get").Args("pod", podName, "-o=jsonpath={.status.conditions[?(@.type=='Ready')].status}", "-n", namespace).Output()
+		o.Expect(err).NotTo(o.HaveOccurred())
+		if strings.Contains(status, "True") {
+			framework.Logf("Pod is running and container is Ready!")
+			return true, nil
+		}
+		return false, nil
+	})
+}

test/extended/testdata/bindata.go

@@ -0,0 +1,45 @@
+apiVersion: template.openshift.io/v1
+kind: Template
+metadata:
+  name: pod-initcontainer
+objects:
+- kind: Pod
+  apiVersion: v1
+  metadata:
+    name: "${NAME}"
+    namespace: "${NAMESPACE}"
+  spec:
+    securityContext:
+      runAsNonRoot: true
+      seccompProfile:
+        type: RuntimeDefault
+    initContainers:
+    - name: inittest
+      image: "quay.io/openshifttest/hello-openshift@sha256:4200f438cf2e9446f6bcff9d67ceea1f69ed07a2f83363b7fb52529f7ddd8a83"
+      securityContext:
+        allowPrivilegeEscalation: false
+        capabilities:
+          drop:
+          - ALL
+      command: ["bin/sh", "-ec", "echo running >> /mnt/data/test"]
+      volumeMounts:
+      - name: my-volume
+        mountPath: /mnt/data
+    containers:
+    - name: my-container
+      image: "quay.io/openshifttest/hello-openshift@sha256:4200f438cf2e9446f6bcff9d67ceea1f69ed07a2f83363b7fb52529f7ddd8a83"
+      securityContext:
+        allowPrivilegeEscalation: false
+        capabilities:
+          drop:
+          - ALL
+      command: ["/bin/sh", "-ec", "ls /mnt/data; sleep 999999"]
+      volumeMounts:
+      - mountPath: /mnt/data
+        name: my-volume
+    volumes:
+    - name: my-volume
+      emptyDir: {}
+parameters:      
+- name: NAME
+- name: NAMESPACE