Skip to content

Commit c43f2cd

Browse files
committed
OpenShiftUpdateRiskMightApply: bump pending to 15m from 10m
This is to follow up a recent finding [1]. Further digging shows that the related risks to our e2e tests are `TestAlertFeatureE2ETestOTA1813`, `SyntheticRiskA`. They are in the pending state. This pull bump to a longer pending time so that it gives more time window to get e2e finish. It could avoid disruption from Production alerts. We could use `max by (namespace, risk, reason) (last_over_time(cluster_version_risk_conditions{job="cluster-version-operator", condition="Applies", risk!~"TestAlertFeatureE2ETest.*"}[5m]) != 0)` to ignore testing alerts, but it does not look good to have code handling special cases only for testing. This will recover the health of the TP-enabled jobs in CI. [1]. #1367 (comment) [2]. openshift/origin#30929
1 parent e9c1c39 commit c43f2cd

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

install/0000_90_cluster-version-operator_02_prometheusrule_servicemonitor.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,11 @@ spec:
1616
rules:
1717
- alert: OpenShiftUpdateRiskMightApply
1818
annotations:
19-
summary: The cluster might have been exposed to the conditional update risk for 10 minutes.
19+
summary: The cluster might have been exposed to the conditional update risk for 15 minutes.
2020
description: The conditional update risk {{ "{{ $labels.risk }}" }} might apply to the cluster because of {{ "{{ $labels.reason }}" }}, and the cluster update to a version exposed to the risk is not recommended. For more information refer to 'oc adm upgrade'.
2121
runbook_url: https://github.com/openshift/runbooks/blob/master/alerts/cluster-version-operator/OpenShiftUpdateRiskMightApply.md
2222
expr: |
2323
max by (namespace, risk, reason) (last_over_time(cluster_version_risk_conditions{job="cluster-version-operator", condition="Applies"}[5m]) != 0)
24-
for: 10m
24+
for: 15m
2525
labels:
2626
severity: warning

0 commit comments

Comments
 (0)