Skip to content

chore: Update default start date to January 1, 2040#38277

Draft
feanil wants to merge 2 commits intomasterfrom
feanil/push_default_start_date
Draft

chore: Update default start date to January 1, 2040#38277
feanil wants to merge 2 commits intomasterfrom
feanil/push_default_start_date

Conversation

@feanil
Copy link
Copy Markdown
Contributor

@feanil feanil commented Apr 2, 2026

Push this forward so things don't automatically in a few years for future courses.

@feanil feanil marked this pull request as draft April 2, 2026 18:08
@kdmccormick
Copy link
Copy Markdown
Member

kdmccormick commented Apr 2, 2026 •
edited
Loading

For posterity:

  • We know this is a bad fix, but we don't have time to do the right fix, and we want to merge this now in order to reduce the number of courses that will surprise-start on 1/1/2030.
  • We don't want to push it out to like 1/1/2099 because the user has to page through datepicker UI to choose a start date
  • The right fix would probably involve making start nullable, or having a separate available boolean field
    • Or, defaulting the start today to (date.today() + 1 year)
  • We know that a bunch of courses will start on 1/1/2030 regardless of this PR
  • We discussed doing a data migration between now and 1/1/2030, which checks to see if the start date is exactly 1/1/2030 or 1/1/2040 and, if it is, changing it to like (date.today() + 5 years) and raising a warning to the operator

@feanil
chore: Update default start date to January 1, 2040
a67adf5 
Push this forward so things don't automatically in a few years for future courses.
@feanil feanil force-pushed the feanil/push_default_start_date branch from 6a5038b to 0d66a2f Compare April 11, 2026 17:10
@feanil @claude
fix: update hardcoded start date literals in tests to use DEFAULT_STA…
d4b5570 
…RT_DATE

Tests were asserting against the literal `2030-01-01` value instead of
importing the constant, causing failures after the default was updated to 2040.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@feanil feanil force-pushed the feanil/push_default_start_date branch from 0d66a2f to d4b5570 Compare April 11, 2026 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kdmccormick kdmccormick kdmccormick approved these changes

@farhan farhan Awaiting requested review from farhan farhan is a code owner

@irtazaakram irtazaakram Awaiting requested review from irtazaakram irtazaakram is a code owner

@salman2013 salman2013 Awaiting requested review from salman2013 salman2013 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@feanil @kdmccormick