feat: remove enterprise dashboard context imports (ENT-11569)#38094
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
pwnage101
force-pushed
the
pwnage101/ENT-11569
branch
from
87089ed to
4637f70
Compare
pwnage101
commented
Mar 5, 2026
Contributor
Author
pwnage101
left a comment
pwnage101
left a comment
There was a problem hiding this comment.
Note for implementer/reviewer: looks like isort got ran with the wrong parameters. at least fix that.
kiram15
force-pushed
the
pwnage101/ENT-11569
branch
2 times, most recently
from
325efef to
644789f
Compare
kiram15
reviewed
Apr 22, 2026
kiram15
force-pushed
the
pwnage101/ENT-11569
branch
3 times, most recently
from
02fafbf to
c0912bf
Compare
pwnage101
commented
Apr 29, 2026
pwnage101
commented
Apr 29, 2026
pwnage101
commented
Apr 29, 2026
pwnage101
commented
Apr 29, 2026
pwnage101
commented
Apr 29, 2026
kiram15
force-pushed
the
pwnage101/ENT-11569
branch
2 times, most recently
from
646712c to
6ef4473
Compare
pwnage101
commented
Apr 29, 2026
kiram15
force-pushed
the
pwnage101/ENT-11569
branch
from
96c6b3b to
aa08351
Compare
pwnage101
commented
May 6, 2026
pwnage101
commented
May 6, 2026
pwnage101
commented
May 6, 2026
pwnage101
commented
May 6, 2026
pwnage101
commented
May 6, 2026
pwnage101
commented
May 6, 2026
kiram15
force-pushed
the
pwnage101/ENT-11569
branch
from
e6a5988 to
00908ff
Compare
kiram15
requested review from
a team,
farhan,
feanil,
irtazaakram,
kdmccormick and
salman2013
as code owners
kiram15
removed request for
a team,
farhan,
feanil,
irtazaakram,
kdmccormick and
salman2013
kiram15
force-pushed
the
pwnage101/ENT-11569
branch
from
f85f5ec to
c081d09
Compare
kiram15
approved these changes
May 12, 2026
Copilot AI
added a commit
that referenced
this pull request
May 14, 2026
…xt defaults After PR #38094 removed enterprise context variables from student_dashboard() in favor of a DashboardContextEnricher filter pipeline, two issues remained: 1. fail_silently: False could crash the entire dashboard if the enricher is unavailable or fails 2. enterprise_message and enterprise_learner_portal_enabled_message had no explicit defaults in the context dict Changes: - lms/envs/common.py: Changed fail_silently: False to fail_silently: True for DashboardContextEnricher to prevent dashboard crashes - dashboard.py: Added explicit empty-string defaults for enterprise context variables so the template contract is always satisfied Agent-Logs-Url: https://github.com/openedx/openedx-platform/sessions/9dfd421a-df10-4df0-a99f-70d73ea5378e Co-authored-by: kiram15 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: remove enterprise dashboard context imports (ENT-11569)
ENT-11569