Skip to content

Commit 25a2e7c

Browse files
committed
fix: add extracted xblock support
1 parent f08f0b5 commit 25a2e7c

7 files changed

Lines changed: 10 additions & 8 deletions

File tree

lms/djangoapps/course_home_api/outline/tests/test_view.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -881,7 +881,7 @@ def test_vertical_icon(self, block_categories, expected_icon):
881881

882882
assert vertical_data['icon'] == expected_icon
883883

884-
@patch('xmodule.html_block.HtmlBlock.icon_class', 'video')
884+
@patch('xmodule.html_block.HtmlBlock.icon_class', 'video', create=True)
885885
def test_vertical_icon_determined_by_icon_class(self):
886886
"""Test that the API checks the children `icon_class` to determine the icon for the unit."""
887887
self.add_blocks_to_course()

openedx/envs/common.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2087,7 +2087,7 @@ def add_optional_apps(optional_apps, installed_apps):
20872087
# .. toggle_warning: Not production-ready until relevant subtask https://github.com/openedx/edx-platform/issues/34827 is done.
20882088
# .. toggle_creation_date: 2024-11-10
20892089
# .. toggle_target_removal_date: 2026-04-10
2090-
USE_EXTRACTED_DISCUSSION_BLOCK = False
2090+
USE_EXTRACTED_DISCUSSION_BLOCK = True
20912091

20922092
# .. toggle_name: USE_EXTRACTED_PROBLEM_BLOCK
20932093
# .. toggle_default: False
@@ -2097,7 +2097,7 @@ def add_optional_apps(optional_apps, installed_apps):
20972097
# .. toggle_warning: Not production-ready until relevant subtask https://github.com/openedx/edx-platform/issues/34827 is done.
20982098
# .. toggle_creation_date: 2024-11-10
20992099
# .. toggle_target_removal_date: 2026-04-10
2100-
USE_EXTRACTED_PROBLEM_BLOCK = False
2100+
USE_EXTRACTED_PROBLEM_BLOCK = True
21012101

21022102
# .. toggle_name: USE_EXTRACTED_VIDEO_BLOCK
21032103
# .. toggle_default: True

requirements/edx/base.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1300,7 +1300,7 @@ xblock-utils==4.0.0
13001300
# via
13011301
# edx-sga
13021302
# xblock-poll
1303-
xblocks-contrib==0.15.3
1303+
git+https://github.com/openedx/xblocks-contrib.git@remove-legacy-mixins#egg=xblocks-contrib
13041304
# via -r requirements/edx/bundled.in
13051305
xmlsec==1.3.14
13061306
# via

requirements/edx/development.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2327,7 +2327,7 @@ xblock-utils==4.0.0
23272327
# -r requirements/edx/testing.txt
23282328
# edx-sga
23292329
# xblock-poll
2330-
xblocks-contrib==0.15.3
2330+
git+https://github.com/openedx/xblocks-contrib.git@remove-legacy-mixins#egg=xblocks-contrib
23312331
# via
23322332
# -r requirements/edx/doc.txt
23332333
# -r requirements/edx/testing.txt

requirements/edx/doc.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1638,7 +1638,7 @@ xblock-utils==4.0.0
16381638
# -r requirements/edx/base.txt
16391639
# edx-sga
16401640
# xblock-poll
1641-
xblocks-contrib==0.15.3
1641+
git+https://github.com/openedx/xblocks-contrib.git@remove-legacy-mixins#egg=xblocks-contrib
16421642
# via -r requirements/edx/base.txt
16431643
xmlsec==1.3.14
16441644
# via

requirements/edx/testing.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1731,7 +1731,7 @@ xblock-utils==4.0.0
17311731
# -r requirements/edx/base.txt
17321732
# edx-sga
17331733
# xblock-poll
1734-
xblocks-contrib==0.15.3
1734+
git+https://github.com/openedx/xblocks-contrib.git@remove-legacy-mixins#egg=xblocks-contrib
17351735
# via -r requirements/edx/base.txt
17361736
xmlsec==1.3.14
17371737
# via

xmodule/modulestore/__init__.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
from zoneinfo import ZoneInfo
1616

1717
from django.db import transaction
18+
from django.conf import settings
1819
from opaque_keys.edx.keys import AssetKey, CourseKey
1920
from opaque_keys.edx.locations import Location # For import backwards compatibility
2021
from sortedcontainers import SortedKeyList
@@ -1196,7 +1197,8 @@ def __init__( # lint-amnesty, pylint: disable=unused-argument
11961197
# TODO move the inheritance_cache_subsystem to classes which use it
11971198
self.metadata_inheritance_cache_subsystem = metadata_inheritance_cache_subsystem
11981199
self.request_cache = request_cache
1199-
self.xblock_mixins = xblock_mixins
1200+
settings_mixins = getattr(settings, 'XBLOCK_MIXINS', ())
1201+
self.xblock_mixins = tuple(dict.fromkeys(settings_mixins + xblock_mixins))
12001202
self.xblock_select = xblock_select
12011203
self.xblock_field_data_wrappers = xblock_field_data_wrappers
12021204
self.disabled_xblock_types = disabled_xblock_types

0 commit comments

Comments
 (0)