Skip to content

Added LTI Store Documentation. - #1288

Merged
feanil merged 6 commits into
openedx:mainfrom
usmanpm:usmanpm/lti-store-documentation
Oct 7, 2025
Merged

feanil merged 6 commits into
openedx:mainfrom
usmanpm:usmanpm/lti-store-documentation

Conversation

@usmanpm

@usmanpm usmanpm commented Oct 1, 2025 •

Copy link
Copy Markdown
Contributor

Adding two new articles to the documentation:

  • Set up a Reusable LTI Store
  • Set up an LTI Consumer with Reusable LTI Configuration

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 1, 2025
@openedx-webhooks

openedx-webhooks commented Oct 1, 2025 •

Copy link
Copy Markdown

Thanks for the pull request, @usmanpm!

This repository is currently maintained by @openedx/wg-maintenance-docs.openedx.org.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Oct 1, 2025
@usmanpm usmanpm changed the title chore: documentation Draft LTI Store Documentation Oct 1, 2025
@sarina

sarina commented Oct 1, 2025

Copy link
Copy Markdown
Contributor

Hi @usmanpm - let me know if/when I can help with the CLA or a review of the PR.

@mphilbrick211 mphilbrick211 moved this from Needs Triage to Needs Tests Run or CLA Signed in Contributions Oct 2, 2025
@usmanpm usmanpm self-assigned this Oct 3, 2025
@usmanpm
usmanpm requested a review from feanil October 3, 2025 11:27
@usmanpm

usmanpm commented Oct 3, 2025

Copy link
Copy Markdown
Contributor Author

Hi @sarina, thanks for checking in. Yes please, I'd like some help with the CLA.
I've requested @feanil for review as I've been working with him on this, but please feel free to review.

P.S. This is my first PR in a very long time (I'm a Product Manager who doesn't usually dabble in code), so please let me know what I can do better in this one (and moving forward). Thanks!

@usmanpm
usmanpm marked this pull request as ready for review October 3, 2025 11:30
@usmanpm usmanpm changed the title Draft LTI Store Documentation Added LTI Store Documentation Oct 3, 2025
@sarina

sarina commented Oct 3, 2025

Copy link
Copy Markdown
Contributor

@usmanpm do you work for an organization? If so you'll need to figure out how to get on their entity CLA.

Set up an LTI Consumer with Reusable LTI Configuration
######################################################

.. tags:: educator, how-to, lti

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. tags:: educator, how-to, lti
.. tags:: educator, how-to

We only use tags for persona and article type, not subject area.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the lti tag

Set up a Reusable LTI Store
###########################

.. tags:: educator, how-to, lti

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. tags:: educator, how-to, lti
.. tags:: educator, how-to

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the lti tag

.. note::
The following steps correspond to an **LTI 1.3 configuration**.

1. Open Django Admin.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Open Django Admin.
#. Open Django Admin.

Use # signs instead of direct numbers, which will make it much easier to add/remove steps

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used # for all list items

1. Open Django Admin.
2. Navigate to: ``/admin/lti_store/externallticonfiguration/``
(You must be logged in as a staff user with LTI Store model access.)
3. Add a new **External LTI Configuration**.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
3. Add a new **External LTI Configuration**.
3. Add a new **External LTI Configuration**.

You need a blank line here

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added blank lines after list items

2. Navigate to: ``/admin/lti_store/externallticonfiguration/``
(You must be logged in as a staff user with LTI Store model access.)
3. Add a new **External LTI Configuration**.
.. image:: /_images/educator_how_tos/add_lti_store_configuration.png

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. image:: /_images/educator_how_tos/add_lti_store_configuration.png
.. image:: /_images/educator_how_tos/add_lti_store_configuration.png

You also need a blank line here. And images should include alt text, see https://docs.openedx.org/en/latest/documentors/references/quick_reference.html#directives

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added alt text for all images

@feanil feanil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@usmanpm I think sarina's suggestions are good and you can just apply them to fix various formatting issues.

For the CLA, Edly/Arbisoft needs to add you to their entity CLA, can you check in internal about that? They should be familiar with the process.

@usmanpm

usmanpm commented Oct 3, 2025

Copy link
Copy Markdown
Contributor Author

Thanks @sarina for the suggestions, I'll incorporate the fixes and resubmit. And yes, I'm from Arbisoft/Edly.

@feanil Sure thing, I'll check with the relevant folks. I preemptively filled out the CLA with my personal email address though, hope that's not an issue.

@regisb

regisb commented Oct 6, 2025

Copy link
Copy Markdown

CLA email sent :)

@usmanpm
usmanpm force-pushed the usmanpm/lti-store-documentation branch from c10a8aa to b09c050 Compare October 6, 2025 11:11
@usmanpm
usmanpm force-pushed the usmanpm/lti-store-documentation branch from b09c050 to 1bf1a77 Compare October 6, 2025 11:16
@usmanpm
usmanpm requested a review from sarina October 6, 2025 11:22
Comment thread source/links.txt Outdated

.. _IMS LTI Reference Implementation: https://lti-ri.imsglobal.org/keygen/index

.. _Reference Tool: https://lti-ri.imsglobal.org/lti/tools/5621 No newline at end of file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this should be a link to https://lti-ri.imsglobal.org/lti/tools
/5621 instead?

We should maybe clarify places where we mention this to say that you should create your own tools but here is an example one that you can use as reference.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, it links to the reference tool (https://lti-ri.imsglobal.org/lti/tools/5621). It has since been moved inline to the Setting up an LTI Store page

* For testing purposes, use the `Reference Tool <https://lti-ri.imsglobal.org/lti/tools/5621>`_

Comment thread source/links.txt Outdated
.. _AWS Documentation: http://aws.amazon.com/documentation/

.. _Getting Help page: https://open.edx.org/getting-help

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think instead of putting these links in the links.rst file, we should put them in the files where we use them. This is a historic file.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Added inline links, and removed from links.txt in 86da269

@usmanpm
usmanpm requested a review from feanil October 6, 2025 19:45
@mphilbrick211 mphilbrick211 moved this from Needs Tests Run or CLA Signed to In Eng Review in Contributions Oct 6, 2025

@feanil feanil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me!

@feanil feanil changed the title Added LTI Store Documentation Added LTI Store Documentation. Oct 7, 2025
@feanil
feanil merged commit 91bb8da into openedx:main Oct 7, 2025
2 checks passed
@github-project-automation github-project-automation Bot moved this from In Eng Review to Done in Contributions Oct 7, 2025
ayub02 pushed a commit to ayub02/docs.openedx.org that referenced this pull request Dec 11, 2025
* chore: documentation

* add lti store config image for how-to

* updated lti store config documentation and added images

* added new page: set up lti consumer, added images

* Incorporated suggested changes

* Added inline links, removed links from links.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants