Repository navigation
Added LTI Store Documentation. - #1288
Conversation
|
Thanks for the pull request, @usmanpm! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
Hi @usmanpm - let me know if/when I can help with the CLA or a review of the PR. |
|
Hi @sarina, thanks for checking in. Yes please, I'd like some help with the CLA. P.S. This is my first PR in a very long time (I'm a Product Manager who doesn't usually dabble in code), so please let me know what I can do better in this one (and moving forward). Thanks! |
|
@usmanpm do you work for an organization? If so you'll need to figure out how to get on their entity CLA. |
| Set up an LTI Consumer with Reusable LTI Configuration | ||
| ###################################################### | ||
|
|
||
| .. tags:: educator, how-to, lti |
There was a problem hiding this comment.
| .. tags:: educator, how-to, lti | |
| .. tags:: educator, how-to |
We only use tags for persona and article type, not subject area.
| Set up a Reusable LTI Store | ||
| ########################### | ||
|
|
||
| .. tags:: educator, how-to, lti |
There was a problem hiding this comment.
| .. tags:: educator, how-to, lti | |
| .. tags:: educator, how-to |
| .. note:: | ||
| The following steps correspond to an **LTI 1.3 configuration**. | ||
|
|
||
| 1. Open Django Admin. |
There was a problem hiding this comment.
| 1. Open Django Admin. | |
| #. Open Django Admin. |
Use # signs instead of direct numbers, which will make it much easier to add/remove steps
There was a problem hiding this comment.
Used # for all list items
| 1. Open Django Admin. | ||
| 2. Navigate to: ``/admin/lti_store/externallticonfiguration/`` | ||
| (You must be logged in as a staff user with LTI Store model access.) | ||
| 3. Add a new **External LTI Configuration**. |
There was a problem hiding this comment.
| 3. Add a new **External LTI Configuration**. | |
| 3. Add a new **External LTI Configuration**. | |
You need a blank line here
There was a problem hiding this comment.
Added blank lines after list items
| 2. Navigate to: ``/admin/lti_store/externallticonfiguration/`` | ||
| (You must be logged in as a staff user with LTI Store model access.) | ||
| 3. Add a new **External LTI Configuration**. | ||
| .. image:: /_images/educator_how_tos/add_lti_store_configuration.png |
There was a problem hiding this comment.
| .. image:: /_images/educator_how_tos/add_lti_store_configuration.png | |
| .. image:: /_images/educator_how_tos/add_lti_store_configuration.png | |
You also need a blank line here. And images should include alt text, see https://docs.openedx.org/en/latest/documentors/references/quick_reference.html#directives
There was a problem hiding this comment.
Added alt text for all images
feanil
left a comment
There was a problem hiding this comment.
@usmanpm I think sarina's suggestions are good and you can just apply them to fix various formatting issues.
For the CLA, Edly/Arbisoft needs to add you to their entity CLA, can you check in internal about that? They should be familiar with the process.
|
CLA email sent :) |
c10a8aa to
b09c050
Compare
b09c050 to
1bf1a77
Compare
|
|
||
| .. _IMS LTI Reference Implementation: https://lti-ri.imsglobal.org/keygen/index | ||
|
|
||
| .. _Reference Tool: https://lti-ri.imsglobal.org/lti/tools/5621 No newline at end of file |
There was a problem hiding this comment.
Perhaps this should be a link to https://lti-ri.imsglobal.org/lti/tools
/5621 instead?
We should maybe clarify places where we mention this to say that you should create your own tools but here is an example one that you can use as reference.
There was a problem hiding this comment.
Sure, it links to the reference tool (https://lti-ri.imsglobal.org/lti/tools/5621). It has since been moved inline to the Setting up an LTI Store page
| .. _AWS Documentation: http://aws.amazon.com/documentation/ | ||
|
|
||
| .. _Getting Help page: https://open.edx.org/getting-help | ||
|
|
There was a problem hiding this comment.
I think instead of putting these links in the links.rst file, we should put them in the files where we use them. This is a historic file.
There was a problem hiding this comment.
Done. Added inline links, and removed from links.txt in 86da269
* chore: documentation * add lti store config image for how-to * updated lti store config documentation and added images * added new page: set up lti consumer, added images * Incorporated suggested changes * Added inline links, removed links from links.txt
Adding two new articles to the documentation: