Repository navigation
Conversation
When converting OpenTelemetry exponential histograms to Prometheus native histograms, set the ZeroThreshold to zero instead of 1e-128 if it is not set. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Pull request dashboard statusWaiting on reviewers · refreshed 2026-11-09 16:49 UTC Review the latest changes. Status above doesn't look right?
|
2 of 4 tasks
aknuds1
approved these changes
Nov 9, 2026
dashpole
self-requested a review
November 9, 2026 16:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5272 (review) comment where @aknuds1 found that using 1e-128 as the fallback value for undefined zero threshold in the
OpenTelemetry Exponential Histogram to Prometheus native histograms conversion can yield a native histogram
where the zero bucket overlaps positive (or negative) exponential buckets.
This is due to the default 1e-128 number being greater than the smallest possible bucket boundaries (~`2^-1070).
Implementations are not following even the current specification, to be updated, see linked PRs.
Changes
When converting an OpenTelemetry Exponential Histogram to a Prometheus Native Histogram, if
ZeroThresholdis not set, set the Native HistogramZeroThresholdto zero instead of the default value1e-128.CHANGELOG.mdfile updated for non-trivial changes[chore]in the PR title to skip the changelog check🤖 Generated with Claude Code