From d2d90f5478c20594f8c4c18a366997c9b42897a5 Mon Sep 17 00:00:00 2001 From: David Robson Date: Fri, 30 Oct 2026 17:30:11 -0700 Subject: [PATCH 1/2] Enable warnings for default builds. --- CMakeLists.txt | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index a871c88a5b..af4510cb42 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -559,6 +559,12 @@ if(OTELCPP_MAINTAINER_MODE) elseif() message(FATAL_ERROR "Building with unknown compiler in maintainer mode.") endif() +else() + if(MSVC) + add_compile_options(/W3) + elseif(CMAKE_CXX_COMPILER_ID MATCHES "^(GNU|Clang|AppleClang)$") + add_compile_options(-Wall) + endif() endif(OTELCPP_MAINTAINER_MODE) list(APPEND CMAKE_PREFIX_PATH "${CMAKE_BINARY_DIR}") From 49117f7f55cd71cd661ef22c2e961aa6295e2399 Mon Sep 17 00:00:00 2001 From: David Robson Date: Tue, 3 Nov 2026 07:59:57 -0800 Subject: [PATCH 2/2] Fix formatting --- CMakeLists.txt | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index af4510cb42..012cdba664 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -560,11 +560,11 @@ if(OTELCPP_MAINTAINER_MODE) message(FATAL_ERROR "Building with unknown compiler in maintainer mode.") endif() else() - if(MSVC) - add_compile_options(/W3) - elseif(CMAKE_CXX_COMPILER_ID MATCHES "^(GNU|Clang|AppleClang)$") - add_compile_options(-Wall) - endif() + if(MSVC) + add_compile_options(/W3) + elseif(CMAKE_CXX_COMPILER_ID MATCHES "^(GNU|Clang|AppleClang)$") + add_compile_options(-Wall) + endif() endif(OTELCPP_MAINTAINER_MODE) list(APPEND CMAKE_PREFIX_PATH "${CMAKE_BINARY_DIR}")