From cd56076c94a0bd5b024e694c2ec8085ffc193a1b Mon Sep 17 00:00:00 2001
From: Robin Bate Boerop <me@robinbb.com>
Date: Tue, 19 May 2026 11:36:24 -0700
Subject: [PATCH] test: pps runtime libs reach toplevel compile rule

A `(toplevel ...)` stanza that preprocesses with a ppx declaring
`(ppx_runtime_libraries hello)` must pull `hello` into the
toplevel's compile-rule dep set as a glob over its `.cmi` objdir,
even though no source names `Hello` syntactically.

Today the wide `cctx` `.cmi` glob covers it via `requires_compile`
(which `add_pp_runtime_deps` extends with the ppx's runtime libs);
under per-module narrowing the same surface must remain visible
to the consumer.

Signed-off-by: Robin Bate Boerop <me@robinbb.com>
---
 .../toplevel-pps-runtime-libs.t               | 69 +++++++++++++++++++
 1 file changed, 69 insertions(+)
 create mode 100644 test/blackbox-tests/test-cases/per-module-lib-deps/toplevel-pps-runtime-libs.t

diff --git a/test/blackbox-tests/test-cases/per-module-lib-deps/toplevel-pps-runtime-libs.t b/test/blackbox-tests/test-cases/per-module-lib-deps/toplevel-pps-runtime-libs.t
new file mode 100644
index 00000000000..1374b5a41f9
--- /dev/null
+++ b/test/blackbox-tests/test-cases/per-module-lib-deps/toplevel-pps-runtime-libs.t
@@ -0,0 +1,69 @@
+A `(toplevel ...)` stanza with `(preprocess (pps hello_ppx))` —
+where `hello_ppx` declares `(ppx_runtime_libraries hello)` — must
+pull `hello` into the toplevel's compile-rule dep set. Pins that
+the toplevel's compile rule has a glob over `hello`'s byte objdir,
+sourced from the ppx runtime declaration alone — never named in
+source.
+
+  $ make_dune_project 3.24
+
+`hello` is the ppx runtime lib:
+
+  $ mkdir hello
+  $ cat > hello/dune <<EOF
+  > (library (name hello))
+  > EOF
+  $ cat > hello/hello.ml <<EOF
+  > type t = int
+  > EOF
+
+`hello_ppx` is a no-op ppx_rewriter declaring `hello` as a
+runtime lib. The `(ppx.driver ...)` form satisfies dune's
+pps-invocation contract without pulling in ppxlib (matches the
+stub-driver pattern in `ppx-runtime-libraries.t`).
+
+  $ mkdir hello_ppx
+  $ cat > hello_ppx/dune <<EOF
+  > (library
+  >  (name hello_ppx)
+  >  (kind ppx_rewriter)
+  >  (ppx_runtime_libraries hello)
+  >  (ppx.driver (main Hello_ppx.main)))
+  > EOF
+  $ cat > hello_ppx/hello_ppx.ml <<EOF
+  > let main () =
+  >   let out = ref "" in
+  >   let args =
+  >     [ ("-o", Arg.Set_string out, "")
+  >     ; ("--impl", Arg.Set_string (ref ""), "")
+  >     ; ("--as-ppx", Arg.Set (ref false), "")
+  >     ; ("--cookie", Arg.Set (ref false), "")
+  >     ]
+  >   in
+  >   let anon _ = () in
+  >   Arg.parse (Arg.align args) anon "";
+  >   close_out (open_out !out)
+  > EOF
+
+The toplevel preprocesses with `hello_ppx`:
+
+  $ mkdir tp
+  $ cat > tp/dune <<EOF
+  > (toplevel (name tt) (preprocess (pps hello_ppx)))
+  > EOF
+
+  $ dune build tp/tt.exe
+
+The toplevel's compile rule has a glob over `hello`'s byte objdir
+— sourced from `hello_ppx`'s `ppx_runtime_libraries`, with no
+syntactic reference to `Hello` in toplevel sources. (The
+toplevel's synthesised main module isn't user-named, so
+`%{cmo:...}` won't resolve; locate the `.cmo` under the stanza
+dir.)
+
+  $ CMO=$(find _build/default/tp -name '*.cmo' | head -1)
+  $ dune rules --root . --format=json --deps "$CMO" > deps.json
+  $ jq -r 'include "dune"; .[] | depsGlobs
+  >   | select(.dir | endswith("hello/.hello.objs/byte"))
+  >   | .dir + " " + .predicate' < deps.json
+  _build/default/hello/.hello.objs/byte *.cmi