Skip to content

Fix serialization macros with no member variables#5099

Open
GhostVaibhav wants to merge 8 commits into
nlohmann:developfrom
GhostVaibhav:vs-4041
Open

Fix serialization macros with no member variables#5099
GhostVaibhav wants to merge 8 commits into
nlohmann:developfrom
GhostVaibhav:vs-4041

Conversation

@GhostVaibhav
Copy link
Copy Markdown

@GhostVaibhav GhostVaibhav commented Mar 5, 2026

This PR builds upon the previous PR opened for the same issue and updates the relevant files in the relevant places for the same behaviour intended as in the original PR. This is the link to the original PR - #4323

  • The changes are described in detail, both the what and why.
  • If applicable, an existing issue is referenced.
  • The Code coverage remained at 100%. A test case for every new line of code.
  • If applicable, the documentation is updated.
  • The source code is amalgamated by running make amalgamate.

Read the Contribution Guidelines for detailed information.

@GhostVaibhav GhostVaibhav requested a review from nlohmann as a code owner March 5, 2026 14:55
@gregmarr
Copy link
Copy Markdown
Contributor

gregmarr commented Mar 5, 2026

See this comment for a less intrusive suggestion: #4994 (comment)

@github-actions github-actions Bot added M and removed L labels Mar 11, 2026
@GhostVaibhav
Copy link
Copy Markdown
Author

GhostVaibhav commented Apr 1, 2026

Hey @nlohmann, can you approve running the rest of the workflows?

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 1, 2026

🔴 Amalgamation check failed! 🔴

The source code has not been amalgamated. @GhostVaibhav
Please read and follow the Contribution Guidelines.

@gregmarr gregmarr mentioned this pull request Apr 21, 2026
Open
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 2, 2026

This pull request has been marked as stale because it has had no activity for 30 days. While we won’t close it automatically, we encourage you to update or comment if it is still relevant. Keeping pull requests active and up-to-date helps us review and merge changes more efficiently. Thank you for your contributions!

@github-actions github-actions Bot added the state: stale the issue has not been updated in a while and will be closed automatically soon unless it is updated label May 2, 2026
nlohmann
nlohmann reviewed May 8, 2026
View reviewed changes
Comment thread cmake/clang_flags.cmake Outdated
nlohmann
nlohmann requested changes May 8, 2026
View reviewed changes
Copy link
Copy Markdown
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the DCO requirements and amalgamate the source code.

@nlohmann nlohmann removed the state: stale the issue has not been updated in a while and will be closed automatically soon unless it is updated label May 8, 2026
@github-actions github-actions Bot removed the CMake label May 9, 2026
@GhostVaibhav
add: replicated the previous PR's changes for closing 4041
f467e21 
Signed-off-by: Vaibhav Sharma <48472541+GhostVaibhav@users.noreply.github.com>
@GhostVaibhav
This reverts json.hpp changes
5157f89 
Signed-off-by: Vaibhav Sharma <48472541+GhostVaibhav@users.noreply.github.com>
@GhostVaibhav
add: added json.hpp generated through amalgamation
af58c96 
Signed-off-by: Vaibhav Sharma <48472541+GhostVaibhav@users.noreply.github.com>
@GhostVaibhav
add: added separate empty type macros
558a671 
Signed-off-by: Vaibhav Sharma <48472541+GhostVaibhav@users.noreply.github.com>
@GhostVaibhav
fix: fixed the CI issues while building for Ubuntu
b365266 
Signed-off-by: Vaibhav Sharma <48472541+GhostVaibhav@users.noreply.github.com>
@GhostVaibhav
add: added nolint for avoiding the false positive
df51cd4 
Signed-off-by: Vaibhav Sharma <48472541+GhostVaibhav@users.noreply.github.com>
@GhostVaibhav
rem: removed the zero variadic macro args flag
e6241ad 
Signed-off-by: Vaibhav Sharma <48472541+GhostVaibhav@users.noreply.github.com>
@GhostVaibhav
upd: updated the single_include file with amalgamation changes
ac586c0 
Signed-off-by: Vaibhav Sharma <48472541+GhostVaibhav@users.noreply.github.com>
@GhostVaibhav
Copy link
Copy Markdown
Author

GhostVaibhav commented May 9, 2026 •
edited
Loading

Hey @nlohmann, updated the code. Can you run the other workflows? Thanks!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 9, 2026

🔴 Amalgamation check failed! 🔴

The source code has not been amalgamated. @GhostVaibhav
Please read and follow the Contribution Guidelines.

@nlohmann
Copy link
Copy Markdown
Owner

nlohmann commented May 9, 2026

There are some Clang-Tidy warnings, see https://github.com/nlohmann/json/actions/runs/25600095117/job/75152787756

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nlohmann nlohmann nlohmann requested changes

Assignees

No one assigned

Labels

M tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GhostVaibhav @gregmarr @nlohmann