From 7499bc932e201ddd2713ee206d1aa912b899b963 Mon Sep 17 00:00:00 2001 From: George O'Neill Date: Thu, 8 Jan 2026 21:06:29 +0100 Subject: [PATCH 1/3] add additional field --- base_classes/NXdisk_chopper.nxdl.xml | 29 +++++++++++++++++++--------- 1 file changed, 20 insertions(+), 9 deletions(-) diff --git a/base_classes/NXdisk_chopper.nxdl.xml b/base_classes/NXdisk_chopper.nxdl.xml index 8d040bdf6c..10a1f68f52 100644 --- a/base_classes/NXdisk_chopper.nxdl.xml +++ b/base_classes/NXdisk_chopper.nxdl.xml @@ -45,9 +45,23 @@ We refer to this below as the "top-dead-center signal". Angles and positive rotation speeds are measured in an anticlockwise - direction when facing away from the source. + direction when facing away from the source unless otherwise specified in the `handedness` field. + + + Direction of measurement for rotation and positions in the disk-chopper. + Left is the default for historical reasons and implies positive rotation and angles in an anticlockwise + direciton when facing away from the source. + Right matches the default NeXus coordinate system and implies positive rotation and angles in an anticlockwise + direction when looking towards the source - positive rotation matches the positive roll of the system. + Only one from the enumerated list (match text exactly). + + + + + + Type of the disk-chopper: only one from the enumerated list (match text exactly) @@ -58,8 +72,7 @@ - Chopper rotation speed. Positive for anticlockwise rotation when - facing away from the source, negative otherwise. + Chopper rotation speed. @@ -74,8 +87,7 @@ Angle of each edge of every slit from the position of the - top-dead-center timestamp sensor, anticlockwise when facing - away from the source. + top-dead-center timestamp sensor. The first edge must be the opening edge of a slit, thus the last edge may have an angle greater than 360 degrees. @@ -93,8 +105,7 @@ Angular separation of the center of the beam and the - top-dead-center timestamp sensor, anticlockwise when facing - away from the source. + top-dead-center timestamp sensor. @@ -140,9 +151,9 @@ the source. The reference point in the x and y axis is the point on this surface which is the centre of the axle which the disk is spinning around. The reference plane is orthogonal to the z axis and its position is the reference point on that axis. - + Note: This reference point in almost all practical cases is not where the beam passes though. - + .. image:: disk_chopper/disk_chopper.png :width: 40% From d4aa983f54095a6e4a7be82bf3ec54be489ad8e7 Mon Sep 17 00:00:00 2001 From: George O'Neill Date: Thu, 8 Jan 2026 21:10:00 +0100 Subject: [PATCH 2/3] undo change --- base_classes/NXdisk_chopper.nxdl.xml | 25 +++++++------------------ 1 file changed, 7 insertions(+), 18 deletions(-) diff --git a/base_classes/NXdisk_chopper.nxdl.xml b/base_classes/NXdisk_chopper.nxdl.xml index 10a1f68f52..ef4b0e742f 100644 --- a/base_classes/NXdisk_chopper.nxdl.xml +++ b/base_classes/NXdisk_chopper.nxdl.xml @@ -45,23 +45,9 @@ We refer to this below as the "top-dead-center signal". Angles and positive rotation speeds are measured in an anticlockwise - direction when facing away from the source unless otherwise specified in the `handedness` field. + direction when facing away from the source. - - - Direction of measurement for rotation and positions in the disk-chopper. - Left is the default for historical reasons and implies positive rotation and angles in an anticlockwise - direciton when facing away from the source. - Right matches the default NeXus coordinate system and implies positive rotation and angles in an anticlockwise - direction when looking towards the source - positive rotation matches the positive roll of the system. - Only one from the enumerated list (match text exactly). - - - - - - Type of the disk-chopper: only one from the enumerated list (match text exactly) @@ -72,7 +58,8 @@ - Chopper rotation speed. + Chopper rotation speed. Positive for anticlockwise rotation when + facing away from the source, negative otherwise. @@ -87,7 +74,8 @@ Angle of each edge of every slit from the position of the - top-dead-center timestamp sensor. + top-dead-center timestamp sensor, anticlockwise when facing + away from the source. The first edge must be the opening edge of a slit, thus the last edge may have an angle greater than 360 degrees. @@ -105,7 +93,8 @@ Angular separation of the center of the beam and the - top-dead-center timestamp sensor. + top-dead-center timestamp sensor, anticlockwise when facing + away from the source. From 2978abfbffce8f4501511022080e981b90c09306 Mon Sep 17 00:00:00 2001 From: George O'Neill Date: Thu, 8 Jan 2026 21:14:34 +0100 Subject: [PATCH 3/3] add additional field --- base_classes/NXdisk_chopper.nxdl.xml | 25 ++++++++++++++++++------- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/base_classes/NXdisk_chopper.nxdl.xml b/base_classes/NXdisk_chopper.nxdl.xml index ef4b0e742f..10a1f68f52 100644 --- a/base_classes/NXdisk_chopper.nxdl.xml +++ b/base_classes/NXdisk_chopper.nxdl.xml @@ -45,9 +45,23 @@ We refer to this below as the "top-dead-center signal". Angles and positive rotation speeds are measured in an anticlockwise - direction when facing away from the source. + direction when facing away from the source unless otherwise specified in the `handedness` field. + + + Direction of measurement for rotation and positions in the disk-chopper. + Left is the default for historical reasons and implies positive rotation and angles in an anticlockwise + direciton when facing away from the source. + Right matches the default NeXus coordinate system and implies positive rotation and angles in an anticlockwise + direction when looking towards the source - positive rotation matches the positive roll of the system. + Only one from the enumerated list (match text exactly). + + + + + + Type of the disk-chopper: only one from the enumerated list (match text exactly) @@ -58,8 +72,7 @@ - Chopper rotation speed. Positive for anticlockwise rotation when - facing away from the source, negative otherwise. + Chopper rotation speed. @@ -74,8 +87,7 @@ Angle of each edge of every slit from the position of the - top-dead-center timestamp sensor, anticlockwise when facing - away from the source. + top-dead-center timestamp sensor. The first edge must be the opening edge of a slit, thus the last edge may have an angle greater than 360 degrees. @@ -93,8 +105,7 @@ Angular separation of the center of the beam and the - top-dead-center timestamp sensor, anticlockwise when facing - away from the source. + top-dead-center timestamp sensor.