Skip to content

Add documentation for mark favorite as favorite#14808

Closed
GretaD wants to merge 3 commits into
masterfrom
add/favorite-contacts
Closed

Add documentation for mark favorite as favorite#14808
GretaD wants to merge 3 commits into
masterfrom
add/favorite-contacts

Conversation

@GretaD
Copy link
Copy Markdown
Contributor

@GretaD GretaD commented May 11, 2026 •
edited
Loading

☑️ Resolves

🖼️ Screenshots

✅ Checklist

  • I have built the documentation locally and reviewed the output
  • Screenshots are included for visual changes
  • I have not moved or renamed pages (or added a redirect if I did)
  • I have run codespell or similar and addressed any spelling issues

@GretaD GretaD self-assigned this May 11, 2026
@GretaD
Copy link
Copy Markdown
Contributor Author

GretaD commented May 11, 2026

this command make SPHINXBUILD=sphinx-autobuild html shows me an error. If you can test it i would be grateful, otherwise, i will try to fix the error

hamza221
hamza221 requested changes May 11, 2026
View reviewed changes
Comment thread user_manual/groupware/contacts.rst

Various self-explanatory options are available to configure a team, to manage invites and membership, visibility of the team, allowance of other team membership and password protection.

**Prevent teams from being a member of another team**
Copy link
Copy Markdown
Contributor

@hamza221 hamza221 May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this removed

Copy link
Copy Markdown
Contributor Author

@GretaD GretaD May 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont know what caused this or the lint issues, i didnt change anything, i only added the paragraph for favorite contacts

Comment thread user_manual/groupware/contacts.rst Outdated
How to use
To mark a contacts as favorite, hover over a contact, a star will show on the right. Click the start and a yellow star will appear on the contact's avatar to confirm it's been marked as a favorite.

To remove it form the favorite list - Hover over a favorited contact, hover over the contact and click the start on the right. The star will disappear and the contact will return to its alphabetical position in the list.
Copy link
Copy Markdown
Contributor

@hamza221 hamza221 May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hover over a favorited contact, hover over the contact

Looks like accidental repetition ?

Comment thread user_manual/groupware/contacts.rst Outdated
.. versionadded:: 8.4
Now you can mark contacts as favorites to always find them at the top of your contacts list, without needing to search or filter.
How to use
To mark a contacts as favorite, hover over a contact, a star will show on the right. Click the start and a yellow star will appear on the contact's avatar to confirm it's been marked as a favorite.
Copy link
Copy Markdown
Contributor

@hamza221 hamza221 May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To mark a contacts as favorite, hover over a contact, a star will show on the right. Click the start and a yellow star will appear on the contact's avatar to confirm it's been marked as a favorite.
To mark a contacts as favorite, hover over a contact, a star will show on the right. Click the star and a yellow star will appear on the contact's avatar to confirm it's been marked as a favorite.

Comment thread user_manual/groupware/contacts.rst Outdated
How to use
To mark a contacts as favorite, hover over a contact, a star will show on the right. Click the start and a yellow star will appear on the contact's avatar to confirm it's been marked as a favorite.

To remove it form the favorite list - Hover over a favorited contact, hover over the contact and click the start on the right. The star will disappear and the contact will return to its alphabetical position in the list.
Copy link
Copy Markdown
Contributor

@hamza221 hamza221 May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To remove it form the favorite list - Hover over a favorited contact, hover over the contact and click the start on the right. The star will disappear and the contact will return to its alphabetical position in the list.
To remove it form the favorite list - Hover over a favorited contact, hover over the contact and click the star on the right. The star will disappear and the contact will return to its alphabetical position in the list.

@skjnldsv
Copy link
Copy Markdown
Member

skjnldsv commented May 12, 2026

this command make SPHINXBUILD=sphinx-autobuild html shows me an error. If you can test it i would be grateful, otherwise, i will try to fix the error

/home/runner/work/documentation/documentation/user_manual/groupware/contacts.rst:161: WARNING: Explicit markup ends without a blank line; unexpected unindent. [docutils]
/home/runner/work/documentation/documentation/user_manual/groupware/contacts.rst:167: WARNING: image file not readable: images/mark_favorite.png [image.not_readable]

You can check the GitHub ci results

@skjnldsv
Copy link
Copy Markdown
Member

skjnldsv commented May 12, 2026

And linting

user_manual/groupware/contacts.rst:44: OMG TABS!!!1 (horizontal-tab)
user_manual/groupware/contacts.rst:45: OMG TABS!!!1 (horizontal-tab)
user_manual/groupware/contacts.rst:49: OMG TABS!!!1 (horizontal-tab)
user_manual/groupware/contacts.rst:50: OMG TABS!!!1 (horizontal-tab)
user_manual/groupware/contacts.rst:101: OMG TABS!!!1 (horizontal-tab)
user_manual/groupware/contacts.rst:106: OMG TABS!!!1 (horizontal-tab)

(Please rebase to fix the config_sample linting issue)

GretaD added 2 commits May 26, 2026 11:06
@GretaD
Add documentation for mark favorite as favorite
39356b6 
Signed-off-by: greta <gretadoci@gmail.com>
@GretaD
fixup! Add documentation for mark favorite as favorite
4e742e2 
Signed-off-by: greta <gretadoci@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 26, 2026 •
edited
Loading

📖 Documentation Preview

🔍 Open preview →

📄 1 changed documentation page

Last updated: Tue, 26 May 2026 09:27:12 GMT

@GretaD
fixup! Add documentation for mark favorite as favorite
2ef7798 
Signed-off-by: greta <gretadoci@gmail.com>
@GretaD GretaD force-pushed the add/favorite-contacts branch from d9dddd5 to 2ef7798 Compare May 26, 2026 09:21
@GretaD
Copy link
Copy Markdown
Contributor Author

GretaD commented May 26, 2026

closing and starting from scratch here #15010

@GretaD GretaD closed this May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hamza221 hamza221 hamza221 requested changes

@SebastianKrupinski SebastianKrupinski SebastianKrupinski approved these changes

@GVodyanov GVodyanov Awaiting requested review from GVodyanov GVodyanov is a code owner

Assignees

@GretaD GretaD

Labels

2. developing manual: user

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GretaD @skjnldsv @hamza221 @SebastianKrupinski