feature: Add support for auth-agent (server) with adjusted test#1468
Open
Luwdo wants to merge 5 commits into
Open
feature: Add support for auth-agent (server) with adjusted test#1468Luwdo wants to merge 5 commits into
Luwdo wants to merge 5 commits into
Conversation
Author
|
@fabiovincenzi I ended up forking ssh2 and applying this update for my own use. I do believe this test will work though could use some feedback from @mscdex if I need to tweek it. |
Author
|
Okay @mscdex I have adjusted the tests to be more isolated to this specific fix |
Luwdo
changed the title
|
@mscdex any more updates on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I adjusted the test from #781
I am not totally sure if this test is sufficient without also sending data through the channel and asserting that the socket retrieved it vs just testing a successful connection.