Bug-2038705: Remove usage of fetch_api and fetch_api_full_url - #9801
Closed
moijes12 wants to merge 5 commits into
Closed
Bug-2038705: Remove usage of fetch_api and fetch_api_full_url#9801moijes12 wants to merge 5 commits into
moijes12 wants to merge 5 commits into
Conversation
Updated github.py to return generators instead of lists for: - `get_pull_request_commits` - `compare_shas` Also, updated the `compare_shas` to use default parameter for comparsion count.
✅ Deploy Preview for treeherder ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Always set the head_commit.
Use the comparison object for ingest.py where fetch_api and fetch_api_full_urls were once used.
moijes12
changed the title
Replace fetch_api/fetch_api_full_url with PyGithub in get_all_commits, return native dicts so changelog and ingest clients stay unchanged, and read Comparison commit objects by attribute in query_data. Co-authored-by: Alex <moijes12@users.noreply.github.com>
Use lazy repo lookups, 100-item pages, and no client-side request delay. Changelog still consumes commit dicts (ISO dates, filter_by_path via get_commit). git-pushes uses list-commit parents instead of N extra get_commit calls. Document how to time update_changelog and ingest. Co-authored-by: Alex <moijes12@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated github.py to return generators instead of lists for:
get_pull_request_commitscompare_shasAlso, updated the
compare_shasto use default parameter for comparsion count.