Skip to content

feat: Sign In progress indicator and timeout COMPASS-10996 - #8391

Open
esvm wants to merge 15 commits into
mainfrom
COMPASS-10996
Open

feat: Sign In progress indicator and timeout COMPASS-10996#8391
esvm wants to merge 15 commits into
mainfrom
COMPASS-10996

Conversation

@esvm

@esvm esvm commented Aug 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

  1. Implement a progress indicator while user is signing in. Hides the action buttons in the meantime.
  2. Times out the Sign In attempt after 2 minutes
    a. Shows a Toast with a custom message
    b. Re-render the action buttons
  3. Tracks the timeout event
  4. Tracks the user aborted (canceled) event
  5. Adds attempt and previousOutcome to the Atlas Sign In Started event so we can track wether the current attempt is a retry or not
Screen.Recording.2026-08-21.at.13.07.53.mov

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added
  • If this change updates the UI, screenshots/videos are added and a design review is requested
  • If this change could impact the load on the MongoDB cluster, please describe the expected and worst case impact
  • I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@esvm esvm self-assigned this Aug 21, 2026
Copilot AI lite review requested due to automatic review settings August 21, 2026 14:34
@esvm esvm added the feature flagged PRs labeled with this label will not be included in the release notes of the next release label Aug 21, 2026
@esvm esvm changed the title Compass 10996 feat: Sign In progress indicator and timeout COMPASS-10996 Aug 21, 2026
@github-actions github-actions Bot added the feat label Aug 21, 2026
Copilot AI reviewed Aug 21, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the Atlas sign-in flow robustness and observability by adding explicit “in progress” UI state handling, a 2-minute timeout with user feedback, and richer telemetry around retries/outcomes. Overall direction looks solid, but there are a couple of issues to address around event-contract clarity and attempt resource cleanup.

Changes:

  • Adds a sign-in “in progress” state to the assistant tool approval UI (hide actions + show running state).
  • Implements a 2-minute sign-in timeout with toast feedback and telemetry for timeout/cancel events.
  • Extends Atlas Sign In Started telemetry with attempt and previousOutcome to track retries.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/compass-telemetry/src/telemetry-events.ts Extends Atlas sign-in telemetry schema and adds new cancel/timeout event types.
packages/compass-assistant/src/components/atlas-tool-call-message.tsx Updates assistant tool-call UI to reflect sign-in progress and handle timeout results.
packages/compass-assistant/src/components/atlas-tool-call-message.spec.tsx Adds coverage for “sign-in in progress” UI behavior.
packages/atlas-service/src/store/atlas-signin-store-context.tsx Exposes useIsAtlasSignInInProgress and updates signIn() return type to include outcomes.
packages/atlas-service/src/store/atlas-signin-store-context.spec.tsx Adds tests for the new useIsAtlasSignInInProgress selector.
packages/atlas-service/src/store/atlas-signin-reducer.ts Implements timeout/cancel outcomes, retry tracking fields, and new timeout action + telemetry.
packages/atlas-service/src/store/atlas-signin-reducer.spec.ts Adds test coverage for timeout behavior and retry outcome tracking.
packages/atlas-service/src/provider.tsx Re-exports the new useIsAtlasSignInInProgress hook.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread packages/compass-telemetry/src/telemetry-events.ts
Comment thread packages/atlas-service/src/store/atlas-signin-reducer.ts
@esvm
esvm marked this pull request as ready for review August 21, 2026 15:12
@esvm
esvm requested a review from a team as a code owner August 21, 2026 15:12
gribnoysup
gribnoysup reviewed Aug 21, 2026
View reviewed changes
Comment thread packages/compass-assistant/src/components/atlas-tool-call-message.tsx Outdated
gribnoysup
gribnoysup reviewed Aug 21, 2026
View reviewed changes
Comment thread packages/atlas-service/src/store/atlas-signin-reducer.ts Outdated
gribnoysup
gribnoysup reviewed Aug 24, 2026
View reviewed changes
Comment thread packages/atlas-service/src/store/atlas-signin-reducer.ts Outdated
paula-stacho
paula-stacho reviewed Aug 25, 2026
View reviewed changes
Comment thread packages/atlas-service/src/store/atlas-signin-reducer.spec.ts
paula-stacho
paula-stacho reviewed Aug 25, 2026
View reviewed changes
Comment thread packages/atlas-service/src/store/atlas-signin-reducer.ts Outdated
paula-stacho
paula-stacho reviewed Aug 25, 2026
View reviewed changes
Comment thread packages/atlas-service/src/store/atlas-signin-reducer.ts Outdated
gribnoysup
gribnoysup reviewed Aug 25, 2026
View reviewed changes
Comment thread packages/atlas-service/src/store/atlas-signin-reducer.ts Outdated
gribnoysup
gribnoysup reviewed Aug 25, 2026
View reviewed changes
Comment thread packages/atlas-service/src/store/atlas-signin-reducer.ts Outdated
@esvm
esvm requested a review from gribnoysup August 25, 2026 16:52
gribnoysup
gribnoysup reviewed Aug 26, 2026
View reviewed changes

@gribnoysup gribnoysup left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks pretty good already, still a few small things here that I wanted to highlight that I think might be worth addressing

Comment thread packages/atlas-service/src/store/atlas-signin-reducer.ts Outdated
Comment thread packages/atlas-service/src/store/atlas-signin-reducer.ts
Comment thread packages/atlas-service/src/store/atlas-signin-reducer.ts Outdated
Comment thread packages/atlas-service/src/store/atlas-signin-reducer.ts Outdated
@esvm
esvm requested a review from gribnoysup August 26, 2026 08:53
esvm
esvm commented Aug 26, 2026
View reviewed changes
Comment thread packages/compass-assistant/src/components/custom-tool-result.tsx Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@gribnoysup gribnoysup gribnoysup approved these changes
@paula-stacho paula-stacho paula-stacho approved these changes
@dudaschar dudaschar dudaschar approved these changes
@alenakhineika alenakhineika Awaiting requested review from alenakhineika alenakhineika is a code owner automatically assigned from mongodb-js/compass-developers

Assignees

@esvm esvm

Labels

feat feature flagged PRs labeled with this label will not be included in the release notes of the next release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@esvm @gribnoysup @paula-stacho @dudaschar