Skip to content

Commit 0b0dae3

Browse files
authored
[0.82] Restores the original PAT-based authentication for symbol publishing (#15590)
* update publish to use Aad and NOT PAT * reverts SFI changes 15573 * make comments less verbose in ParagrapghComponentview for selectable * Change files
1 parent ebe6ea6 commit 0b0dae3

3 files changed

Lines changed: 11 additions & 8 deletions

File tree

.ado/publish.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,10 @@ variables:
8080
value: false
8181
- name: EnableCodesign
8282
value: false
83+
- name: ArtifactServices.Symbol.AccountName
84+
value: microsoft
85+
- name: ArtifactServices.Symbol.PAT
86+
value: $(pat-symbols-publish-microsoft)
8387
- name: SourceBranchWithFolders
8488
value: $[ replace(variables['Build.SourceBranch'], 'refs/heads/', '') ]
8589

@@ -342,8 +346,6 @@ extends:
342346
# Make symbols available through http://symweb.
343347
- task: PublishSymbols@2
344348
displayName: Publish symbols
345-
env:
346-
ARTIFACTSERVICES_SYMBOL_ACCOUNTNAME: microsoft
347349
inputs:
348350
SearchPattern: vnext/target/**/*.pdb
349351
SymbolServerType: TeamServices
@@ -435,8 +437,6 @@ extends:
435437
- task: PublishSymbols@2
436438
displayName: 'Publish Symbols to Microsoft Symbol Server'
437439
condition: and(succeeded(), in(variables['Build.Reason'], 'IndividualCI', 'BatchedCI'))
438-
env:
439-
ARTIFACTSERVICES_SYMBOL_ACCOUNTNAME: microsoft
440440
inputs:
441441
SymbolsFolder: '$(System.DefaultWorkingDirectory)\NugetRoot'
442442
SearchPattern: '**/*.pdb'
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "prerelease",
3+
"comment": "make comments less verbose in ParagrapghComponentview for selectable",
4+
"packageName": "react-native-windows",
5+
"email": "[email protected]",
6+
"dependentChangeType": "patch"
7+
}

vnext/Microsoft.ReactNative/Fabric/Composition/ParagraphComponentView.h

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -95,16 +95,12 @@ struct ParagraphComponentView : ParagraphComponentViewT<ParagraphComponentView,
9595
std::optional<int32_t> GetClampedTextPosition(facebook::react::Point pt) noexcept;
9696
std::string GetSelectedText() const noexcept;
9797

98-
// Copies currently selected text to the system clipboard
9998
void CopySelectionToClipboard() noexcept;
10099

101-
// Selects the word at the given character position
102100
void SelectWordAtPosition(int32_t charPosition) noexcept;
103101

104-
// Shows a context menu with Copy/Select All options on right-click
105102
void ShowContextMenu() noexcept;
106103

107-
// m_selectionStart <= m_selectionEnd
108104
void SetSelection(int32_t start, int32_t end) noexcept;
109105

110106
winrt::com_ptr<::IDWriteTextLayout> m_textLayout;

0 commit comments

Comments
 (0)