From 578b6fafb1de2448e9ce219e9fcd24887412ad16 Mon Sep 17 00:00:00 2001 From: theqoocjil Date: Mon, 25 May 2026 15:09:05 +0300 Subject: [PATCH 1/2] Repeated the field display settings --- auth/oidc/manageapplication.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/auth/oidc/manageapplication.php b/auth/oidc/manageapplication.php index aac8d2673..5456170ea 100644 --- a/auth/oidc/manageapplication.php +++ b/auth/oidc/manageapplication.php @@ -112,7 +112,9 @@ switch ($fromform->clientauthmethod) { case AUTH_OIDC_AUTH_METHOD_SECRET: $configstosave[] = 'clientsecret'; - $configstosave[] = 'secretexpiryrecipients'; + if ($fromform->idptype != AUTH_OIDC_IDP_TYPE_OTHER && auth_oidc_is_local_365_installed()) { + $configstosave[] = 'secretexpiryrecipients'; + } break; case AUTH_OIDC_AUTH_METHOD_CERTIFICATE: $configstosave[] = 'clientcertsource'; From e82262a8f3bbfd2350072faa38f846398374aff6 Mon Sep 17 00:00:00 2001 From: Lai Wei Date: Thu, 4 Jun 2026 17:38:20 +0100 Subject: [PATCH 2/2] Simplify secretexpiryrecipients guard using isset() instead of explicit conditions --- auth/oidc/manageapplication.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/auth/oidc/manageapplication.php b/auth/oidc/manageapplication.php index 5456170ea..84c2cb7a1 100644 --- a/auth/oidc/manageapplication.php +++ b/auth/oidc/manageapplication.php @@ -112,7 +112,7 @@ switch ($fromform->clientauthmethod) { case AUTH_OIDC_AUTH_METHOD_SECRET: $configstosave[] = 'clientsecret'; - if ($fromform->idptype != AUTH_OIDC_IDP_TYPE_OTHER && auth_oidc_is_local_365_installed()) { + if (isset($fromform->secretexpiryrecipients)) { $configstosave[] = 'secretexpiryrecipients'; } break;