Repository navigation
FIX: reject dataset size limits a scenario would ignore - #3082
Merged
Richard Lundeen (richlundeen) merged 3 commits intoOct 12, 2026
Merged
Richard Lundeen (richlundeen) merged 3 commits into
Richard Lundeen (richlundeen) merged 3 commits into
Conversation
Richard Lundeen (richlundeen)
approved these changes
Oct 11, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 62f37062-d036-4bc1-a880-31728ad4b050
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some scenarios silently ignored max_dataset_size, and the exploitation one ignored every dataset option. The resolver now rejects those with a clear error instead, for both launch and estimate, so the CLI and API behave the same. "default" and dataset names still work where they did before. I also dropped a max dataset size flag from a garak doc example since it never did anything. The new tests fail on main.
Fixes #3081