Skip to content

Commit 2d4135f

Browse files
authored
Move vulnerability checks to weekly maintenance and update Go (#5067)
1 parent b7d1d8f commit 2d4135f

6 files changed

Lines changed: 20 additions & 23 deletions

File tree

‎.github/workflows/govulncheck.yml‎

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,11 @@
11
name: govulncheck
22

3-
# Deterministic vulnerability gate: runs govulncheck (reachability-aware CVE
4-
# scanner) on every push/PR. Fails on any reachable vulnerability EXCEPT the
5-
# explicit ALLOWLIST of known-unfixable ones, so a new vuln breaks the build
6-
# while tracked, no-upstream-fix ones don't. This is the gate the loop's
7-
# `security` role sits on top of — the role audits; this blocks known CVEs.
8-
#
9-
# Make this a required status check on the default branch to enforce it.
10-
3+
# Dependency and toolchain maintenance runs separately from PR validation.
4+
# Findings still fail this workflow so they remain visible to maintainers.
115
on:
12-
push:
13-
branches: ["**"]
14-
pull_request:
15-
branches: ["**"]
6+
schedule:
7+
- cron: '23 8 * * 1' # Monday, 08:23 UTC
8+
workflow_dispatch:
169

1710
permissions:
1811
contents: read
@@ -25,10 +18,10 @@ jobs:
2518
- uses: actions/checkout@v4
2619
- uses: actions/setup-go@v5
2720
with:
28-
go-version: "1.26.10"
21+
go-version-file: go.mod
2922
check-latest: true
3023
- name: Install govulncheck
31-
run: go install golang.org/x/vuln/cmd/govulncheck@latest
24+
run: go install golang.org/x/vuln/cmd/govulncheck@v1.10.0
3225
- name: Scan
3326
env:
3427
# Reachable vulnerabilities with NO upstream fix, accepted for now and

‎.github/workflows/lint.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121
- name: Set up Go
2222
uses: actions/setup-go@v5
2323
with:
24-
go-version: "1.26.10"
24+
go-version-file: go.mod
2525
check-latest: true
2626
cache: true
2727
- name: golangci-lint

‎.github/workflows/release.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ jobs:
2323
name: Set up Go
2424
uses: actions/setup-go@v5
2525
with:
26-
go-version: stable
26+
go-version-file: go.mod
2727
-
2828
name: Set up Docker Buildx
2929
uses: docker/setup-buildx-action@v3

‎.github/workflows/tests.yaml‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@ jobs:
1717
steps:
1818
- uses: actions/checkout@v3
1919
- name: Set up Go
20-
uses: actions/setup-go@v3
20+
uses: actions/setup-go@v5
2121
with:
22-
go-version: "1.26.10"
22+
go-version-file: go.mod
2323
check-latest: true
2424
cache: true
2525
- name: Get dependencies
@@ -54,9 +54,9 @@ jobs:
5454
steps:
5555
- uses: actions/checkout@v3
5656
- name: Set up Go
57-
uses: actions/setup-go@v3
57+
uses: actions/setup-go@v5
5858
with:
59-
go-version: "1.26.10"
59+
go-version-file: go.mod
6060
check-latest: true
6161
cache: true
6262
- name: Get dependencies

‎go.mod‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ module go-micro.dev/v6
22

33
go 1.26.0
44

5-
toolchain go1.26.10
5+
toolchain go1.26.11
66

77
require (
88
charm.land/glamour/v2 v2.0.1

‎internal/docs/CONTINUOUS_IMPROVEMENT.md‎

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ Actions instead of subagents. Each role is a workflow:
2121
|------|------------------------|--------------|
2222
| **Planner** | `loop-planner.yml` — *Loop: Planner* | Tracks live state, prioritizes the roadmap + an internal scan, and maintains the ranked queue in [`.github/loop/PRIORITIES.md`](../../.github/loop/PRIORITIES.md). Decides *what*. |
2323
| **Generator** | `loop-builder.yml` — *Loop: Builder (Generator)* | Builds the top open queue item as a single-concern PR (via Codex) and self-merges on green CI. Does the work. |
24-
| **Evaluator** | `harness.yml` — *Harness (E2E)*, plus the CI gate (`tests.yaml`, `lint.yaml`, `govulncheck.yml`) | Grades every change: the mock harness + unit/lint + reachable-CVE scan on each push/PR, and real-model conformance hourly. A *separate* grader — never the generator judging itself. |
25-
| **Evaluator → feedback** | `loop-triage.yml` — *Loop: Triage (Evaluator feedback)* | When a gate workflow (Lint, Run Tests, govulncheck, or the harness) fails on a non-PR run, root-causes, dedupes, and files scoped fix issues back into the planner's queue. The hill-climbing feedback path. |
24+
| **Evaluator** | `harness.yml` — *Harness (E2E)*, plus the CI gate (`tests.yaml`, `lint.yaml`) | Grades every change: the mock harness + unit/lint on each push/PR, and real-model conformance hourly. A *separate* grader — never the generator judging itself. |
25+
| **Evaluator → feedback** | `loop-triage.yml` — *Loop: Triage (Evaluator feedback)* | When a gate workflow (Lint, Run Tests, or the harness) fails on a non-PR run, root-causes, dedupes, and files scoped fix issues back into the planner's queue. The hill-climbing feedback path. |
2626
| **Coherence** | `loop-coherence.yml` — *Loop: Coherence* | Keeps README/website/docs/blog aligned with the North Star, keeps `CHANGELOG.md` living (reconciling `[Unreleased]` against merged PRs and rolling it into version headings as tags cut), and drafts the changelog blog post. |
2727
| **Security** | `loop-security.yml` — *Loop: Security* | Weekly vulnerability audit of the attack surface (MCP/A2A gateways, x402, auth, provider URLs, agent tool loop, deps via `govulncheck`). Files `security` issues; **never auto-merges** fixes and **never publishes exploit detail** in public issues (responsible disclosure); risky fixes are `needs-human`. |
2828
| **Release** | `loop-release.yml` — *Loop: Release (daily patch)* | Cuts a daily patch tag when master has new commits, so the *installable* framework tracks the loop's improvements (triggers `release.yml`/goreleaser). Minor/major bumps stay with the human. |
@@ -214,3 +214,7 @@ middle, short of a decision that's genuinely the human's.
214214
- Durable: disable/delete the workflow.
215215
- Or just tell Claude Code to pause or change focus — direction always wins over
216216
the loop.
217+
218+
## Vulnerability maintenance
219+
220+
`govulncheck.yml` runs weekly and on manual dispatch, separately from PR validation. It uses the toolchain in `go.mod` and a pinned scanner version. Findings still fail the maintenance run. Do not require this scheduled check in branch protection.

0 commit comments

Comments
 (0)