Skip to content

README.md

Latest commit

 

History

History
292 lines (270 loc) · 27.4 KB

README.md

File metadata and controls

292 lines (270 loc) · 27.4 KB
Raw

LUFFY Development Repository

🚧 Development Branch - This is the main development repository for LUFFY (Learning to Reason Under Off‑Policy Guidance)

About LUFFY

LUFFY is a reinforcement learning framework that bridges the gap between zero-RL and imitation learning by incorporating off-policy reasoning traces into the training process. This repository contains the core implementation and development work.

🔧 Development Status

This repository is under active development. Many features are currently being implemented or need refactoring.

🚀 Quick Start

⚠️ Note: This development version has incomplete implementations. Many features are marked as TODO and need to be completed before production use.

# Clone the repository
git clone <repository-url>
cd LUFFY

# Install dependencies
pip install -r luffy/requirements.txt

# Note: Some functionality is incomplete - check TODO list below for details

📁 Repository Structure

LUFFY/
├── luffy/                 # Core framework
│   ├── deepscaler/        # Scaling utilities (⚠️ API integration needed)
│   ├── verl/              # RL training components (⚠️ Some features incomplete)
│   └── ...
├── data/                  # Training data and scripts
├── eval_scripts/          # Evaluation utilities
├── exp_scripts/           # Experiment scripts
└── README.md              # This file

⚠️ Development Notes

  • This is a development version with incomplete implementations
  • Many functions contain TODO markers indicating pending work
  • API integrations (OpenAI, Gemini) are currently placeholder implementations
  • FSDP and distributed training features need completion

🔴 High Priority TODOs

  • API Integration: OpenAI and Gemini API implementations need completion
  • Reward System: Parallel processing and validation for reward computation
  • FSDP Training: Model loading and distributed training setup
  • Data Processing: Batch dimension operations and tensor reshaping

📝 Complete TODO List

  • luffy/deepscaler/utils.py:45 - Implement OpenAI API client initialization
  • luffy/deepscaler/utils.py:46 - Add proper authentication handling
  • luffy/deepscaler/utils.py:47 - Implement exponential backoff retry logic for rate limits
  • luffy/deepscaler/utils.py:48 - Add comprehensive error handling for different API errors
  • luffy/deepscaler/utils.py:49 - Implement response parsing and validation
  • luffy/deepscaler/utils.py:50 - Add logging for API calls and errors
  • luffy/deepscaler/utils.py:51 - Support batch processing for multiple prompts
  • luffy/deepscaler/utils.py:52 - Add timeout configuration for API calls
  • luffy/deepscaler/utils.py:88 - Implement Vertex AI initialization and authentication
  • luffy/deepscaler/utils.py:89 - Configure safety settings for content generation
  • luffy/deepscaler/utils.py:90 - Set up GenerativeModel with proper system instructions
  • luffy/deepscaler/utils.py:91 - Implement retry logic with exponential backoff
  • luffy/deepscaler/utils.py:92 - Add comprehensive error handling for API access issues
  • luffy/deepscaler/utils.py:93 - Handle rate limiting and quota management
  • luffy/deepscaler/utils.py:94 - Implement response validation and text extraction
  • luffy/deepscaler/utils.py:95 - Add support for different generation configurations
  • luffy/test.py:1590 - add smaller page sizes when Dao-AILab/flash-attention#824 is merged
  • luffy/verl/examples/split_placement/split_monkey_patch.py:141 - make a canonical logger that supports various backend
  • luffy/verl/tests/e2e/check_results.py:21 - this function needs error handling
  • luffy/verl/tests/model/test_transformer.py:22 - (sgm): add more models for test
  • luffy/verl/tests/model/test_transformer.py:50 - (sgm): we can construct the position_ids_rmpad here
  • luffy/verl/tests/model/test_transformer.py:111 - (sgm): we can construct the position_ids_rmpad here
  • luffy/verl/tests/model/test_transformers_ulysses.py:34 - (sgm): add more models for test
  • luffy/verl/tests/model/test_transformers_ulysses.py:81 - (sgm): we can construct the position_ids_rmpad here
  • luffy/verl/tests/model/test_transformers_ulysses.py:159 - (sgm): we can construct the position_ids_rmpad here
  • luffy/verl/tests/ray/test_high_level_scheduling_api.py:25 - pass *args and **kwargs is bug prone and not very convincing
  • luffy/verl/tests/ray/test_worker_group_basics.py:43 - pass *args and **kwargs is bug prone and not very convincing
  • luffy/verl/verl/mix_src/mix_fsdp_worker.py:54 - (sgm): support FSDP hybrid shard for larger model
  • luffy/verl/verl/mix_src/mix_fsdp_worker.py:83 - it seems that manual offload is slowly than FSDP offload
  • luffy/verl/verl/mix_src/mix_fsdp_worker.py:123 - (zhangchi.usc1992): 1. support create from random initialized model. 2. Support init with FSDP directly
  • luffy/verl/verl/mix_src/mix_fsdp_worker.py:199 - (zhangchi.usc1992, shengguangming) fix me. Current, auto_wrap_policy causes HFRollout to hang in Gemma
  • luffy/verl/verl/mix_src/mix_fsdp_worker.py:207 - add transformer policy
  • luffy/verl/verl/mix_src/mix_fsdp_worker.py:226 - add more optimizer args into config
  • luffy/verl/verl/mix_src/mix_fsdp_worker.py:252 - (sgm): support FSDP hybrid shard for larger model
  • luffy/verl/verl/mix_src/mix_fsdp_worker.py:263 - a sharding manager that do nothing?
  • luffy/verl/verl/mix_src/mix_fsdp_worker.py:391 - here, we should return all metrics
  • luffy/verl/verl/mix_src/mix_fsdp_worker.py:517 - support DCP and save sharded checkpoints
  • luffy/verl/verl/mix_src/mix_trainer.py:90 - add other ways to estimate advantages
  • luffy/verl/verl/mix_src/mix_trainer.py:168 - support each role have individual ray_worker_group_cls,
  • luffy/verl/verl/mix_src/mix_trainer.py:293 - we have to make sure the batch size is divisible by the dp size
  • luffy/verl/verl/mix_src/mix_trainer.py:599 - make a canonical logger that supports various backend
  • luffy/verl/verl/mix_src/mix_trainer.py:637 - add response length
  • luffy/verl/verl/mix_src/mix_trainer_acc_rebatch.py:63 - we have to make sure the batch size is divisible by the dp size
  • luffy/verl/verl/mix_src/mix_trainer_acc_rebatch.py:437 - make a canonical logger that supports various backend
  • luffy/verl/verl/mix_src/mix_trainer_acc_rebatch.py:592 - check path
  • luffy/verl/verl/mix_src/mix_trainer_acc_rebatch.py:628 - from remote not implemented yet
  • luffy/verl/verl/models/llama/megatron/layers/parallel_attention.py:380 - llama does not have dropout in the config??
  • luffy/verl/verl/models/llama/megatron/layers/parallel_decoder.py:78 - add sequence parallel operator reduce_scatter here
  • luffy/verl/verl/models/llama/megatron/layers/parallel_decoder.py:86 - add sequence parallel operator all_gather here
  • luffy/verl/verl/models/llama/megatron/layers/parallel_decoder.py:90 - add sequence parallel operator reduce_scatter here
  • luffy/verl/verl/models/llama/megatron/modeling_llama_megatron.py:330 - for better performance, the sp padding should be removed at each layer. Not sure the performance gap
  • luffy/verl/verl/models/llama/megatron/modeling_llama_megatron.py:588 - for better performance, the sp padding should be removed at each layer. Not sure the performance gap
  • luffy/verl/verl/models/registry.py:21 - (sgm): HF may supported more than listed here, we should add more after testing
  • luffy/verl/verl/models/transformers/llama.py:88 - These transpose are quite inefficient but Flash Attention requires the layout [batch_size, sequence_length, num_heads, head_dim]. We would need to refactor the KV cache
  • luffy/verl/verl/protocol.py:114 - Implement batch dimension folding for efficient processing
  • luffy/verl/verl/protocol.py:115 - Add validation for batch size compatibility
  • luffy/verl/verl/protocol.py:116 - Handle edge cases where batch_size is not divisible by new_batch_size
  • luffy/verl/verl/protocol.py:117 - Optimize memory usage during tensor reshaping
  • luffy/verl/verl/protocol.py:118 - Add support for different tensor types and shapes
  • luffy/verl/verl/protocol.py:131 - Implement batch dimension unfolding functionality
  • luffy/verl/verl/protocol.py:132 - Add support for variable batch dimensions
  • luffy/verl/verl/protocol.py:133 - Optimize tensor view operations for performance
  • luffy/verl/verl/protocol.py:134 - Handle non-tensor batch data reshaping properly
  • luffy/verl/verl/protocol.py:135 - Add error handling for invalid batch dimensions
  • luffy/verl/verl/protocol.py:156 - (zhangchi.usc1992) add consistency check
  • luffy/verl/verl/protocol.py:252 - we can actually lift this restriction if needed
  • luffy/verl/verl/protocol.py:338 - (zhangchi.usc1992) whether to copy
  • luffy/verl/verl/single_controller/ray/base.py:439 - create a class with customizable name
  • luffy/verl/verl/third_party/vllm/vllm_v_0_3_1/arg_utils.py:64 - (shengguangming): delete the unused args
  • luffy/verl/verl/third_party/vllm/vllm_v_0_3_1/arg_utils.py:147 - (woosuk): Support fine-grained seeds (e.g., seed per request).
  • luffy/verl/verl/third_party/vllm/vllm_v_0_3_1/llm.py:237 - (shengguangming): maybe we can hack the autoregressive logics without only apply post process for better performance
  • luffy/verl/verl/third_party/vllm/vllm_v_0_3_1/llm.py:241 - (sgm): we can optimize it by making the dataloader yield List[int] without padding.
  • luffy/verl/verl/third_party/vllm/vllm_v_0_3_1/llm.py:257 - (shengguangming): can be optimzied by rewrite the Sampler._get_logprobs() logits
  • luffy/verl/verl/third_party/vllm/vllm_v_0_3_1/llm_engine_sp.py:99 - (woosuk): Print more configs in debug mode.
  • luffy/verl/verl/third_party/vllm/vllm_v_0_3_1/llm_engine_sp.py:101 - currently is hfconfig
  • luffy/verl/verl/third_party/vllm/vllm_v_0_3_1/llm_engine_sp.py:112 - (shengguangming): maybe we can choose init here or from arguments
  • luffy/verl/verl/third_party/vllm/vllm_v_0_3_1/llm_engine_sp.py:145 - check get_lora_tokenizer func
  • luffy/verl/verl/third_party/vllm/vllm_v_0_3_1/llm_engine_sp.py:586 - check this input
  • luffy/verl/verl/third_party/vllm/vllm_v_0_3_1/llm_engine_sp.py:661 - we may not need to decode
  • luffy/verl/verl/third_party/vllm/vllm_v_0_3_1/model_loader.py:67 - (shengguangming): latest commit in vllm fix awq for this function and add load_weights
  • luffy/verl/verl/third_party/vllm/vllm_v_0_3_1/model_loader.py:96 - (pad to be divided by 4)
  • luffy/verl/verl/third_party/vllm/vllm_v_0_3_1/model_loader.py:224 - (zhuohan): Change the get_logits part to a separate stage.
  • luffy/verl/verl/third_party/vllm/vllm_v_0_3_1/tokenizer.py:56 - (sgm): the lora tokenizer is also passed, but may be different
  • luffy/verl/verl/third_party/vllm/vllm_v_0_3_1/weight_loaders.py:62 - check megatron
  • luffy/verl/verl/third_party/vllm/vllm_v_0_3_1/weight_loaders.py:84 - need to implement a general way to deal with prefix
  • luffy/verl/verl/third_party/vllm/vllm_v_0_3_1/worker.py:109 - do not use cupy
  • luffy/verl/verl/third_party/vllm/vllm_v_0_3_1/worker.py:209 - (woosuk): Profile swapping overhead and optimize if needed.
  • luffy/verl/verl/third_party/vllm/vllm_v_0_3_1/worker.py:291 - (shengguangming): maybe we should also flag the megatron is initialized
  • luffy/verl/verl/third_party/vllm/vllm_v_0_4_2/arg_utils.py:109 - (shengguangming): delete the unused args
  • luffy/verl/verl/third_party/vllm/vllm_v_0_4_2/arg_utils.py:192 - (woosuk): Support fine-grained seeds (e.g., seed per request).
  • luffy/verl/verl/third_party/vllm/vllm_v_0_4_2/arg_utils.py:257 - spec config
  • luffy/verl/verl/third_party/vllm/vllm_v_0_4_2/config.py:136 - for multimodal model
  • luffy/verl/verl/third_party/vllm/vllm_v_0_4_2/llm.py:268 - (shengguangming): maybe we can hack the autoregressive logics without only apply post process for better performance
  • luffy/verl/verl/third_party/vllm/vllm_v_0_4_2/llm.py:272 - (sgm): we can optimize it by making the dataloader yield List[int] without padding.
  • luffy/verl/verl/third_party/vllm/vllm_v_0_4_2/llm.py:288 - (shengguangming): can be optimzied by rewrite the Sampler._get_logprobs() logits
  • luffy/verl/verl/third_party/vllm/vllm_v_0_4_2/llm_engine_sp.py:128 - (woosuk): Print more configs in debug mode.
  • luffy/verl/verl/third_party/vllm/vllm_v_0_4_2/llm_engine_sp.py:130 - currently is hfconfig
  • luffy/verl/verl/third_party/vllm/vllm_v_0_4_2/llm_engine_sp.py:143 - (shengguangming): maybe we can choose init here or from arguments
  • luffy/verl/verl/third_party/vllm/vllm_v_0_4_2/llm_engine_sp.py:145 - check tokenizer class
  • luffy/verl/verl/third_party/vllm/vllm_v_0_4_2/llm_engine_sp.py:153 - don't know what's the usage
  • luffy/verl/verl/third_party/vllm/vllm_v_0_4_2/llm_engine_sp.py:228 - (sgm): add for verl but we may not tokenizer in Rollout
  • luffy/verl/verl/third_party/vllm/vllm_v_0_4_2/llm_engine_sp.py:237 - check whether we should rebuild the CUDAGraph every iter when offload/load KVCache
  • luffy/verl/verl/third_party/vllm/vllm_v_0_4_2/megatron_weight_loaders.py:67 - check megatron
  • luffy/verl/verl/third_party/vllm/vllm_v_0_4_2/megatron_weight_loaders.py:254 - need to implement a general way to deal with prefix
  • luffy/verl/verl/third_party/vllm/vllm_v_0_4_2/megatron_weight_loaders.py:272 - (shengguangming): latest commit in vllm fix awq for this function and add load_weights
  • luffy/verl/verl/third_party/vllm/vllm_v_0_4_2/model_loader.py:141 - (sgm): This is a hack, we need to register the load_weight() func for each model in vllm
  • luffy/verl/verl/third_party/vllm/vllm_v_0_4_2/model_loader.py:226 - (sgm): This is a hack, we need to register the load_weight() func for each model in vllm
  • luffy/verl/verl/third_party/vllm/vllm_v_0_4_2/model_runner.py:274 - (sgm): perform sampling on rank 0
  • luffy/verl/verl/third_party/vllm/vllm_v_0_4_2/parallel_state.py:236 - this will hang
  • luffy/verl/verl/third_party/vllm/vllm_v_0_4_2/parallel_state.py:245 - will hang when used with device mesh
  • luffy/verl/verl/third_party/vllm/vllm_v_0_4_2/parallel_state.py:247 - init using device mesh
  • luffy/verl/verl/third_party/vllm/vllm_v_0_4_2/spmd_gpu_executor.py:62 - (sgm): verl not support speculative decode now
  • luffy/verl/verl/third_party/vllm/vllm_v_0_4_2/spmd_gpu_executor.py:208 - (sgm): not implemented async executor yet
  • luffy/verl/verl/third_party/vllm/vllm_v_0_4_2/tokenizer.py:61 - (sgm): the lora tokenizer is also passed, but may be different
  • luffy/verl/verl/third_party/vllm/vllm_v_0_4_2/worker.py:30 - (sgm): check why vllm has similar file in vllm.model_executor.parallel_utils.parallel_state
  • luffy/verl/verl/third_party/vllm/vllm_v_0_4_2/worker.py:270 - (sgm): check whether need this
  • luffy/verl/verl/third_party/vllm/vllm_v_0_5_4/arg_utils.py:53 - (sgm): check this
  • luffy/verl/verl/third_party/vllm/vllm_v_0_5_4/arg_utils.py:54 - (sgm): check this
  • luffy/verl/verl/third_party/vllm/vllm_v_0_5_4/arg_utils.py:143 - (shengguangming): delete the unused args
  • luffy/verl/verl/third_party/vllm/vllm_v_0_5_4/arg_utils.py:226 - (woosuk): Support fine-grained seeds (e.g., seed per request).
  • luffy/verl/verl/third_party/vllm/vllm_v_0_5_4/arg_utils.py:366 - spec config
  • luffy/verl/verl/third_party/vllm/vllm_v_0_5_4/config.py:191 - check whether this is necessary
  • luffy/verl/verl/third_party/vllm/vllm_v_0_5_4/llm.py:148 - check usagecontext
  • luffy/verl/verl/third_party/vllm/vllm_v_0_5_4/llm.py:205 - (sgm): we can optimize it by making the dataloader yield List[int] without padding.
  • luffy/verl/verl/third_party/vllm/vllm_v_0_5_4/llm.py:221 - (shengguangming): can be optimzied by rewrite the Sampler._get_logprobs() logits
  • luffy/verl/verl/third_party/vllm/vllm_v_0_5_4/llm_engine_sp.py:143 - (woosuk): Print more configs in debug mode.
  • luffy/verl/verl/third_party/vllm/vllm_v_0_5_4/llm_engine_sp.py:160 - (shengguangming): maybe we can choose init here or from arguments
  • luffy/verl/verl/third_party/vllm/vllm_v_0_5_4/llm_engine_sp.py:262 - (sgm): add for verl but we may not tokenizer in Rollout
  • luffy/verl/verl/third_party/vllm/vllm_v_0_5_4/llm_engine_sp.py:271 - check whether we should rebuild the CUDAGraph every iter when offload/load KVCache
  • luffy/verl/verl/third_party/vllm/vllm_v_0_5_4/megatron_weight_loaders.py:67 - check megatron
  • luffy/verl/verl/third_party/vllm/vllm_v_0_5_4/megatron_weight_loaders.py:254 - need to implement a general way to deal with prefix
  • luffy/verl/verl/third_party/vllm/vllm_v_0_5_4/megatron_weight_loaders.py:272 - (shengguangming): latest commit in vllm fix awq for this function and add load_weights
  • luffy/verl/verl/third_party/vllm/vllm_v_0_5_4/model_loader.py:152 - (sgm): This is a hack, we need to register the load_weight() func for each model in vllm
  • luffy/verl/verl/third_party/vllm/vllm_v_0_5_4/model_loader.py:239 - (sgm): This is a hack, we need to register the load_weight() func for each model in vllm
  • luffy/verl/verl/third_party/vllm/vllm_v_0_5_4/parallel_state.py:94 - (sgm): deviate from the v0.5.4, not pp now
  • luffy/verl/verl/third_party/vllm/vllm_v_0_5_4/parallel_state.py:138 - check why True is not work in Ray trainer
  • luffy/verl/verl/third_party/vllm/vllm_v_0_5_4/parallel_state.py:165 - check why True is not work in Ray trainer
  • luffy/verl/verl/third_party/vllm/vllm_v_0_5_4/parallel_state.py:177 - init using device mesh (not support hybrid engine now)
  • luffy/verl/verl/third_party/vllm/vllm_v_0_5_4/parallel_state.py:249 - check why True is not work in Ray trainer
  • luffy/verl/verl/third_party/vllm/vllm_v_0_5_4/parallel_state.py:253 - init using device mesh (not support hybrid engine now)
  • luffy/verl/verl/third_party/vllm/vllm_v_0_5_4/spmd_gpu_executor.py:65 - (sgm): verl not support speculative decode now
  • luffy/verl/verl/third_party/vllm/vllm_v_0_5_4/spmd_gpu_executor.py:243 - (sgm): not implemented async executor yet
  • luffy/verl/verl/third_party/vllm/vllm_v_0_5_4/tokenizer.py:61 - (sgm): the lora tokenizer is also passed, but may be different
  • luffy/verl/verl/third_party/vllm/vllm_v_0_5_4/worker.py:29 - (sgm): check why vllm has similar file in vllm.model_executor.parallel_utils.parallel_state
  • luffy/verl/verl/third_party/vllm/vllm_v_0_5_4/worker.py:84 - we don't need driver
  • luffy/verl/verl/third_party/vllm/vllm_v_0_5_4/worker.py:103 - (sgm): set correct model runner class
  • luffy/verl/verl/third_party/vllm/vllm_v_0_5_4/worker.py:301 - (sgm): check whether need this
  • luffy/verl/verl/trainer/fsdp_sft_trainer.py:77 - add checkpoint manager
  • luffy/verl/verl/trainer/fsdp_sft_trainer.py:140 - (zhangchi.usc1992):
  • luffy/verl/verl/trainer/fsdp_sft_trainer.py:159 - Implement model loading with proper initialization context
  • luffy/verl/verl/trainer/fsdp_sft_trainer.py:160 - Add support for different model types and configurations
  • luffy/verl/verl/trainer/fsdp_sft_trainer.py:161 - Implement memory-efficient model loading for large models
  • luffy/verl/verl/trainer/fsdp_sft_trainer.py:162 - Add model validation and compatibility checks
  • luffy/verl/verl/trainer/fsdp_sft_trainer.py:165 - Complete model loading implementation
  • luffy/verl/verl/trainer/fsdp_sft_trainer.py:166 - Add support for custom model architectures
  • luffy/verl/verl/trainer/fsdp_sft_trainer.py:167 - Implement proper dtype and attention configuration
  • luffy/verl/verl/trainer/fsdp_sft_trainer.py:170 - Implement gradient checkpointing configuration
  • luffy/verl/verl/trainer/fsdp_sft_trainer.py:171 - Add memory usage optimization strategies
  • luffy/verl/verl/trainer/fsdp_sft_trainer.py:172 - Configure mixed precision training settings
  • luffy/verl/verl/trainer/fsdp_sft_trainer.py:173 - Implement FSDP sharding and wrapping policies
  • luffy/verl/verl/trainer/fsdp_sft_trainer.py:174 - Add CPU offloading configuration for memory optimization
  • luffy/verl/verl/trainer/fsdp_sft_trainer.py:175 - Set up distributed training parameters properly
  • luffy/verl/verl/trainer/fsdp_sft_trainer.py:178 - Initialize FSDP wrapped model
  • luffy/verl/verl/trainer/fsdp_sft_trainer.py:301 - add a unified tracking
  • luffy/verl/verl/trainer/fsdp_sft_trainer.py:318 - (zhangchi.usc1992) add back checkpoint manager. Currently, it blocks when uploading to hdfs. So very slow.
  • luffy/verl/verl/trainer/main_ppo.py:50 - Implement reward computation for different data sources
  • luffy/verl/verl/trainer/main_ppo.py:53 - Add support for parallel processing of reward computation
  • luffy/verl/verl/trainer/main_ppo.py:54 - Implement proper sequence decoding and validation
  • luffy/verl/verl/trainer/main_ppo.py:55 - Add thread-safe logging and debugging functionality
  • luffy/verl/verl/trainer/main_ppo.py:56 - Optimize memory usage for large batch processing
  • luffy/verl/verl/trainer/main_ppo.py:62 - Extract and validate prompt and response sequences
  • luffy/verl/verl/trainer/main_ppo.py:63 - Decode sequences to text format
  • luffy/verl/verl/trainer/main_ppo.py:64 - Apply appropriate reward function based on data source
  • luffy/verl/verl/trainer/main_ppo.py:65 - Handle edge cases and error conditions
  • luffy/verl/verl/trainer/main_ppo.py:70 - Implement batch-wise reward computation
  • luffy/verl/verl/trainer/main_ppo.py:71 - Add proper error handling and validation
  • luffy/verl/verl/trainer/ppo/ray_trainer.py:129 - add other ways to estimate advantages
  • luffy/verl/verl/trainer/ppo/ray_trainer.py:207 - add response length
  • luffy/verl/verl/trainer/ppo/ray_trainer.py:330 - support each role have individual ray_worker_group_cls,
  • luffy/verl/verl/trainer/ppo/ray_trainer.py:379 - we have to make sure the batch size is divisible by the dp size
  • luffy/verl/verl/trainer/ppo/ray_trainer.py:632 - check path
  • luffy/verl/verl/trainer/ppo/ray_trainer.py:667 - from remote not implemented yet
  • luffy/verl/verl/trainer/ppo/ray_trainer.py:880 - make a canonical logger that supports various backend
  • luffy/verl/verl/utils/checkpoint/fsdp_checkpoint_manager.py:101 - shall we remove previous ckpt every save?
  • luffy/verl/verl/utils/checkpoint/fsdp_checkpoint_manager.py:135 - address optimizer is None
  • luffy/verl/verl/utils/hdfs_io.py:67 - (haibin.lin):
  • luffy/verl/verl/utils/hdfs_io.py:102 - (haibin.lin):
  • luffy/verl/verl/utils/megatron_utils.py:202 - (sgm): check how to disable megatron timers
  • luffy/verl/verl/utils/model.py:164 - we can make this faster
  • luffy/verl/verl/utils/model.py:272 - to find a better way to load mistral7b-rm lm_head
  • luffy/verl/verl/utils/torch_functional.py:362 - add them back
  • luffy/verl/verl/workers/actor/megatron_actor.py:158 - (zhangchi.usc1992): actually, this function should only return log_prob and this logic should be handled by user outside
  • luffy/verl/verl/workers/actor/megatron_actor.py:225 - actually, we just need to control the sampling order.
  • luffy/verl/verl/workers/actor/megatron_actor.py:301 - we may use the new schedule instead
  • luffy/verl/verl/workers/critic/megatron_critic.py:176 - we may use the new schedule instead
  • luffy/verl/verl/workers/fsdp_workers.py:88 - (sgm): support FSDP hybrid shard for larger model
  • luffy/verl/verl/workers/fsdp_workers.py:117 - it seems that manual offload is slowly than FSDP offload
  • luffy/verl/verl/workers/fsdp_workers.py:157 - (zhangchi.usc1992): 1. support create from random initialized model. 2. Support init with FSDP directly
  • luffy/verl/verl/workers/fsdp_workers.py:225 - (zhangchi.usc1992, shengguangming) fix me. Current, auto_wrap_policy causes HFRollout to hang in Gemma
  • luffy/verl/verl/workers/fsdp_workers.py:233 - add transformer policy
  • luffy/verl/verl/workers/fsdp_workers.py:252 - add more optimizer args into config
  • luffy/verl/verl/workers/fsdp_workers.py:278 - (sgm): support FSDP hybrid shard for larger model
  • luffy/verl/verl/workers/fsdp_workers.py:289 - a sharding manager that do nothing?
  • luffy/verl/verl/workers/fsdp_workers.py:416 - here, we should return all metrics
  • luffy/verl/verl/workers/fsdp_workers.py:811 - (sgm): we may need to extract it to dp_reward_model.py
  • luffy/verl/verl/workers/megatron_workers.py:106 - (sgm): Currently, we only support reference model param offload
  • luffy/verl/verl/workers/megatron_workers.py:204 - add more optimizer args into config
  • luffy/verl/verl/workers/megatron_workers.py:338 - here, we should return all metrics
  • luffy/verl/verl/workers/megatron_workers.py:444 - (sgm): support critic model offload
  • luffy/verl/verl/workers/megatron_workers.py:478 - support vpp here
  • luffy/verl/verl/workers/megatron_workers.py:507 - add more optimizer args into config
  • luffy/verl/verl/workers/megatron_workers.py:667 - add more optimizer args into config
  • luffy/verl/verl/workers/megatron_workers.py:720 - reward model use itself tokenizer instead of sft tokenizer
  • luffy/verl/verl/workers/reward_model/megatron/reward_model.py:145 - (sgm): check why is bfloat16
  • luffy/verl/verl/workers/reward_model/megatron/reward_model.py:192 - actually, we just need to control the sampling order.
  • luffy/verl/verl/workers/reward_model/megatron/reward_model.py:233 - we may use the new schedule instead
  • luffy/verl/verl/workers/rollout/hf_rollout.py:98 - filter out the seq with no answers like ds-chat
  • luffy/verl/verl/workers/sharding_manager/fsdp_ulysses.py:49 - check how to set seed for each model
  • luffy/verl/verl/workers/sharding_manager/fsdp_ulysses.py:56 - check how to set seed for each model
  • luffy/verl/verl/workers/sharding_manager/fsdp_vllm.py:82 - offload FSDP model weights
  • luffy/verl/verl/workers/sharding_manager/fsdp_vllm.py:113 - Current impl doesn't consider FSDP with torch micro-dp
  • luffy/verl/verl/workers/sharding_manager/fsdp_vllm.py:122 - Current impl doesn't consider FSDP with torch micro-dp
  • luffy/verl/verl/workers/sharding_manager/fsdp_vllm.py:130 - shall we build a micro_dp group for vllm when integrating with vLLM?
  • luffy/verl/verl/workers/sharding_manager/megatron_vllm.py:76 - after binding to the memory buffer, we can load the checkpoint here
  • luffy/verl/verl/workers/sharding_manager/megatron_vllm.py:253 - (sgm): this may not be true for FSDP -> vLLM
  • luffy/verl/verl/workers/sharding_manager/megatron_vllm.py:323 - (zhangchi.usc1992) We can consider copy non-tp weight to another infer buffer.

🤝 Contributing

  1. Pick a TODO item from the list above
  2. Implement the functionality
  3. Test your implementation
  4. Update this README when TODOs are completed