fix: removes troubling conversion and cleanup code

Author: gjulivan

packages/pluggableWidgets/rich-text-web/src/components/EditorWrapper.tsx

@@ -9,7 +9,6 @@ import { CSSProperties, ReactElement, useCallback, useContext, useEffect, useRef
 import { RichTextContainerProps } from "typings/RichTextProps";
 import { EditorContext, EditorProvider } from "../store/EditorProvider";
 import { useActionEvents } from "../store/useActionEvents";
-import { updateLegacyQuillFormats } from "../utils/helpers";
 import MendixTheme from "../utils/themes/mxTheme";
 import { MxQuillModulesOptions } from "../utils/MxQuill";
 import { createPreset } from "./CustomToolbars/presets";
@@ -108,10 +107,6 @@ function EditorWrapperInner(props: EditorWrapperProps): ReactElement {
 
     useEffect(() => {
         if (quillRef.current) {
-            const isTransformed = updateLegacyQuillFormats(quillRef.current);
-            if (isTransformed) {
-                setAttributeValueDebounce(quillRef.current.getSemanticHTML());
-            }
             if (!isFirstLoad.current) {
                 executeAction(onLoad);
                 isFirstLoad.current = true;

packages/pluggableWidgets/rich-text-web/src/utils/MxQuill.ts

@@ -64,6 +64,9 @@ class MxEditor extends Editor {
      * https://github.com/slab/quill/blob/main/packages/quill/src/core/editor.ts
      */
     getHTML(index: number, length: number): string {
+        if (this.isBlank()) {
+            return "";
+        }
         const [line, lineOffset] = this.scroll.line(index);
         if (line) {
             const lineLength = line.length();

packages/pluggableWidgets/rich-text-web/src/utils/helpers.ts

@@ -1,6 +1,4 @@
 import { CSSProperties } from "react";
-import Quill from "quill";
-import { Delta, Op } from "quill/core";
 import { RichTextContainerProps } from "typings/RichTextProps";
 
 export const ACTION_DISPATCHER = "ACTION_DISPATCHER";
@@ -34,36 +32,3 @@ export function constructWrapperStyle(props: RichTextContainerProps): CSSPropert
 
     return wrapperStyle;
 }
-
-export function updateLegacyQuillFormats(quill: Quill): boolean {
-    const results = transformLegacyQuillFormats(quill.getContents());
-    if (results.isDirty) {
-        quill.setContents(new Delta(results.data), Quill.sources.API);
-    }
-    return results.isDirty;
-}
-
-/**
- * Transform previous version of Quill formats :
- * - previous version us ql-indent-n as classnames for indentation, which is highly dependant on quill's css
- *   this function will transformed it to use inline style
- */
-export function transformLegacyQuillFormats(delta: Delta): { data: Op[]; isDirty: boolean } {
-    let isDirty = false;
-    const newDelta: Op[] = delta.map(d => {
-        if (d.attributes && d.attributes.indent) {
-            if (!d.attributes.list) {
-                d.attributes["indent-left"] = (d.attributes.indent as number) * 3;
-                delete d.attributes.indent;
-            }
-
-            // although there seems no changes here, format.indent have been overriden for getSemanticHTML method
-            // thus, this will keep being here instead of inside the upper if.
-            if (!isDirty) {
-                isDirty = true;
-            }
-        }
-        return d;
-    });
-    return { data: newDelta, isDirty };
-}

packages/pluggableWidgets/rich-text-web/src/utils/modules/scroll.ts

@@ -2,10 +2,7 @@ import Scroll from "quill/blots/scroll";
 import MxBlock from "../formats/block";
 
 export default class MxScroll extends Scroll {
-    optimize(context?: { [key: string]: any }): void;
-    optimize(mutations?: MutationRecord[], context?: { [key: string]: any }): void;
-    // eslint-disable-next-line @typescript-eslint/explicit-function-return-type
-    optimize(mutations = [], context = {}) {
+    trimEnd(): void {
         // remove multiple empty line placed in the end
         // this is usually occurs with multi level ListContainer
         if (
@@ -15,6 +12,5 @@ export default class MxScroll extends Scroll {
         ) {
             this.children.tail.parent.removeChild(this.children.tail);
         }
-        super.optimize(mutations, context);
     }
 }