Skip to content

Commit 4929b4e

Browse files
committed
Fix review findings
1 parent 9475b6b commit 4929b4e

3 files changed

Lines changed: 9 additions & 6 deletions

File tree

maestro/helpers/compare_screenshots.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,8 @@ fs.readdirSync(actualDir).forEach(file => {
5757
];
5858
} else if (platform === 'android') {
5959
ignoredAreas = [
60-
{ x: 0, y: 0, width, height: 50 }, // Ignore top 40 pixels on Android
61-
{ x: width - 15, y: 0, width: 15, height } // Ignore right 10 pixels on Android
60+
{ x: 0, y: 0, width, height: 50 }, // Ignore top 50 pixels on Android
61+
{ x: width - 15, y: 0, width: 15, height } // Ignore right 15 pixels on Android
6262
];
6363
}
6464

maestro/run_maestro_tests_local.sh

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,10 @@
44
# Use command like: ./run_maestro_tests_local.sh android/ios proggress-circle-native
55

66
if [ "$1" == "android" ]; then
7-
#APP_ID="myapp.nativecomponentstestproject"
87
APP_ID="com.mendix.nativetemplate"
98
DEVICE_ID="emulator-5554"
109
PLATFORM="android"
1110
elif [ "$1" == "ios" ]; then
12-
#APP_ID="myapp.nativecomponentstestproject"
1311
APP_ID="com.mendix.native.template"
1412
DEVICE_ID="8CDB91BF-9D4A-4F1D-8952-A7ABBED10078"
1513
PLATFORM="ios"

packages/pluggableWidgets/image-native/e2e/specs/maestro/Image_url.yaml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,11 @@ appId: "${APP_ID}"
99
- tapOn:
1010
text: "Image url"
1111
- assertVisible: "Main as Image URL(svg); Background as No; Action as Open dialog box"
12-
# - takeScreenshot:
13-
# path: "maestro/images/actual/${PLATFORM}/image_url"
12+
# Because the image loading can take some time due to resources on emulator, we need to wait for the image to be visible
13+
- extendedWaitUntil:
14+
visible: randText # Any random text that does not exist in the UI
15+
optional: true # This should be true so that the test won't fail
16+
timeout: 15000 # 15 seconds
17+
- takeScreenshot:
18+
path: "maestro/images/actual/${PLATFORM}/image_url"
1419

0 commit comments

Comments
 (0)