Skip to content

Commit f43f1ca

Browse files
committed
Removed the default values as they are now ineffective with proper defaults set for each pod type separately.
1 parent a089c04 commit f43f1ca

4 files changed

Lines changed: 3 additions & 16 deletions

File tree

templates/deployment-sidekiq.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ spec:
123123
mountPath: /opt/mastodon/public/system
124124
{{- end }}
125125
resources:
126-
{{- toYaml (default (default $context.Values.resources $context.Values.mastodon.sidekiq.resources) .resources) | nindent 12 }}
126+
{{- toYaml (default $context.Values.mastodon.sidekiq.resources .resources) | nindent 12 }}
127127
{{- with $context.Values.nodeSelector }}
128128
nodeSelector:
129129
{{- toYaml . | nindent 8 }}

templates/deployment-streaming.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ spec:
7070
httpGet:
7171
path: /api/v1/streaming/health
7272
port: streaming
73-
{{- with (default .Values.resources .Values.mastodon.streaming.resources) }}
73+
{{- with .Values.mastodon.streaming.resources }}
7474
resources:
7575
{{- toYaml . | nindent 12 }}
7676
{{- end }}

templates/deployment-web.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ spec:
110110
port: http
111111
failureThreshold: 30
112112
periodSeconds: 5
113-
{{- with (default .Values.resources .Values.mastodon.web.resources) }}
113+
{{- with .Values.mastodon.web.resources }}
114114
resources:
115115
{{- toYaml . | nindent 12 }}
116116
{{- end }}

values.yaml

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -426,19 +426,6 @@ podAnnotations: {}
426426
# -- The annotations set with jobAnnotations will be added to all job pods.
427427
jobAnnotations: {}
428428

429-
# -- Default resources for all Deployments and jobs unless overwritten
430-
resources: {}
431-
# We usually recommend not to specify default resources and to leave this as a conscious
432-
# choice for the user. This also increases chances charts run on environments with little
433-
# resources, such as Minikube. If you do want to specify resources, uncomment the following
434-
# lines, adjust them as necessary, and remove the curly braces after 'resources:'.
435-
# limits:
436-
# cpu: 100m
437-
# memory: 128Mi
438-
# requests:
439-
# cpu: 100m
440-
# memory: 128Mi
441-
442429
# @ignored
443430
nodeSelector: {}
444431

0 commit comments

Comments
 (0)