fix: normalize episode_seed type to prevent TypeError in replay_trajectory#1430
Open
Ottohere-Mourn wants to merge 1 commit into
Open
fix: normalize episode_seed type to prevent TypeError in replay_trajectory#1430Ottohere-Mourn wants to merge 1 commit into
Ottohere-Mourn wants to merge 1 commit into
Conversation
…ctory Fixes mani-skill#1413 The episode_seed field can be stored as a numpy array, list, or scalar depending on how the trajectory was collected. Previously this would cause a TypeError when the code tried to subscript an int or compare a numpy array directly. Now the seed is normalized to a scalar int before any comparison or assignment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TypeError: 'int' object is not subscriptablewhen using--use-env-stateswith--record-rewardsand observation recording flags inreplay_trajectoryepisode_seedfield can be stored as a numpy array, list, or scalar int depending on how the trajectory was collectedepisode_seedto a scalar int before comparison or assignmentFixes #1413
Test Plan
python -m mani_skill.trajectory.replay_trajectory --traj-path <path> --record-rewards --use-env-states --save-trajno longer raises TypeError--use-env-states