chore: additional telemetry data so we can build alerting around it (#3425)

Signed-off-by: Uroš Marolt <[email protected]>

Author: themarolt

services/archetypes/worker/src/activities/activityInterceptor.ts

@@ -16,8 +16,11 @@ export class ActivityMonitoringInterceptor implements ActivityInboundCallsInterc
       workflow_type: this.ctx.info.workflowType,
       task_queue: this.ctx.info.taskQueue,
       activity_type: this.ctx.info.activityType,
+      attempts: this.ctx.info.attempt,
     }
 
+    telemetry.increment('temporal.activity_execution', 1, tags)
+
     const start = new Date()
 
     try {

services/archetypes/worker/src/activities/index.ts

@@ -8,4 +8,12 @@ async function telemetryDistribution(
   telemetry.distribution(name, value, tags)
 }
 
-export { telemetryDistribution }
+async function telemetryIncrement(
+  name: string,
+  value: number,
+  tags?: Record<string, string | number>,
+) {
+  telemetry.increment(name, value, tags)
+}
+
+export { telemetryDistribution, telemetryIncrement }

services/archetypes/worker/src/interceptors.ts

@@ -24,13 +24,17 @@ export class WorkflowMonitoringInterceptor implements WorkflowInboundCallsInterc
       workflow_id: info.workflowId,
       workflow_type: info.workflowType,
       task_queue: info.taskQueue,
+      attempts: info.attempt,
     }
 
     const start = new Date()
 
     try {
       const result = await next(input)
       return result
+    } catch (err) {
+      await activity.telemetryIncrement('temporal.workflow_execution_error', 1, tags)
+      throw err
     } finally {
       const end = new Date()
       const duration = end.getTime() - start.getTime()