Repository navigation
Conversation
kubevela#262 was written against an older main and imported crossplane-runtime's v1 test package, which main no longer requires, so pkg/context's tests stopped compiling once it merged. Signed-off-by: Brian Kane <briankane1@gmail.com>
briankane
requested review from
FogDong,
leejanee and
wonderflow
as code owners
November 21, 2026 08:02
briankane
requested review from
jerrinfrancis,
jguionnet and
roguepikachu
as code owners
November 21, 2026 08:02
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #334 +/- ##
===========================================
+ Coverage 62.49% 80.59% +18.10%
===========================================
Files 62 88 +26
Lines 4415 7054 +2639
===========================================
+ Hits 2759 5685 +2926
- Misses 1324 1369 +45
+ Partials 332 0 -332
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
Superseded by #336, which carries the same import fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
pkg/contexttests stopped compiling on main once #262 merged: itsstorage_test.goimports crossplane-runtime's v1 test package (github.com/crossplane/crossplane-runtime/pkg/test), which main no longer requires since it moved to crossplane-runtime v2. The PR was built on an older main, so its own CI didn't see it.This switches the import to
github.com/crossplane/crossplane-runtime/v2/pkg/test, ascontext_test.goalready uses.How has this code been tested
go vet ./pkg/context/andgo test ./pkg/context/pass.Summary by cubic
Fixes
pkg/contexttest compilation after the migration to crossplane-runtime v2 leftstorage_test.goimporting the old v1 test package.Switches the import in
storage_test.gotogithub.com/crossplane/crossplane-runtime/v2/pkg/test, matching whatcontext_test.goalready uses.Written for commit fe04bff. Summary will update on new commits.