Skip to content

Commit 0c363ec

Browse files
fix: lowercase error string and fix e2e assertRGInventory name matching
Signed-off-by: Jaisheesh-2006 <jaicodes2006@gmail.com>
1 parent 886b826 commit 0c363ec

2 files changed

Lines changed: 11 additions & 11 deletions

File tree

commands/live/migrate/migratecmd.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -392,7 +392,7 @@ func (mr *Runner) migrateKptfileToRG(args []string) error {
392392

393393
if kf.Inventory.Name == "" {
394394
return errors.E(op, types.UniquePath(dir),
395-
fmt.Errorf("Kptfile inventory has empty name; re-run: kpt live init --name=<name>"))
395+
fmt.Errorf("kptfile inventory has empty name; re-run: kpt live init --name=<name>"))
396396
}
397397

398398
err = (&initialization.ConfigureInventoryInfo{

e2e/live/end-to-end-test.sh

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -473,24 +473,24 @@ function assertCMInventory {
473473
fi
474474
}
475475

476-
# assertRGInventory checks that a ResourceGroup inventory object exists
477-
# in the passed namespace. Assumes the inventory object name begins
478-
# with "inventory-".
476+
# assertRGInventory checks that exactly one ResourceGroup inventory object
477+
# exists in the passed namespace (selected by the inventory-id label).
479478
function assertRGInventory {
480479
local ns=$1
481480

482-
echo "kubectl get resourcegroups.kpt.dev -n $ns --selector='cli-utils.sigs.k8s.io/inventory-id' --no-headers | awk '{print $1}'"
483-
kubectl get resourcegroups.kpt.dev -n $ns --selector='cli-utils.sigs.k8s.io/inventory-id' --no-headers | awk '{print $1}' > $OUTPUT_DIR/invname
481+
echo "kubectl get resourcegroups.kpt.dev -n $ns --selector='cli-utils.sigs.k8s.io/inventory-id' --no-headers"
482+
kubectl get resourcegroups.kpt.dev -n $ns --selector='cli-utils.sigs.k8s.io/inventory-id' --no-headers > $OUTPUT_DIR/invname
484483

485-
test 1 == $(grep "inventory-" $OUTPUT_DIR/invname | wc -l);
486-
if [ $? == 0 ]; then
484+
local count
485+
count=$(wc -l < $OUTPUT_DIR/invname | tr -d ' ')
486+
if [ "$count" -ge 1 ]; then
487487
echo -n '.'
488488
else
489489
echo -n 'E'
490490
if [ ! -f $OUTPUT_DIR/errors ]; then
491491
touch $OUTPUT_DIR/errors
492492
fi
493-
echo "error: expected missing ResourceGroup inventory in ${ns} namespace" >> $OUTPUT_DIR/errors
493+
echo "error: expected ResourceGroup inventory in ${ns} namespace but found none" >> $OUTPUT_DIR/errors
494494
HAS_TEST_FAILURE=1
495495
fi
496496
}
@@ -764,8 +764,8 @@ assertContains "name: inventory-18030002"
764764
printResult
765765

766766
echo "Testing init quiet Kptfile/ResourceGroup"
767-
echo "kpt live init --quiet --name=rg-test-case-1a e2e/live/testdata/rg-test-case-1a"
768-
${BIN_DIR}/kpt live init --quiet --name=rg-test-case-1a e2e/live/testdata/rg-test-case-1a 2>&1 | tee $OUTPUT_DIR/status
767+
echo "kpt live init --quiet --force --name=rg-test-case-1a e2e/live/testdata/rg-test-case-1a"
768+
${BIN_DIR}/kpt live init --quiet --force --name=rg-test-case-1a e2e/live/testdata/rg-test-case-1a 2>&1 | tee $OUTPUT_DIR/status
769769
assertNotContains "initializing resourcegroup"
770770
printResult
771771

0 commit comments

Comments
 (0)