Skip to content

Commit c8678f2

Browse files
committed
fixed bug with review_involving insight calculation
1 parent 73e70de commit c8678f2

2 files changed

Lines changed: 2 additions & 1 deletion

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
1212
### Fixed
1313
- pagy overflow bug
1414
- styles for admin pages
15+
- bug with review_involving insight calculation
1516

1617
## [2.0.2] - 2024-12-06
1718
### Added

app/services/insights/generate_service.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ def review_involving(date_from=@fetch_period, date_to=0)
111111
@review_involving[key] =
112112
entity_ids.each_with_object({}) do |entity_id, acc|
113113
other_user_pulls = open_pull_requests_count(date_from, date_to).except(entity_id).values.sum
114-
return 0 if other_user_pulls.zero?
114+
next acc[entity_id] = 0 if other_user_pulls.zero?
115115

116116
commented_pulls_ids = Array(pulls_with_user_comments(date_from, date_to)[entity_id])
117117
reviewed_pulls_ids = Array(pulls_with_user_reviews(date_from, date_to)[entity_id])

0 commit comments

Comments
 (0)