From 999fe5ccaf7f059c4821b43b1cedb72bd147d0b8 Mon Sep 17 00:00:00 2001 From: Carl Pearson Date: Mon, 17 Mar 2025 11:21:56 -0600 Subject: [PATCH 1/2] Mark NewtonSolve as nodiscard Signed-off-by: Carl Pearson --- ode/impl/KokkosODE_Newton_impl.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ode/impl/KokkosODE_Newton_impl.hpp b/ode/impl/KokkosODE_Newton_impl.hpp index 507a1b191f..fa7906a8bb 100644 --- a/ode/impl/KokkosODE_Newton_impl.hpp +++ b/ode/impl/KokkosODE_Newton_impl.hpp @@ -32,7 +32,7 @@ namespace Impl { template -KOKKOS_FUNCTION KokkosODE::Experimental::newton_solver_status NewtonSolve( +KOKKOS_ATTRIBUTE_NODISCARD KOKKOS_FUNCTION KokkosODE::Experimental::newton_solver_status NewtonSolve( system_type& sys, const KokkosODE::Experimental::Newton_params& params, mat_type& J, mat_type& tmp, ini_vec_type& y0, rhs_vec_type& rhs, update_type& update, const scale_type& scale) { using newton_solver_status = KokkosODE::Experimental::newton_solver_status; From 297c9fc0b44527a1519c05d01d0f60f5f96aab40 Mon Sep 17 00:00:00 2001 From: Carl Pearson Date: Fri, 19 Sep 2025 13:13:16 -0600 Subject: [PATCH 2/2] KOKKOS_ATTRIBUTE_NODISCARD -> [[nodiscard]] Signed-off-by: Carl Pearson --- ode/impl/KokkosODE_Newton_impl.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ode/impl/KokkosODE_Newton_impl.hpp b/ode/impl/KokkosODE_Newton_impl.hpp index fa7906a8bb..6ebcf20278 100644 --- a/ode/impl/KokkosODE_Newton_impl.hpp +++ b/ode/impl/KokkosODE_Newton_impl.hpp @@ -32,7 +32,7 @@ namespace Impl { template -KOKKOS_ATTRIBUTE_NODISCARD KOKKOS_FUNCTION KokkosODE::Experimental::newton_solver_status NewtonSolve( +[[nodiscard]] KOKKOS_FUNCTION KokkosODE::Experimental::newton_solver_status NewtonSolve( system_type& sys, const KokkosODE::Experimental::Newton_params& params, mat_type& J, mat_type& tmp, ini_vec_type& y0, rhs_vec_type& rhs, update_type& update, const scale_type& scale) { using newton_solver_status = KokkosODE::Experimental::newton_solver_status;