test/infamy: add Transport.log(), log messages using RPC

Wrap the infix-syslog:log RPC so tests can leave markers in a DUT's
system log over the management API instead of SSH and logger(1).
Facility names are module-qualified in the helper, and structured
data is given as a dict of dicts to keep call sites short.

The RESTCONF backend's call_dict() only tracked coverage and returned
without sending anything, so RPCs with input silently did nothing over
RESTCONF.  POST to /restconf/operations/MODULE:NAME with the input
wrapped per RFC 8040, like call_action() does.

Convert the tests that logged via SSH.  The remote and hostname_filter
tests keep using logger(1), they deliberately exercise the remote
client path.

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>

Author: troglobit

test/case/services/mdns/mdns_allow_deny/test.py

@@ -22,7 +22,7 @@ def mdns_scan():
     pcap3 = ns3.pcap("host 10.0.3.1 and port 5353")
 
     with pcap1, pcap2, pcap3:
-        ssh.runsh("logger -t scan 'calling avahi-browse ...'")
+        dut.log("calling avahi-browse ...", app_name="scan")
         ssh.runsh("avahi-browse -lat")
 
     def has_packets(output):

test/case/syslog/advanced_compare/test.py

@@ -11,14 +11,14 @@
 from infamy.util import parallel, until
 
 TEST_MESSAGES = [
-    ("daemon.emerg",   "Emergency: system is unusable"),
-    ("daemon.alert",   "Alert: immediate action required"),
-    ("daemon.crit",    "Critical: critical condition"),
-    ("daemon.err",     "Error: error condition"),
-    ("daemon.warning", "Warning: warning condition"),
-    ("daemon.notice",  "Notice: normal but significant"),
-    ("daemon.info",    "Info: informational message"),
-    ("daemon.debug",   "Debug: debug-level message"),
+    ("emergency", "Emergency: system is unusable"),
+    ("alert",     "Alert: immediate action required"),
+    ("critical",  "Critical: critical condition"),
+    ("error",     "Error: error condition"),
+    ("warning",   "Warning: warning condition"),
+    ("notice",    "Notice: normal but significant"),
+    ("info",      "Info: informational message"),
+    ("debug",     "Debug: debug-level message"),
 ]
 
 with infamy.Test() as test:
@@ -76,8 +76,8 @@
         until(lambda: tgtssh.runsh("test -f /var/log/exact-errors").returncode == 0, attempts=10)
 
     with test.step("Send test messages at all severity levels"):
-        for priority, message in TEST_MESSAGES:
-            tgtssh.runsh(f"logger -t advtest -p {priority} '{message}'")
+        for severity, message in TEST_MESSAGES:
+            target.log(message, severity=severity, facility="daemon", app_name="advtest")
         until(lambda: "Error: error condition" in tgtssh.runsh("cat /var/log/exact-errors 2>/dev/null").stdout, attempts=10)
 
     with test.step("Verify exact-errors log contains only error messages"):

test/case/syslog/pattern_match/test.py

@@ -66,7 +66,7 @@
 
     with test.step("Send test messages with various patterns"):
         for message in TEST_MESSAGES:
-            tgtssh.runsh(f"logger -t test -p daemon.info '{message}'")
+            target.log(message, severity="info", facility="daemon", app_name="test")
         time.sleep(2)
 
     with test.step("Verify errors log contains ERROR and CRITICAL messages"):

test/case/syslog/property_filter/test.py

@@ -94,7 +94,7 @@
 
     with test.step("Send test messages"):
         for tag, msg in TEST_MESSAGES:
-            tgtssh.runsh(f"logger -t {tag} -p daemon.info '{msg}'")
+            target.log(msg, severity="info", facility="daemon", app_name=tag)
         until(lambda: "Application startup" in tgtssh.runsh("cat /var/log/baseline 2>/dev/null").stdout, attempts=10)
 
     with test.step("Verify myapp log contains only myapp messages"):

test/infamy/restconf.py

@@ -411,8 +411,24 @@ def patch_config(self, xpath, edit, retries=3):
             raise last_error
 
     def call_dict(self, model, call):
+        """Call RPC, Python dictionary version: {"rpc-name": {input leaves}}"""
         coverage.track_dict(model, call)
-        pass # Need implementation
+        if len(call) != 1:
+            raise ValueError("call_dict() expects a single RPC: {name: input}")
+
+        (name, data), = call.items()
+        url = f"{self.rpc_url}/{model}:{name}"
+        body = {f"{model}:input": data} if data else None
+        response = requests_workaround_post(
+            url,
+            json=body,
+            headers=self.headers,
+            auth=self.auth,
+            verify=False
+        )
+        response.raise_for_status()
+
+        return response.content
 
     def call_rpc(self, rpc):
         """Actually send a POST to RESTCONF server"""

test/infamy/transport.py

@@ -107,3 +107,30 @@ def test_reset(self):
 
     def startup_override(self):
         self.call_action("/infix-test:test/override-startup")
+
+    def log(self, message, severity=None, facility=None, app_name=None,
+            msgid=None, sd=None):
+        """Log a message on the target, using the infix-syslog:log RPC.
+
+        Defaults to user.notice with app-name set to the calling user.
+        `facility` is a plain name, e.g. "daemon", the module prefix is
+        added here.  `sd` is RFC 5424 structured data, given as a dict
+        of dicts: {"sd-id": {"name": "value", ...}}.
+        """
+        rpc = {"message": message}
+        if severity:
+            rpc["severity"] = severity
+        if facility:
+            module = "infix-syslog" if facility in ("rauc", "container", "web") else "ietf-syslog"
+            rpc["facility"] = f"{module}:{facility}"
+        if app_name:
+            rpc["app-name"] = app_name
+        if msgid:
+            rpc["msgid"] = msgid
+        if sd:
+            rpc["structured-data"] = [{
+                "id": sdid,
+                "param": [{"name": name, "value": value} for name, value in params.items()]
+            } for sdid, params in sd.items()]
+
+        return self.call_dict("infix-syslog", {"log": rpc})