Add VolumeSnapshot resource support for Cinder#686
Open
aldokimi wants to merge 9 commits intok-orc:mainfrom
Open
Add VolumeSnapshot resource support for Cinder#686aldokimi wants to merge 9 commits intok-orc:mainfrom
aldokimi wants to merge 9 commits intok-orc:mainfrom
Conversation
Generated initial VolumeSnapshot controller files using the scaffold tool: go run ./cmd/scaffold-controller -interactive=false -kind=VolumeSnapshot -gophercloud-client=NewBlockStorageV3 -gophercloud-module=github.com/gophercloud/gophercloud/v2/openstack/blockstorage/v3/snapshots -gophercloud-type=Snapshot -openstack-json-object=snapshot -available-polling-period=15 -deleting-polling-period=15 -required-create-dependency=Volume
Add proper fields, validations, and metadata types for VolumeSnapshotResourceSpec (force, metadata), VolumeSnapshotFilter (status, volumeID), and VolumeSnapshotResourceStatus (size, metadata, progress, projectID, userID, groupSnapshotID, consumesQuota, createdAt, updatedAt) to align with the Cinder Volume Snapshot API. Those are all acoording to https://docs.openstack.org/api-ref/block-storage/v3/#volume-snapshots-snapshots:~:text=Volume%20snapshots%20(snapshots)%C2%B6
Wire the scaffolded VolumeSnapshotClient into the Scope interface, provider implementation, and MockScopeFactory. Add go:generate directives for mock generation of the VolumeSnapshotClient.
aldokimi
force-pushed
the
dev/volume_snapshot_controller
branch
from
13dfd73 to
9a0001a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #635
Summary
Adds a new VolumeSnapshot CRD and controller to manage Cinder volume snapshots.
Reference