api: mark structs with required fields as required

Non-pointer structs with required fields must be marked as required
themselves. Also use omitzero instead of omitempty to properly handle
the zero value for the struct.

Author: mandre

.golangci.yml

@@ -37,7 +37,6 @@ linters:
               # NOTE: conflicts with the lack of validation in the Status structs
               - arrayofstruct
               # NOTE: The following checks are currently failing
-              - nonpointerstructs
               - optionalfields
             enable:
               - commentstart
@@ -53,6 +52,7 @@ linters:
               - nodurations
               - nofloats
               - nomaps
+              - nonpointerstructs
               - nonullable
               - notimestamp
               - nophase

api/v1alpha1/router_interface_types.go

@@ -36,8 +36,8 @@ type RouterInterface struct {
 	metav1.ObjectMeta `json:"metadata,omitempty"`
 
 	// spec specifies the desired state of the resource.
-	// +optional
-	Spec RouterInterfaceSpec `json:"spec,omitempty"`
+	// +required
+	Spec RouterInterfaceSpec `json:"spec,omitzero"`
 
 	// status defines the observed state of the resource.
 	// +optional