Skip to content

Commit e560203

Browse files
chore: update GitHub Actions workflow for quality checks and add typecheck script.
1 parent 1cf6a0b commit e560203

3 files changed

Lines changed: 26 additions & 1 deletion

File tree

‎.github/workflows/tests.yaml‎

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,28 @@ on:
77
branches: [master]
88

99
jobs:
10+
quality:
11+
runs-on: ubuntu-latest
12+
steps:
13+
- uses: actions/checkout@v4
14+
15+
- name: Setup Node.js
16+
uses: actions/setup-node@v4
17+
with:
18+
node-version: '22'
19+
20+
- name: Install dependencies
21+
run: npm ci
22+
23+
- name: Run ESLint
24+
run: npm run lint
25+
26+
- name: Check types
27+
run: npm run typecheck
28+
29+
- name: Build
30+
run: npm run build
31+
1032
test:
1133
runs-on: ubuntu-latest
1234
steps:

‎package.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
"build": "next build --webpack",
1010
"start": "next start",
1111
"lint": "eslint .",
12+
"typecheck": "tsc --noEmit",
1213
"test": "vitest",
1314
"coverage": "vitest run --coverage",
1415
"playwright:test-ui": "NODE_OPTIONS=\"--no-experimental-strip-types\" npx playwright test --ui"

‎src/features/common/components/layout/page-layout/page-layout.component.tsx‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,9 @@ export const PageLayoutComponent: React.FC<LayoutComponentProps> = ({
2424
const layoutDictionary = getLayoutDictionary(languageCode);
2525

2626
return (
27-
<html lang={languageCode} data-theme={themeCode}>
27+
// The inline script below rewrites data-theme before hydration, so this
28+
// element's attributes are expected to differ from the server render.
29+
<html lang={languageCode} data-theme={themeCode} suppressHydrationWarning>
2830
<head>
2931
<meta
3032
httpEquiv="origin-trial"

0 commit comments

Comments
 (0)