From 270f4187b3d5966dc388b078a6e61fd6637fad0c Mon Sep 17 00:00:00 2001
From: limad <35463455+limad@users.noreply.github.com>
Date: Tue, 28 Apr 2026 07:40:12 +0200
Subject: [PATCH] Fix implicit globals and remove dead code in core/js

- core.js: declare loop variable in `for (var i in _replace)` (was
  leaking i as implicit global)
- view.class.js: declare `var result` in toHtml's pre_success (was
  leaking result as implicit global)
- view.class.js: declare `var option` in handleViewAjax's graph zone
  loop (was leaking option as implicit global)
- private.class.js: remove unused `var param = null` (dead code)

These are pre-existing bugs in the var-based code, fixed without
changing the surrounding declaration style. Found via ESLint
(no-undef-init, no-unused-vars).
---
 core/js/core.js          | 2 +-
 core/js/private.class.js | 1 -
 core/js/view.class.js    | 4 ++--
 3 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/core/js/core.js b/core/js/core.js
index 71482433cc..02896262ee 100644
--- a/core/js/core.js
+++ b/core/js/core.js
@@ -31,7 +31,7 @@ function getTemplate(_folder, _version, _filename, _replace) {
     success: function(data) {
       if (isset(_replace) && _replace != null) {
         var reg = null;
-        for (i in _replace) {
+        for (var i in _replace) {
           reg = new RegExp(i, "g");
           data = data.replace(reg, _replace[i]);
         }
diff --git a/core/js/private.class.js b/core/js/private.class.js
index 2276e73ded..edaf93c55b 100644
--- a/core/js/private.class.js
+++ b/core/js/private.class.js
@@ -274,7 +274,6 @@ jeedom.private.checkAndGetParams = function(_params, _paramsSpecifics, _paramsRe
   var params = domUtils.extend({}, jeedom.private.default_params, _paramsSpecifics, _params || {});
 
   //Convert all objects in params to json
-  var param = null;
   for (var attr in params) {
     params[attr] = (typeof params[attr] == 'object') ? JSON.stringify(params[attr]) : params[attr];
   }
diff --git a/core/js/view.class.js b/core/js/view.class.js
index 67501f4f14..be5de68e66 100644
--- a/core/js/view.class.js
+++ b/core/js/view.class.js
@@ -48,7 +48,7 @@ jeedom.view.toHtml = function(_params) {
   var paramsRequired = ['id', 'version'];
   var paramsSpecifics = {
     pre_success: function(data) {
-      result = jeedom.view.handleViewAjax({
+      var result = jeedom.view.handleViewAjax({
         view: data.result
       });
       result.raw = data.result;
@@ -135,7 +135,7 @@ jeedom.view.handleViewAjax = function(_params) {
       for (var j in viewZone.viewData) {
         viewData = viewZone.viewData[j];
         configuration = JSON.stringify(viewData.configuration);
-        option = configuration.replace(/"/g, "'");
+        var option = configuration.replace(/"/g, "'");
         result.html += '<div class="viewZoneData hidden" data-cmdId="'+viewData.link_id+'" data-option="'+option+'" data-el="'+div_id+'" data-height="'+viewZone.configuration.height+'" data-dateRange="'+viewZone.configuration.dateRange+'"></div>';
       }
       result.html += '</div>';