feat: attribute handler now checks whether the 'attr' argument is an empty list to remind us that it's not fully implemented yet

Author: ntamas

src/codegen/internal_lib.py.in

@@ -9,6 +9,7 @@ from .errors import handle_igraph_error_t
 from .types import (
     FILE,
     igraph_attribute_combination_t,
+    igraph_attribute_record_t,
     igraph_attribute_record_list_t,
     igraph_attribute_table_t,
     igraph_bool_t,
@@ -553,6 +554,14 @@ igraph_attribute_combination_query = _lib.igraph_attribute_combination_query
 igraph_attribute_combination_query.restype = handle_igraph_error_t
 igraph_attribute_combination_query.argtypes = [POINTER(igraph_attribute_combination_t), c_char_p, POINTER(c_int), POINTER(c_void_p)]
 
+igraph_attribute_record_list_get_ptr = _lib.igraph_attribute_record_list_get_ptr
+igraph_attribute_record_list_get_ptr.restype = POINTER(igraph_attribute_record_t)
+igraph_attribute_record_list_get_ptr.argtypes = [POINTER(igraph_attribute_record_list_t), igraph_integer_t]
+
+igraph_attribute_record_list_size = _lib.igraph_attribute_record_list_size
+igraph_attribute_record_list_size.restype = igraph_integer_t
+igraph_attribute_record_list_size.argtypes = [POINTER(igraph_attribute_record_list_t)]
+
 # Error handling and interruptions
 
 igraph_error = _lib.igraph_error

src/igraph_ctypes/_internal/attributes/handler.py

@@ -14,6 +14,7 @@
 from igraph_ctypes._internal.functions import igraph_ecount, igraph_vcount
 from igraph_ctypes._internal.lib import (
     igraph_attribute_combination_query,
+    igraph_attribute_record_list_size,
     igraph_error,
     igraph_es_as_vector,
     igraph_vector_resize,
@@ -117,6 +118,9 @@ def init(self, graph, attr):
         assign_storage_to_graph(graph, DictAttributeStorage())
         self._indices = _VectorInt.create(0)
 
+        if attr and igraph_attribute_record_list_size(attr) != 0:
+            raise RuntimeError("attribute initialization not implemented yet")
+
     def destroy(self, graph) -> None:
         storage = get_storage_from_graph(graph)
         if storage:
@@ -148,12 +152,8 @@ def copy(
         assign_storage_to_graph(to, new_storage)
 
     def add_vertices(self, graph, n: int, attr) -> None:
-        # attr will only ever be NULL here so raise an error if it is not
-        if attr:
-            raise RuntimeError(
-                "add_vertices() attribute handler called with non-null attr; "
-                "this is most likely a bug"
-            )  # pragma: no cover
+        if attr and igraph_attribute_record_list_size(attr) != 0:
+            raise RuntimeError("attribute initialization not implemented yet")
 
         # Extend the existing attribute containers
         get_storage_from_graph(graph).add_vertices(graph, n)
@@ -172,12 +172,8 @@ def combine_vertices(self, graph, to, mapping, combinations):
         assert not _are_pointers_equal(graph, to)
 
     def add_edges(self, graph, edges, attr) -> None:
-        # attr will only ever be NULL here so raise an error if it is not
-        if attr:
-            raise RuntimeError(
-                "add_edges() attribute handler called with non-null attr; "
-                "this is most likely a bug"
-            )  # pragma: no cover
+        if attr and igraph_attribute_record_list_size(attr) != 0:
+            raise RuntimeError("attribute initialization not implemented yet")
 
         # Extend the existing attribute containers
         edge_array = igraph_vector_int_t_to_numpy_array_view(edges).reshape((-1, 2))

src/igraph_ctypes/_internal/lib.py

@@ -9,6 +9,7 @@
 from .types import (
     FILE,
     igraph_attribute_combination_t,
+    igraph_attribute_record_t,
     igraph_attribute_record_list_t,
     igraph_attribute_table_t,
     igraph_bool_t,
@@ -553,6 +554,14 @@ def _load_libc():
 igraph_attribute_combination_query.restype = handle_igraph_error_t
 igraph_attribute_combination_query.argtypes = [POINTER(igraph_attribute_combination_t), c_char_p, POINTER(c_int), POINTER(c_void_p)]
 
+igraph_attribute_record_list_get_ptr = _lib.igraph_attribute_record_list_get_ptr
+igraph_attribute_record_list_get_ptr.restype = POINTER(igraph_attribute_record_t)
+igraph_attribute_record_list_get_ptr.argtypes = [POINTER(igraph_attribute_record_list_t), igraph_integer_t]
+
+igraph_attribute_record_list_size = _lib.igraph_attribute_record_list_size
+igraph_attribute_record_list_size.restype = igraph_integer_t
+igraph_attribute_record_list_size.argtypes = [POINTER(igraph_attribute_record_list_t)]
+
 # Error handling and interruptions
 
 igraph_error = _lib.igraph_error

src/igraph_ctypes/_internal/types.py

@@ -475,6 +475,7 @@ class igraph_rng_t(Structure):
 
 
 p_attribute_combination_t = POINTER(igraph_attribute_combination_t)
+p_attribute_record_list_t = POINTER(igraph_attribute_record_list_t)
 p_igraph_t = POINTER(igraph_t)
 p_strvector_t = POINTER(igraph_strvector_t)
 p_vector_t = POINTER(igraph_vector_t)
@@ -488,7 +489,7 @@ class igraph_attribute_table_t(Structure):
     """ctypes representation of ``igraph_attribute_table_t``"""
 
     TYPES = {
-        "init": CFUNCTYPE(igraph_error_t, p_igraph_t, p_vector_ptr_t),
+        "init": CFUNCTYPE(igraph_error_t, p_igraph_t, p_attribute_record_list_t),
         "destroy": CFUNCTYPE(None, p_igraph_t),
         "copy": CFUNCTYPE(
             igraph_error_t,
@@ -499,7 +500,7 @@ class igraph_attribute_table_t(Structure):
             igraph_bool_t,
         ),
         "add_vertices": CFUNCTYPE(
-            igraph_error_t, p_igraph_t, igraph_integer_t, p_vector_ptr_t
+            igraph_error_t, p_igraph_t, igraph_integer_t, p_attribute_record_list_t
         ),
         "permute_vertices": CFUNCTYPE(
             igraph_error_t, p_igraph_t, p_igraph_t, p_vector_int_t
@@ -512,7 +513,7 @@ class igraph_attribute_table_t(Structure):
             p_attribute_combination_t,
         ),
         "add_edges": CFUNCTYPE(
-            igraph_error_t, p_igraph_t, p_vector_int_t, p_vector_ptr_t
+            igraph_error_t, p_igraph_t, p_vector_int_t, p_attribute_record_list_t
         ),
         "permute_edges": CFUNCTYPE(
             igraph_error_t, p_igraph_t, p_igraph_t, p_vector_int_t