From 7e062f35d662372f428bcda38fcd3ad8c10e7f82 Mon Sep 17 00:00:00 2001 From: mmelnich Date: Tue, 4 Aug 2026 09:53:25 -0700 Subject: [PATCH] Add missing direct includes for MSVC builds config.h uses int64_t for lapack_int under LAPACK_ILP64 but never includes ; lartg.cc uses std::complex but never includes . Both compile on Unix only through transitive includes of the platform C/C++ standard library; MSVC's headers do not provide them, so native MSVC ILP64 builds fail (C4430/C2146 in config.h, C2039 in lartg.cc). Include both headers directly. Reported in RandBLAS Windows-portability work by Raphael A. Meyer. --- include/lapack/config.h | 1 + src/lartg.cc | 2 ++ 2 files changed, 3 insertions(+) diff --git a/include/lapack/config.h b/include/lapack/config.h index f1a5c37f..381aff39 100644 --- a/include/lapack/config.h +++ b/include/lapack/config.h @@ -10,6 +10,7 @@ #include "lapack/defines.h" #include +#include #if defined(BLAS_ILP64) && ! defined(LAPACK_ILP64) #define LAPACK_ILP64 diff --git a/src/lartg.cc b/src/lartg.cc index a4806867..a6a896bf 100644 --- a/src/lartg.cc +++ b/src/lartg.cc @@ -5,6 +5,8 @@ #include "lapack/fortran.h" +#include + namespace lapack { // -----------------------------------------------------------------------------