[HDX-2300] introduce Shared Filters for team-wide filter visibility and discoverability by brandon-pereira · Pull Request #2047 · hyperdxio/hyperdx

brandon-pereira · 2026-04-02T20:17:24Z

Summary

Introduces a "Shared Filters" feature (in addition to locally pinned items in HyperDX.

Especially helpful for teams with lots of filters and team members, allows users to highlight the top filters easily for all members.

This has been one of the most requested features we have received from enterprise customers. \

Note: - currently any user on a team can modify shared filters - we may want/need to introduce role limits to this, but that is oos

Screenshots or video

export-1775685397652.mp4

How to test locally or on Vercel

Start the dev server (yarn dev)
Navigate to the Search page
Pin a filter field using the 📌 icon on any filter group header —you should be asked to pin (existing) or add to shared filters.
Share a specific value by hovering over a filter checkbox row and clicking the pin icon — it should also appear in Shared Filters
Reload the page — pins should persist (MongoDB-backed)
Open a second browser/incognito window with the same team — pins should be visible there too
Click the ⚙ gear icon next to "Filters" — toggle "Show Shared Filters" off/on
Click "Reset Shared Filters" in the gear popover to clear all team pins

References

Linear Issue: https://linear.app/clickhouse/issue/HDX-2300/sailpoint-neara-global-filter-pinning
Related PRs: Previous WIP branch brandon/shared-filters-ui (superseded by this implementation)

- Add PinnedFilter Mongoose model with team+source+user compound index - Add GET/PUT /pinned-filters API routes with Zod validation - Replace localStorage-based pinned filters with MongoDB-backed TanStack Query hooks - Add SharedFilters UI section showing team-pinned fields at top of filter sidebar - Add FilterSettingsPanel popover with show/hide toggle and reset button - Add optimistic local state to prevent stale reads during rapid toggles - Add one-time localStorage → MongoDB migration for existing users - Add local-mode fallback for development without API - Remove pinned fields from main filters list when shown in SharedFilters - Persist 'Show Shared Filters' preference in localStorage - Add integration tests for pinned filters API (14 tests) - Add unit tests for merge logic and migration (12 tests) - Add E2E tests for shared filters UI flow (8 tests)

vercel · 2026-04-02T20:17:29Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
hyperdx-oss	Ready	Preview, Comment	Apr 16, 2026 9:13pm

changeset-bot · 2026-04-02T20:17:34Z

🦋 Changeset detected

Latest commit: 9376712

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages

Name	Type
@hyperdx/common-utils	Minor
@hyperdx/api	Minor
@hyperdx/app	Minor
@hyperdx/otel-collector	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2026-04-02T20:20:58Z

E2E Test Results

✅ All tests passed • 140 passed • 3 skipped • 1080s

Status	Count
✅ Passed	140
❌ Failed	0
⚠️ Flaky	4
⏭️ Skipped	3

Tests ran across 4 shards in parallel.

View full report →

…perdxio/hyperdx into brandon/global-pinned-filters

github-actions · 2026-04-02T20:37:48Z

PR Review

[HDX-2300] Shared Filters — well-structured feature with solid API design, good test coverage, and clean separation of personal vs. team pins.

Issues

⚠️ No authorization enforcement on PUT endpoint — any authenticated team member can overwrite or reset the entire team's shared filters. The PR acknowledges this as OOS, but there is no even a guard for the reset-to-empty case. Consider at minimum logging mutations for auditability, or requiring an explicit confirm: true flag for the destructive reset path.
⚠️ DBSearchPageFilters.tsx is 1,954 lines — the AGENTS.md convention is "keep files under 300 lines." This PR adds ~150 more lines to an already oversized component. The new sharedFacets/sharedFilterKeys logic (~60 lines) could be extracted into a custom hook.
⚠️ In-flight mutation fires setOptimisticTeam(null) after unmount — the useEffect cleanup cancels the pending debounce timeout, but if the mutation is already in flight when the component unmounts, the onSettled callback will still run and call setOptimisticTeam. React 18+ silently ignores this, but it can mask issues during testing. Consider using an isMounted ref guard in onSettled.
⚠️ No server-side deduplication of the fields array — the Zod schema enforces .max(100) but not uniqueness. PUT with fields: ["ServiceName", "ServiceName"] stores both, which can cause double-rendering in the shared filters section. Add .transform(arr => [...new Set(arr)]) to the schema or in the controller.
🔒 Source ID passed as URL query param without encoding — hdxServer(\pinned-filters?source=${sourceId}`)` is fine today (MongoDB ObjectId is hex-only) but is fragile as a pattern. Prefer passing it via a query helper that URL-encodes params.

Positive Notes

Team isolation is properly enforced: teamId always comes from the authenticated session (never from request body), and source ownership is verified before any read/write.
Schema validation limits (PinnedFiltersValueSchema: 100 keys, 50 values, 1024-char strings) are sensible.
Optimistic update keyed by sourceId avoids stale state on source navigation — clean design.
Good test coverage: unit tests for mergePinnedData, integration tests for the API router including cross-source scoping and boolean values.

- Fix integration test team scoping by inserting PinnedFilter directly in MongoDB instead of trying to register a second user (409 Conflict) - Fix E2E shared-filters test isolation by resetting pinned filters via API in beforeEach so state doesn't leak between tests - Add title attribute to field pin ActionIcons so E2E pinField selector can find them - Use dispatchEvent in scrollAndClick to avoid flaky CSS hover state - Replace waitForTimeout with expect.poll and Playwright assertions for proper wait mechanisms

pulpdrew · 2026-04-03T13:38:59Z

+  return PinnedFilterModel.findOne({
+    team: new mongoose.Types.ObjectId(teamId),
+    source: new mongoose.Types.ObjectId(sourceId),
+    user: null,


I see that the code includes the capability to store user-level pinned filters, but I don't see that implemented anywhere.

IMO, we shouldn't remove user-specific pinned filters, since different users are likely to care about different filter keys and values. Having no special UI for "pin for team" vs "pin for me" is likely to result in various teammates modifying the filters for the entire team without realizing they're doing so.

It's also odd that the migration from local --> team/db filters is automatic, and applies to the entire team. The first user to login after deploying this will have their filters set for the entire team, possibly unexpectedly.

I would suggest we implement both user-level and team-level filters, and have the migration create user-level pinned filters.

@pulpdrew you're right, I was trying to keep the scope small and minimize UX changes, but it didn't make sense.

I have changed the UX of this so that clicking the pin icons opens a menu where you can select between pin and share. I have updated the PR description with a video.

Previously localStorage was still used for local mode, but now localStorage is used for pinning and mongo is used for sharing with team.

I have also removed the migration since it's not needed.

Makes sense, though with user-specific pinned filters always using local storage, should we remove the user field from this model now?

github-actions · 2026-04-06T14:12:45Z

🔴 Tier 4 — Critical

Touches auth, data models, config, tasks, OTel pipeline, ClickHouse, or CI/CD.

Why this tier:

Large diff: 2050 production lines changed (threshold: 1000)
Cross-layer change: touches frontend (packages/app) + backend (packages/api) + shared utils (packages/common-utils)
Touches API routes or data models — hidden complexity risk

Review process: Deep review from a domain expert. Synchronous walkthrough may be required.
SLA: Schedule synchronous review within 2 business days.

Stats

Production files changed: 13
Production lines changed: 2050 (+ 665 in test files, excluded from tier calculation)
Branch: brandon/global-pinned-filters
Author: brandon-pereira

To override this classification, remove the review/tier-4 label and apply a different review/tier-* label. Manual overrides are preserved on subsequent pushes.

pulpdrew · 2026-04-10T13:15:44Z

The behavior is odd for shared filters that don't load in the initial round of filters. Clicking Load More doesn't work, until clicking More filters in the non-shared section. See ScopeName here

Screen.Recording.2026-04-10.at.9.13.50.AM.mov

pulpdrew

I like this approach much better - just a couple more comments

brandon-pereira · 2026-04-10T17:43:00Z

The behavior is odd for shared filters that don't load in the initial round of filters. Clicking Load More doesn't work, until clicking More filters in the non-shared section. See ScopeName here

Screen.Recording.2026-04-10.at.9.13.50.AM.mov

Good catch - now shared filters will always be fetched on load

… import

brandon-pereira · 2026-04-16T19:33:58Z

Async Feedback from @alex-clickhouse I will implement:

I will do the following:

Add a divider between the groups
Move "Filters" into an accordion so it can be collapsed
I will move the filter settings up OUTSIDE of filters/shared filters/mandatory filters so that its clear it applies to all sections

…e resolution issue in CI

…mpat

…-filters

alex-fedotyev

Looks good!

brandon-pereira added the ai-generated AI-generated content; review carefully before merging. label Apr 2, 2026

brandon-pereira and others added 2 commits April 2, 2026 14:20

add changeset, fix knip

07769c6

Merge branch 'main' into brandon/global-pinned-filters

203ce6c

vercel bot deployed to Preview April 2, 2026 20:24 View deployment

brandon-pereira added 2 commits April 2, 2026 14:32

fix spacing

c9210b5

Merge branch 'brandon/global-pinned-filters' of https://github.com/hy…

67e802c

…perdxio/hyperdx into brandon/global-pinned-filters

brandon-pereira requested review from a team, fleon and wrn14897 and removed request for a team and wrn14897 April 2, 2026 20:34

brandon-pereira marked this pull request as ready for review April 2, 2026 20:34

vercel bot deployed to Preview April 2, 2026 20:35 View deployment

claude feedback

96fe754

vercel bot deployed to Preview April 2, 2026 20:58 View deployment

vercel bot deployed to Preview April 2, 2026 22:29 View deployment

fix(e2e): increase assertion timeouts for slow CI

68999fe

vercel bot deployed to Preview April 2, 2026 23:07 View deployment

pulpdrew reviewed Apr 3, 2026

View reviewed changes

pulpdrew added the waiting-on-author label Apr 3, 2026

github-actions bot added the review/tier-4 Critical — deep review + domain expert sign-off label Apr 6, 2026

attempt to improve test

9c8a0f0

vercel bot deployed to Preview April 8, 2026 23:26 View deployment

pulpdrew reviewed Apr 10, 2026

View reviewed changes

Comment thread packages/api/src/routers/api/pinnedFilters.ts Outdated

Comment thread packages/app/src/components/DBSearchPageFilters.tsx

brandon-pereira removed ai-generated AI-generated content; review carefully before merging. waiting-on-author labels Apr 10, 2026

pr feedback

5a3a3bd

brandon-pereira requested a review from pulpdrew April 10, 2026 17:49

vercel bot deployed to Preview April 10, 2026 17:50 View deployment

Merge origin/main - resolve localStore conflict, drop unused hashCode…

8ab5199

… import

pulpdrew previously approved these changes Apr 10, 2026

View reviewed changes

vercel bot deployed to Preview April 10, 2026 17:54 View deployment

ux feedback

744bf54

brandon-pereira dismissed pulpdrew’s stale review via 744bf54 April 16, 2026 19:52

vercel bot deployed to Preview April 16, 2026 19:54 View deployment

fix: use spread syntax for Collapse 'in' prop to avoid TS factory typ…

fb36c0c

…e resolution issue in CI

vercel bot deployed to Preview April 16, 2026 20:19 View deployment

fix: pass both 'in' and 'expanded' to Collapse for Mantine version co…

0d292db

…mpat

vercel bot deployed to Preview April 16, 2026 20:43 View deployment

brandon-pereira added 2 commits April 16, 2026 14:43

Merge remote-tracking branch 'origin/main' into brandon/global-pinned…

ce2b4a2

…-filters

fix: use Mantine 9 Collapse 'expanded' prop, remove compat workaround

be3441c

vercel bot deployed to Preview April 16, 2026 20:50 View deployment

move refresh icon

9376712

vercel bot deployed to Preview April 16, 2026 21:13 View deployment

brandon-pereira added the automerge label Apr 16, 2026

alex-fedotyev approved these changes Apr 16, 2026

View reviewed changes

kodiakhq bot merged commit 5885d47 into main Apr 16, 2026
19 checks passed

kodiakhq bot deleted the brandon/global-pinned-filters branch April 16, 2026 21:28

Conversation

brandon-pereira commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Screenshots or video

How to test locally or on Vercel

References

Uh oh!

vercel bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E Test Results

Uh oh!

github-actions bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Review

Issues

Positive Notes

Uh oh!

pulpdrew Apr 3, 2026

Choose a reason for hiding this comment

Uh oh!

brandon-pereira Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

pulpdrew Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔴 Tier 4 — Critical

Uh oh!

pulpdrew commented Apr 10, 2026

Uh oh!

pulpdrew left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

brandon-pereira commented Apr 10, 2026

Uh oh!

brandon-pereira commented Apr 16, 2026

Uh oh!

alex-fedotyev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

brandon-pereira commented Apr 2, 2026 •

edited

Loading

vercel bot commented Apr 2, 2026 •

edited

Loading

changeset-bot bot commented Apr 2, 2026 •

edited

Loading

github-actions bot commented Apr 2, 2026 •

edited

Loading

github-actions bot commented Apr 2, 2026 •

edited

Loading

github-actions bot commented Apr 6, 2026 •

edited

Loading