Skip to content

Commit c769a1c

Browse files
authored
Merge pull request #46 from hymkor/push-pvlvwxzxnwyp
Fixed an issue where the version string was empty when built without GNU Make
2 parents af3119d + e5a6786 commit c769a1c

File tree

5 files changed

+14
-4
lines changed

5 files changed

+14
-4
lines changed

Makefile

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,9 @@ manifest:
4747
release:
4848
$(GO) run github.com/hymkor/latest-notes@latest | gh release create -d --notes-file - -t $(VERSION) $(VERSION) $(wildcard $(NAME)-$(VERSION)-*.zip)
4949

50+
bump:
51+
$(GO) run github.com/hymkor/latest-notes@latest -suffix "-goinstall" -gosrc sqlbless release_note*.md > version.go
52+
5053
docs:
5154
$(GO) run github.com/hymkor/minipage@latest -outline-in-sidebar -readme-to-index README.md > docs/index.html
5255
$(GO) run github.com/hymkor/minipage@latest -outline-in-sidebar -readme-to-index README_ja.md > docs/index_ja.html
@@ -55,4 +58,4 @@ readme:
5558
$(GO) run github.com/hymkor/example-into-readme@latest
5659
$(GO) run github.com/hymkor/example-into-readme@latest -target README_ja.md
5760

58-
.PHONY: all test dist _dist clean manifest release docs
61+
.PHONY: all test dist _dist clean manifest release docs bump

main.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,11 +52,9 @@ func (cfg *Config) Bind(fs *flag.FlagSet) *Config {
5252
return cfg
5353
}
5454

55-
var Version string
56-
5755
func writeSignature(w io.Writer) {
5856
fmt.Fprintf(w, "# SQL-Bless %s-%s-%s built with %s\n",
59-
Version, runtime.GOOS, runtime.GOARCH, runtime.Version())
57+
version, runtime.GOOS, runtime.GOARCH, runtime.Version())
6058
}
6159

6260
func usage() {

release_note_en.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@ Release notes (English)
22
=======================
33
( **English** / [Japanese](release_note_ja.md) )
44

5+
- Fixed an issue where the version string was empty when built without GNU Make.
6+
The version string is now updated via make bump during the release process. (#46)
7+
58
v0.27.4
69
-------
710
Feb 14, 2026

release_note_ja.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@ Release notes (Japanese)
22
========================
33
( [English](release_note_en.md) / **Japanese** )
44

5+
- GNU Make なしでビルドした場合に、バージョン文字列が空になってしまう問題を修正
6+
今後、バージョンアップ時に make bump を実行する (#46)
7+
58
v0.27.4
69
-------
710
Feb 14, 2026

version.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
package sqlbless
2+
3+
var version = "v0.27.4-goinstall"

0 commit comments

Comments
 (0)