feat: make readiness/preview checks frontend-owned

Author: gildesmarais

frontend/e2e/smoke.spec.ts

@@ -40,7 +40,7 @@ test.describe('frontend smoke', () => {
     await expect(page.getByRole('button', { name: 'Back' })).toBeVisible();
 
     await page.getByRole('button', { name: 'Back' }).click();
-    await expect(page).toHaveURL(/\/create(?:\?.*)?$/);
+    await expect(page).toHaveURL(/#\/create(?:\?.*)?$/);
     await expect(page.getByRole('button', { name: 'Generate feed URL' })).toBeVisible();
     await expect(page.locator('.form-shell')).toHaveAttribute('data-state', 'idle');
   });
@@ -97,15 +97,14 @@ test.describe('frontend smoke', () => {
               ],
               isLoading: false,
             },
-            readinessPhase: 'feed_ready',
-            previewStatus: 'ready',
+            workflowState: 'preview_ready' as const,
             warnings: [],
           },
         })
       );
     });
 
-    await page.goto('/result/generated-token');
+    await page.goto('/#/result/generated-token');
 
     await expect(page.getByRole('heading', { name: 'Feed ready' })).toBeVisible();
     await expect(page.locator('.result-shell')).toHaveAttribute('data-state', 'ready');
@@ -121,13 +120,11 @@ test.describe('frontend smoke', () => {
       localStorage.removeItem('html2rss_feed_result_snapshot:missing-token');
     });
 
-    await page.goto('/result/missing-token');
+    await page.goto('/#/result/missing-token');
 
     await expect(page.getByText('Saved result unavailable')).toBeVisible();
-    await expect(
-      page.getByText('We could not restore this feed result. Create a new feed link to continue.')
-    ).toBeVisible();
+    await expect(page.getByText('Create a new feed link to continue.')).toBeVisible();
     await expect(page.getByRole('button', { name: 'Go to create' })).toBeVisible();
-    await expect(page.locator('.notice')).toHaveAttribute('data-tone', 'error');
+    await expect(page.locator('.result-recovery')).toHaveAttribute('data-state', 'failed');
   });
 });

frontend/src/__tests__/App.contract.test.tsx

@@ -1,4 +1,4 @@
-import { describe, it, expect, beforeEach } from 'vitest';
+import { describe, it, expect, beforeEach, vi } from 'vitest';
 import { render, screen, fireEvent, waitFor } from '@testing-library/preact';
 import { http, HttpResponse } from 'msw';
 import { server, buildFeedResponse, buildStructuredErrorResponse } from './mocks/server';
@@ -8,13 +8,37 @@ describe('App contract', () => {
   const token = 'contract-token';
 
   beforeEach(() => {
-    globalThis.history.replaceState({}, '', 'http://localhost:3000/create');
+    globalThis.history.replaceState({}, '', 'http://localhost:3000/#/create');
     globalThis.localStorage.clear();
     globalThis.sessionStorage.clear();
     globalThis.sessionStorage.setItem('html2rss_access_token', token);
   });
 
-  it('shows feed result when the API returns structured create and status payloads', async () => {
+  it('shows feed result when the API returns structured create payload and preview feed', async () => {
+    const nativeFetch = globalThis.fetch;
+    const fetchSpy = vi.spyOn(globalThis, 'fetch').mockImplementation((input, init) => {
+      if (String(input).endsWith('/api/v1/feeds/generated-token.json')) {
+        expect((init?.headers as Record<string, string> | undefined)?.Accept).toBe('application/feed+json');
+        return Promise.resolve(
+          new Response(
+            JSON.stringify({
+              items: [
+                {
+                  title: 'Contract Item',
+                  content_text: 'Contract preview excerpt.',
+                  url: 'https://example.com/contract-item',
+                  date_published: '2024-01-01T00:00:00Z',
+                },
+              ],
+            }),
+            { status: 200, headers: { 'Content-Type': 'application/feed+json' } }
+          )
+        );
+      }
+
+      return nativeFetch(input, init);
+    });
+
     server.use(
       http.post('/api/v1/feeds', async ({ request }) => {
         const body = (await request.json()) as { url: string };
@@ -28,30 +52,11 @@ describe('App contract', () => {
             feed_token: 'generated-token',
             public_url: '/api/v1/feeds/generated-token',
             json_public_url: '/api/v1/feeds/generated-token.json',
-            conversion: {
-              readiness_phase: 'link_created',
-              preview_status: 'pending',
-              warnings: [],
-            },
           }),
           { status: 201 }
         );
       }),
-      http.get('/api/v1/feeds/generated-token/status', () =>
-        HttpResponse.json(
-          buildFeedResponse({
-            feed_token: 'generated-token',
-            public_url: '/api/v1/feeds/generated-token',
-            json_public_url: '/api/v1/feeds/generated-token.json',
-            conversion: {
-              readiness_phase: 'feed_ready',
-              preview_status: 'ready',
-              warnings: [],
-            },
-          })
-        )
-      ),
-      http.get('/api/v1/feeds/generated-token.json', ({ request }) => {
+      http.get('http://localhost:3000/api/v1/feeds/generated-token.json', ({ request }) => {
         expect(request.headers.get('accept')).toBe('application/feed+json');
 
         return HttpResponse.json(
@@ -69,6 +74,20 @@ describe('App contract', () => {
             headers: { 'content-type': 'application/feed+json' },
           }
         );
+      }),
+      http.get('/api/v1/feeds/generated-token.json', ({ request }) => {
+        expect(request.headers.get('accept')).toBe('application/feed+json');
+
+        return HttpResponse.json({
+          items: [
+            {
+              title: 'Contract Item',
+              content_text: 'Contract preview excerpt.',
+              url: 'https://example.com/contract-item',
+              date_published: '2024-01-01T00:00:00Z',
+            },
+          ],
+        });
       })
     );
 
@@ -92,6 +111,7 @@ describe('App contract', () => {
       expect(screen.getByRole('button', { name: 'Create another feed' })).toBeInTheDocument();
       expect(screen.getByText('Latest items from this feed')).toBeInTheDocument();
     });
+    fetchSpy.mockRestore();
   });
 
   it('reopens token recovery when a saved token is rejected by structured auth metadata', async () => {