Introduce check location disabled usecase

[TimoPtr]

Summary

Introduce a new use case to extract the logic to check if the location permission is missing and show a permission. Add the use case to the new FrontendScreen.

Based on #6720.

Checklist

• New or updated tests have been added to cover the changes following the testing guidelines.
• The code follows the project's code style and best_practices.
• The changes have been thoroughly tested, and edge cases have been considered.
• Changes are backward compatible whenever feasible. Any breaking changes are documented in the changelog for users and/or in the code for developers depending on the relevance.

[github-actions]

Test Results

  233 files    241 suites   10m 25s ⏱️
1 793 tests 1 792 ✅ 0 💤 1 ❌
1 864 runs  1 862 ✅ 0 💤 2 ❌

For more details on these failures, see this check.

Results for commit a838811.

♻️ This comment has been updated with latest results.

[Copilot]

Pull request overview

This PR introduces a dedicated use case to centralize the “location disabled while location-dependent features are active” check, and refactors call sites to use the extracted logic and shared settings intent creation.

Changes:

• Added CheckLocationDisabledUseCase and wired it into the legacy WebViewActivity flow and the new LaunchActivity (Frontend V2) flow
• Refactored DisabledLocationHandler to provide a reusable locationSettingsIntent(...) and a dedicated showLocationDisabledNotification(...)
• Updated multiple call sites to reuse locationSettingsIntent(...) and added unit tests for the new use case

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
common/src/main/kotlin/io/homeassistant/companion/android/common/util/DisabledLocationHandler.kt	Adds locationSettingsIntent + notification helper; simplifies dialog path; makes warning removal accept Context
app/src/main/kotlin/io/homeassistant/companion/android/util/CheckLocationDisabledUseCase.kt	New use case that decides whether to show/remove the location-disabled notification
app/src/main/kotlin/io/homeassistant/companion/android/webview/WebViewActivity.kt	Replaces inline location-disabled checking logic with the injected use case
app/src/main/kotlin/io/homeassistant/companion/android/launch/LaunchActivity.kt	Invokes the use case on onResume when Frontend V2 flag is enabled
app/src/main/kotlin/io/homeassistant/companion/android/webview/insecure/BlockInsecureFragment.kt	Reuses DisabledLocationHandler.locationSettingsIntent(...)
app/src/main/kotlin/io/homeassistant/companion/android/util/compose/HANavHost.kt	Reuses DisabledLocationHandler.locationSettingsIntent(...)
app/src/main/kotlin/io/homeassistant/companion/android/settings/ssid/SsidFragment.kt	Removes now-deleted showAsNotification argument from dialog call
app/src/test/kotlin/io/homeassistant/companion/android/frontend/CheckLocationDisabledUseCaseTest.kt	Adds unit tests for the new use case

[jpelgrom]

and show a permission

I'm guessing you meant to write 'and show a notification'.

Some users have notifications disabled and/or ignore notifications. This change also removes the dialog in the WebViewActivity, making it easier to miss. I think there still should be something harder to ignore when actually opening the app, no?

[TimoPtr]

and show a permission

I'm guessing you meant to write 'and show a notification'.

Some users have notifications disabled and/or ignore notifications. This change also removes the dialog in the WebViewActivity, making it easier to miss. I think there still should be something harder to ignore when actually opening the app, no?

I made this change because I think that in the current impl we never show the dialog we only show the notification

We set the showAsNotification to true and then the logic if ((!withDisableOption || callback == null) && showAsNotification) { where the callback is always null. Am I missing something?

[jpelgrom]

I made this change because I think that in the current impl we never show the dialog we only show the notification

You're right 🤔. I remember seeing this at some point but the git history says it's been like this for a long time. I still think there's an argument that we need to highlight this better but then that's outside the scope of the PR.

[jpelgrom]

When testing I forgot to actually enable something that requires location 🤦. After adding a home Wi-Fi network it worked perfectly!