Allow settings auto favorite from automotive#6718
Conversation
|
Hi everyone, ,it's my firt PR for HA, .It's only for Android automotive :) |
There was a problem hiding this comment.
Pull request overview
Adds an in-car “Manage favorites” flow for Android Automotive (full flavor) so users can edit the Driving favorites list when the vehicle is not in distraction-optimized mode.
Changes:
- Add a new Automotive screen to toggle favorites across supported entities, including simple paging
- Add a “Manage favorites” header action on Automotive screens for the
fullflavor when parked - Refactor Automotive UX restriction handling in
BaseVehicleScreen
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| common/src/main/res/values/strings.xml | Adds strings for the new “Manage favorites” UI and paging labels |
| app/src/main/kotlin/io/homeassistant/companion/android/vehicle/ManageFavoritesVehicleScreen.kt | New Automotive screen to add/remove favorites via toggles |
| app/src/main/kotlin/io/homeassistant/companion/android/vehicle/MainVehicleScreen.kt | Adds header action to open favorites management when parked (full flavor) |
| app/src/main/kotlin/io/homeassistant/companion/android/vehicle/DomainListScreen.kt | Adds the same header action on the domain list screen |
| app/src/main/kotlin/io/homeassistant/companion/android/vehicle/BaseVehicleScreen.kt | Updates how UX restriction state is sourced and logs restriction changes |
| app/src/main/kotlin/io/homeassistant/companion/android/util/vehicle/TemplateComponents.kt | Adds helper to create the “Manage favorites” header action |
| .idea/markdown.xml | Adds IDE configuration file (should not be committed) |
Files not reviewed (1)
- .idea/markdown.xml: Language not supported
…/ManageFavoritesVehicleScreen.kt Logging raw entityId can leak user-specific information (entity IDs often include user-defined names). Prefer removing these logs or wrapping the value with sensitive(...) as used elsewhere in the app. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
aa_manage_favorites_parked_only is added but not referenced anywhere in the PR. If it’s not needed, remove it to avoid unused resource warnings; if it is needed, wire it into the UI where the parked-only restriction is enforced. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…/DomainListScreen.kt Kotlin style in this codebase generally uses trailing commas for multiline argument lists; add a trailing comma after prefsRepository to match surrounding calls and avoid ktlint churn. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…/MainVehicleScreen.kt Kotlin style in this codebase generally uses trailing commas for multiline argument lists; add a trailing comma after prefsRepository to match surrounding calls and avoid ktlint churn. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…/ManageFavoritesVehicleScreen.kt
Sorting computes favorite membership with favoritesList.any { ... } for every entity, which is O(entities × favorites). Consider building a Set (or HashSet) of favorite entityIds for the current server once per update and using contains in both the sort and row-building logic.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…/ManageFavoritesVehicleScreen.kt itemsPerPage always reserves space for both paging rows by doing listLimit - 2, even when only one (or neither) paging row is shown. This reduces the number of entities shown per page unnecessarily and can make paging feel off. Consider calculating the reserved rows based on hasPreviousPage/hasNextPage for the current page. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…cddu33/android into feature/add-favorite-automotive
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…cddu33/android into feature/add-favorite-automotive
This reverts commit 03b9cc0. Co-authored-by: Claude <noreply@anthropic.com>
|
Hi @TimoPtr i updated my PR , thanks for your feedback |
There was a problem hiding this comment.
ktlint found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
…/ManageFavoritesVehicleScreen.kt Co-authored-by: Timothy <6560631+TimoPtr@users.noreply.github.com>
…/ManageFavoritesVehicleScreen.kt Co-authored-by: Timothy <6560631+TimoPtr@users.noreply.github.com>
|
From claude I think you need to spend sometime writing some tests on your pagination logic. |
…/ManageFavoritesVehicleScreen.kt Co-authored-by: Timothy <6560631+TimoPtr@users.noreply.github.com>
- Wrap state into UIState data class protected by stateMutex - Move prev/next pagination to header (addEndHeaderAction) to free list slots - Add SearchFavoritesVehicleScreen (private) with SearchTemplate for inline filtering - Fix computePageSlice: page clamped, no slot wasted since nav is in header - Extract shared helpers: persistFavoriteToggle, compareByFavoriteThenName, etc. - Resolve merge conflict with origin/feature/add-favorite-automotive - Add strings: aa_search_entities, aa_search_no_results Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Hi, i re write all the page , add a search box and next/previous on the bottom. I user frindly name directly and added your feedback I test it on the simulator |
|
After a discussion on Discord https://discord.com/channels/330944238910963714/1346948551892009101/1503311499836395550 we think that we could try maybe first to simply open the entire What I propose is that we park this PR for now (not closing), we open another PR that simply allow opening the settings when not driving. If Google reject this then we fallback to this PR. Wdyt @cddu33 ? CC @jpelgrom |
Summary
I have a Renault Scenic with Android Automotive, but Debug Mode is secured. Therefore, I can't install the minimal version of Home Assistant.
I created a 'favorites' mode for the full release. Users can add favorites on the home screen only when the car is parked (not while driving).
Checklist
Screenshots