chore(deps): bump spx to 2.0.4#3312
Conversation
There was a problem hiding this comment.
Code Review
This pull request upgrades the spx dependency from version 2.0.3 to 2.0.4 across the repository, including configuration files, installation scripts, and Go module dependencies (tools/ai, tools/ispx, and tools/spxls). Additionally, it updates the documentation in .github/agents/spx-upgrader.md to clarify that warning messages regarding unmatched packages during testing of tools/spxls/ are acceptable. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
9110187 to
5a535e9
Compare
There was a problem hiding this comment.
Review summary
Clean, mechanical bump of the SPX runtime 2.0.3 → 2.0.4. I verified that every SPX version reference in the repo is centralized in the nine changed files (VITE_SPX_VERSION in .env, SPX_VERSION in install-spx.sh, and the four go.mod/go.sum pairs) and all are consistently updated — no stale 2.0.3 reference remains, and TS source references only the package path (github.com/goplus/spx/v2), not a version.
One minor wording finding on the upgrader checklist (inline). Performance and security passes surfaced nothing actionable in the diff.
Note (not a finding): the …/go.mod h1: checksum is identical between 2.0.3 and 2.0.4 in all three go.sum files. This is expected — the dependency's own go.mod did not change between these patch releases — while the source h1: hash correctly changed (Qb3n2/… → 4hyCM5…). No action needed.
5a535e9 to
c48e44c
Compare
| require ( | ||
| github.com/goplus/builder/tools/ai v0.0.0 | ||
| github.com/goplus/xgolsw v0.21.1-0.20260601022856-658bbeba671b | ||
| github.com/goplus/xgolsw v0.21.1-0.20260625100638-5f3cd6593261 |
There was a problem hiding this comment.
我看 xgolsw 升级了 spx,所以把 xgolsw 也更新到对应版本
| - Execute `bash spx-gui/install-spx.sh` to download the matching runtime assets and remove any temporary archives | ||
| - Execute `bash build-wasm.sh` in `spx-gui/` to build Wasm components | ||
| - Run `npm ci`, `npm run lint`, `npm run test -- --run` in `spx-gui/`, plus `go test ./...` inside `tools/ai/`, `tools/spxls/`, and `tools/ispx/` | ||
| - Run `npm ci`, `npm run lint`, `npm run test -- --run` in `spx-gui/`, plus `go test ./...` inside `tools/ai/`, `tools/spxls/`, and `tools/ispx/` if there are packages to test |
There was a problem hiding this comment.
tools/spxls/ 没有 package,运行 go test ./... 会报错,然后这个文档又要求了 agent
If any command fails, stop immediately and report the exact output instead of continuing
经常会导致升级 spx 的 agent 在这里退出,所以补充个说明
Summary
Release notes
https://github.com/goplus/spx/releases/tag/v2.0.4
Validation
gh release view --repo goplus/spx v2.0.4bash spx-gui/install-spx.shbash build-wasm.shinspx-gui/npm ciinspx-gui/npm run lintinspx-gui/npm run test -- --runinspx-gui/(73 files, 703 tests)go test ./...intools/ai/go test ./...intools/ispx/go test ./...intools/spxls/reported no packages to test, which is expected for this module