Skip to content

chore(deps): bump spx to 2.0.4#3312

Merged
nighca merged 2 commits into
goplus:devfrom
nighca:chore/bump-spx-2.0.4
Jun 30, 2026
Merged

chore(deps): bump spx to 2.0.4#3312
nighca merged 2 commits into
goplus:devfrom
nighca:chore/bump-spx-2.0.4

Conversation

@nighca

@nighca nighca commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Bump XBuilder's SPX runtime version from 2.0.3 to 2.0.4
  • Refresh SPX Go module dependencies in tools/ai, tools/spxls, and tools/ispx
  • Document that tools/spxls has no packages to test when running the SPX upgrader checklist

Release notes

https://github.com/goplus/spx/releases/tag/v2.0.4

Validation

  • gh release view --repo goplus/spx v2.0.4
  • bash spx-gui/install-spx.sh
  • bash build-wasm.sh in spx-gui/
  • npm ci in spx-gui/
  • npm run lint in spx-gui/
  • npm run test -- --run in spx-gui/ (73 files, 703 tests)
  • go test ./... in tools/ai/
  • go test ./... in tools/ispx/
  • go test ./... in tools/spxls/ reported no packages to test, which is expected for this module

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades the spx dependency from version 2.0.3 to 2.0.4 across the repository, including configuration files, installation scripts, and Go module dependencies (tools/ai, tools/ispx, and tools/spxls). Additionally, it updates the documentation in .github/agents/spx-upgrader.md to clarify that warning messages regarding unmatched packages during testing of tools/spxls/ are acceptable. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary

Clean, mechanical bump of the SPX runtime 2.0.3 → 2.0.4. I verified that every SPX version reference in the repo is centralized in the nine changed files (VITE_SPX_VERSION in .env, SPX_VERSION in install-spx.sh, and the four go.mod/go.sum pairs) and all are consistently updated — no stale 2.0.3 reference remains, and TS source references only the package path (github.com/goplus/spx/v2), not a version.

One minor wording finding on the upgrader checklist (inline). Performance and security passes surfaced nothing actionable in the diff.

Note (not a finding): the …/go.mod h1: checksum is identical between 2.0.3 and 2.0.4 in all three go.sum files. This is expected — the dependency's own go.mod did not change between these patch releases — while the source h1: hash correctly changed (Qb3n2/…4hyCM5…). No action needed.

Comment thread .github/agents/spx-upgrader.md
@nighca nighca force-pushed the chore/bump-spx-2.0.4 branch from 5a535e9 to c48e44c Compare June 30, 2026 01:14
Comment thread tools/spxls/go.mod
require (
github.com/goplus/builder/tools/ai v0.0.0
github.com/goplus/xgolsw v0.21.1-0.20260601022856-658bbeba671b
github.com/goplus/xgolsw v0.21.1-0.20260625100638-5f3cd6593261

@nighca nighca Jun 30, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我看 xgolsw 升级了 spx,所以把 xgolsw 也更新到对应版本

- Execute `bash spx-gui/install-spx.sh` to download the matching runtime assets and remove any temporary archives
- Execute `bash build-wasm.sh` in `spx-gui/` to build Wasm components
- Run `npm ci`, `npm run lint`, `npm run test -- --run` in `spx-gui/`, plus `go test ./...` inside `tools/ai/`, `tools/spxls/`, and `tools/ispx/`
- Run `npm ci`, `npm run lint`, `npm run test -- --run` in `spx-gui/`, plus `go test ./...` inside `tools/ai/`, `tools/spxls/`, and `tools/ispx/` if there are packages to test

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tools/spxls/ 没有 package,运行 go test ./... 会报错,然后这个文档又要求了 agent

If any command fails, stop immediately and report the exact output instead of continuing

经常会导致升级 spx 的 agent 在这里退出,所以补充个说明

@nighca nighca enabled auto-merge (squash) June 30, 2026 01:53
@nighca nighca merged commit 3cb7cc0 into goplus:dev Jun 30, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants