Skip to content

Enhancement/11092 refactor reporting key events datapoints#12391

Merged
hussain-t merged 8 commits intodevelopfrom
enhancement/11092-refactor-reporting-key-events-datapoints
Apr 8, 2026
Merged

Enhancement/11092 refactor reporting key events datapoints#12391
hussain-t merged 8 commits intodevelopfrom
enhancement/11092-refactor-reporting-key-events-datapoints

Conversation

@abdelmalekkkkk
Copy link
Copy Markdown
Collaborator

@abdelmalekkkkk abdelmalekkkkk commented Mar 26, 2026 •
edited by hussain-t
Loading

Summary

Addresses issue:

Relevant technical choices

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.
  • Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 26, 2026 •
edited
Loading

🤖 This comment is automatically updated by CI workflows. Each section is managed independently.

📦 Build files for 5ab1bf9:

🎭 Playwright reports for 5ab1bf9:

hussain-t
hussain-t requested changes Apr 6, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@hussain-t hussain-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @abdelmalekkkkk! Could you please resolve the conflicts with the latest develop and send it back?

@abdelmalekkkkk abdelmalekkkkk force-pushed the enhancement/11092-refactor-reporting-key-events-datapoints branch from 99e0f3f to bf546b0 Compare April 6, 2026 15:10
@abdelmalekkkkk
Copy link
Copy Markdown
Collaborator Author

abdelmalekkkkk commented Apr 6, 2026

@hussain-t Done! Back to you.

hussain-t
hussain-t requested changes Apr 7, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@hussain-t hussain-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @abdelmalekkkkk! Overall, the changes look good. However, I've left a concern and a few minor comments. Please take a look.

@abdelmalekkkkk abdelmalekkkkk force-pushed the enhancement/11092-refactor-reporting-key-events-datapoints branch 2 times, most recently from 5168e7c to 1a10f88 Compare April 7, 2026 11:42
@abdelmalekkkkk abdelmalekkkkk force-pushed the enhancement/11092-refactor-reporting-key-events-datapoints branch from 1a10f88 to 5ab1bf9 Compare April 7, 2026 11:53
@abdelmalekkkkk
Copy link
Copy Markdown
Collaborator Author

abdelmalekkkkk commented Apr 7, 2026

Thanks @hussain-t. I addressed all your comments. Please take another look.

hussain-t
hussain-t approved these changes Apr 8, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@hussain-t hussain-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @abdelmalekkkkk! LGTM 👍

Note: I've verified that the CI build failures are unrelated to this PR.

@hussain-t hussain-t merged commit e63ffe4 into develop Apr 8, 2026
27 of 29 checks passed
@hussain-t hussain-t deleted the enhancement/11092-refactor-reporting-key-events-datapoints branch April 8, 2026 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hussain-t hussain-t hussain-t approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@abdelmalekkkkk @hussain-t