Add support for joypad triggers vibration#116214
Draft
Nintorch wants to merge 1 commit into
Draft
Conversation
85 tasks
This was referenced Feb 13, 2026
Nintorch
commented
Feb 16, 2026
| <return type="bool" /> | ||
| <param index="0" name="device" type="int" /> | ||
| <description> | ||
| Returns [code]true[/code] if the joypad has triggers vibration (trigger rumble). |
Member
Author
There was a problem hiding this comment.
Suggested change
| Returns [code]true[/code] if the joypad has triggers vibration (trigger rumble). | |
| Returns [code]true[/code] if the joypad has triggers vibration (trigger rumble). Not to be confused with DualSense's adaptive triggers. |
Nintorch
commented
Apr 9, 2026
| } | ||
|
|
||
| bool JoypadSDL::Joypad::has_joy_triggers_vibration() const { | ||
| return SDL_GetGamepadTypeForID(sdl_instance_idx) == SDL_GAMEPAD_TYPE_XBOXONE; |
Member
Author
There was a problem hiding this comment.
I should probably check here if SDL_RumbleJoystickTriggers doesn't return an error, and if it does, trigger vibration is not supported.
EDIT: Just remembered there should be a joystick property for that similarly to how we check for LED support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires #116055 to be merged first.
This functionality has been split from #107967 and adjusted to the new advanced joypad features system.
This PR adds the ability to use Xbox One controller's trigger rumble. Note that on Windows it's not possible to use the HIDAPI driver for Xbox controller (even if we set the corresponding environment variable to 1) and trigger rumble is not available in DirectInput or XInput, that's why WGI or GameInput are required for this PR.
I tested this PR in my fork with GameInput and it seems to be working!
I don't have a DualSense controller, but personally it feels like trigger rumble might work quite similarly to adaptive triggers if used correctly, so it might make sense to implement it alongside #111682 , see also godotengine/godot-proposals#12087 .
TODO: