Skip to content

Fix literal matching for user-defined literals #1135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mbaluda wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fix literal matching for user-defined literals #1135

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
850a1d5
Fix regex for octal literal matching
mbaluda May 19, 2026
f484080
Exclude user-defined literals and templates
mbaluda May 21, 2026
2b15b72
add release notes
mbaluda May 21, 2026
e02b355
Potential fix for pull request finding
mbaluda May 21, 2026
acc2856
Potential fix for pull request finding
mbaluda May 21, 2026
aae7003
Use codingstandards.cpp.UserDefinedLiteral
mbaluda May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/common/src/codingstandards/cpp/Cpp14Literal.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ module Cpp14Literal {
* Octal literals must always start with the digit `0`.
*/
class OctalLiteral extends IntegerLiteral, RecognizedNumericLiteral {
OctalLiteral() { getValueText().regexpMatch("\\s*0[0-7']*[uUlL]*\\s*") }
OctalLiteral() { getValueText().regexpMatch("\\s*0[0-7']+[uUlL]*\\s*") }
Comment thread
mbaluda marked this conversation as resolved.
Outdated

override string getAPrimaryQlClass() { result = "OctalLiteral" }
}
Expand Down
Loading